| Message ID | 20231011135754.13508-1-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | drivers: hwmon: ltc2992: avoid division by zero | expand |
On Wed, Oct 11, 2023 at 04:57:53PM +0300, Antoniu Miclaus wrote: > Do not allow setting shunt resistor to 0. This results in a division by > zero when performing current value computations based on input voltages > and connected resistor values. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> Applied. Please note that the subject should not include "drivers:". Guenter
diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c index 589bcd07ce7f..001799bc28ed 100644 --- a/drivers/hwmon/ltc2992.c +++ b/drivers/hwmon/ltc2992.c @@ -875,8 +875,12 @@ static int ltc2992_parse_dt(struct ltc2992_state *st) } ret = fwnode_property_read_u32(child, "shunt-resistor-micro-ohms", &val); - if (!ret) + if (!ret) { + if (!val) + return dev_err_probe(&st->client->dev, -EINVAL, + "shunt resistor value cannot be zero\n"); st->r_sense_uohm[addr] = val; + } } return 0;
Do not allow setting shunt resistor to 0. This results in a division by zero when performing current value computations based on input voltages and connected resistor values. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- drivers/hwmon/ltc2992.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)