| Message ID | 20231116-hwmon_abi-v1-3-8bfb7f51145a@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ABI: sysfs-class-hwmon: document existing attributes | expand |
On Fri, Nov 17, 2023 at 07:40:36AM +0100, Javier Carrasco wrote: > This attribute is defined as read-only by all drivers that support it. > > It seems that the access rights and description for this attribute were > copied from the intrusionY_alarm, which has indeed RW rights and must be > cleared by the user. > > These are the modules that currently use this attribute: > - adt7x10 > - i5500_temp > - jc42 > - lm83 > - lm90 > - lm95245 > - max31760 > - max6621 > - mc34vr500 > - tmp401 > - tmp464 > - tmp513 > > Fix the attribute description and make it read-only. > > Fixes: 365b5d63a505 ("ABI: sysfs-class-hwmon: add a description for tempY_crit_alarm") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Applied. Thanks, Guenter
diff --git a/Documentation/ABI/testing/sysfs-class-hwmon b/Documentation/ABI/testing/sysfs-class-hwmon index dccbcdc2dad8..3d5e6142ef0c 100644 --- a/Documentation/ABI/testing/sysfs-class-hwmon +++ b/Documentation/ABI/testing/sysfs-class-hwmon @@ -434,12 +434,7 @@ Description: - 0: OK - 1: temperature has reached tempY_crit - RW - - Contrary to regular alarm flags which clear themselves - automatically when read, this one sticks until cleared by - the user. This is done by writing 0 to the file. Writing - other values is unsupported. + RO What: /sys/class/hwmon/hwmonX/tempY_crit_hyst Description:
This attribute is defined as read-only by all drivers that support it. It seems that the access rights and description for this attribute were copied from the intrusionY_alarm, which has indeed RW rights and must be cleared by the user. These are the modules that currently use this attribute: - adt7x10 - i5500_temp - jc42 - lm83 - lm90 - lm95245 - max31760 - max6621 - mc34vr500 - tmp401 - tmp464 - tmp513 Fix the attribute description and make it read-only. Fixes: 365b5d63a505 ("ABI: sysfs-class-hwmon: add a description for tempY_crit_alarm") Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- Documentation/ABI/testing/sysfs-class-hwmon | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)