Message ID | 20240131055526.2700452-2-ythsu0511@gmail.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | [v3,1/2] hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter | expand |
On 1/30/24 21:55, Charles Hsu wrote: > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. > > Signed-off-by: Charles Hsu <ythsu0511@gmail.com> This should be the first patch of the series. Thanks, Guenter
On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. > > Signed-off-by: Charles Hsu <ythsu0511@gmail.com> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 79dcd92c4a43..088b23ed2ae6 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -129,6 +129,8 @@ properties: > - mps,mp2975 > # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 > - mps,mp5990 > + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 > + - mps,mpq8785 q sorts before 2, otherwise Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > # Honeywell Humidicon HIH-6130 humidity/temperature sensor > - honeywell,hi6130 > # IBM Common Form Factor Power Supply Versions (all versions) > -- > 2.34.1 >
On Wed, Jan 31, 2024 at 11:41 PM Conor Dooley <conor@kernel.org> wrote: > > On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: > > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. > > > > Signed-off-by: Charles Hsu <ythsu0511@gmail.com> > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 79dcd92c4a43..088b23ed2ae6 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -129,6 +129,8 @@ properties: > > - mps,mp2975 > > # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 > > - mps,mp5990 > > + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 > > + - mps,mpq8785 > > q sorts before 2, otherwise Okay, I got it. > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. > > > # Honeywell Humidicon HIH-6130 humidity/temperature sensor > > - honeywell,hi6130 > > # IBM Common Form Factor Power Supply Versions (all versions) > > -- > > 2.34.1 > >
On 1/31/24 07:41, Conor Dooley wrote: > On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: >> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. >> >> Signed-off-by: Charles Hsu <ythsu0511@gmail.com> >> --- >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 79dcd92c4a43..088b23ed2ae6 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -129,6 +129,8 @@ properties: >> - mps,mp2975 >> # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 >> - mps,mp5990 >> + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 >> + - mps,mpq8785 > > q sorts before 2, otherwise It does ? Not in ASCII. Am I missing something ? Thanks, Guenter
On 01/02/2024 01:41, Guenter Roeck wrote: > On 1/31/24 07:41, Conor Dooley wrote: >> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: >>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. >>> >>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com> >>> --- >>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >>> index 79dcd92c4a43..088b23ed2ae6 100644 >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >>> @@ -129,6 +129,8 @@ properties: >>> - mps,mp2975 >>> # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 >>> - mps,mp5990 >>> + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 >>> + - mps,mpq8785 >> >> q sorts before 2, otherwise > > It does ? Not in ASCII. Am I missing something ? Also `sort` agrees with q being after numbers. Best regards, Krzysztof
On 31/01/2024 16:41, Conor Dooley wrote: > On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: >> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. >> >> Signed-off-by: Charles Hsu <ythsu0511@gmail.com> >> --- >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 79dcd92c4a43..088b23ed2ae6 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -129,6 +129,8 @@ properties: >> - mps,mp2975 >> # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 >> - mps,mp5990 >> + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 >> + - mps,mpq8785 > > q sorts before 2, otherwise > Acked-by: Conor Dooley <conor.dooley@microchip.com> I will sort the file and my patch should go via Rob's tree, I guess, so maybe this one could go as well? Best regards, Krzysztof
On Thu, Feb 01, 2024 at 08:47:07AM +0100, Krzysztof Kozlowski wrote: > On 01/02/2024 01:41, Guenter Roeck wrote: > > On 1/31/24 07:41, Conor Dooley wrote: > >> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: > >>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. > >>> > >>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com> > >>> --- > >>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > >>> index 79dcd92c4a43..088b23ed2ae6 100644 > >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml > >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > >>> @@ -129,6 +129,8 @@ properties: > >>> - mps,mp2975 > >>> # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 > >>> - mps,mp5990 > >>> + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 > >>> + - mps,mpq8785 > >> > >> q sorts before 2, otherwise > > > > It does ? Not in ASCII. Am I missing something ? > > Also `sort` agrees with q being after numbers. Disregard that comment so.
On Thu, Feb 01, 2024 at 08:34:32AM +0800, 徐永謄 wrote: > On Wed, Jan 31, 2024 at 11:41 PM Conor Dooley <conor@kernel.org> wrote: > > > > On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: > > > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. > > > > > > Signed-off-by: Charles Hsu <ythsu0511@gmail.com> > > > --- > > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > > index 79dcd92c4a43..088b23ed2ae6 100644 > > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > > @@ -129,6 +129,8 @@ properties: > > > - mps,mp2975 > > > # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 > > > - mps,mp5990 > > > + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 > > > + - mps,mpq8785 > > > > q sorts before 2, otherwise > Okay, I got it. Apparently I am wrong, sorry about that! Please ignore this comment. Thanks, Conor.
On 1/31/24 23:52, Krzysztof Kozlowski wrote: > On 31/01/2024 16:41, Conor Dooley wrote: >> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote: >>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. >>> >>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com> >>> --- >>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >>> index 79dcd92c4a43..088b23ed2ae6 100644 >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >>> @@ -129,6 +129,8 @@ properties: >>> - mps,mp2975 >>> # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 >>> - mps,mp5990 >>> + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 >>> + - mps,mpq8785 >> >> q sorts before 2, otherwise >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > I will sort the file and my patch should go via Rob's tree, I guess, so > maybe this one could go as well? > Sure, fine with me. I applied the patch to the hwmon tree, but I have no problems dropping it from there. Sorry, I never know if I should take .yaml patches or not. Guenter
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 79dcd92c4a43..088b23ed2ae6 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -129,6 +129,8 @@ properties: - mps,mp2975 # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 - mps,mp5990 + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 + - mps,mpq8785 # Honeywell Humidicon HIH-6130 humidity/temperature sensor - honeywell,hi6130 # IBM Common Form Factor Power Supply Versions (all versions)
Monolithic Power Systems, Inc. (MPS) synchronous step-down converter. Signed-off-by: Charles Hsu <ythsu0511@gmail.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)