| Message ID | 20240414042246.8681-2-chanh@os.amperecomputing.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Update the max31790 driver | expand |
On 14/04/2024 06:22, Chanh Nguyen wrote: > Add a device tree bindings for max31790 device. > Nothing improved in commit msg, where is the rationale of split of bindings? A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> > --- > Changes in v2: > - Update filename of the maxim,max31790.yaml [Krzysztof] > - Add the common fan schema to $ref [Krzysztof] > - Update the node name to "fan-controller" in maxim,max31790.yaml [Krzysztof] > - Drop "driver" in commit title [Krzysztof] > --- > .../bindings/hwmon/maxim,max31790.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml > new file mode 100644 > index 000000000000..a561e5a3e9e4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: The Maxim MAX31790 Fan Controller > + > +maintainers: > + - Guenter Roeck <linux@roeck-us.net> > + > +description: > > + The MAX31790 controls the speeds of up to six fans using six > + independent PWM outputs. The desired fan speeds (or PWM duty cycles) > + are written through the I2C interface. > + > + Datasheets: > + https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf > + > +properties: > + compatible: > + const: maxim,max31790 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +allOf: > + - $ref: fan-common.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan-controller@20 { > + compatible = "maxim,max31790"; > + reg = <0x20>; Make the example complete - add all properties, like clocks, resets and any others which are applicable. Best regards, Krzysztof
On 14/04/2024 13:03, Krzysztof Kozlowski wrote: > On 14/04/2024 06:22, Chanh Nguyen wrote: >> Add a device tree bindings for max31790 device. >> > > Nothing improved in commit msg, where is the rationale of split of bindings? > Yes Krzysztof, I will use "tach-ch" property from the fan-common.yaml to solve my case. So I will not need a split of bindings. Finally, my patch series will only be two patches. They are "dt-bindings: hwmon: Add maxim max31790" and "hwmon: (max31790): Support config PWM output becomes TACH". I'm going to update that in the patch v3 series. > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > Thank Krzysztof, I'll drop "bindings" in commit msg. >> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> >> --- >> Changes in v2: >> - Update filename of the maxim,max31790.yaml [Krzysztof] >> - Add the common fan schema to $ref [Krzysztof] >> - Update the node name to "fan-controller" in maxim,max31790.yaml [Krzysztof] >> - Drop "driver" in commit title [Krzysztof] >> --- >> .../bindings/hwmon/maxim,max31790.yaml | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml >> >> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml >> new file mode 100644 >> index 000000000000..a561e5a3e9e4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: The Maxim MAX31790 Fan Controller >> + >> +maintainers: >> + - Guenter Roeck <linux@roeck-us.net> >> + >> +description: > >> + The MAX31790 controls the speeds of up to six fans using six >> + independent PWM outputs. The desired fan speeds (or PWM duty cycles) >> + are written through the I2C interface. >> + >> + Datasheets: >> + https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf >> + >> +properties: >> + compatible: >> + const: maxim,max31790 >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +allOf: >> + - $ref: fan-common.yaml# >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + fan-controller@20 { >> + compatible = "maxim,max31790"; >> + reg = <0x20>; > > Make the example complete - add all properties, like clocks, resets and > any others which are applicable. > Ok Krzysztof, I'll update that in the patch v3 > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file mode 100644 index 000000000000..a561e5a3e9e4 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: The Maxim MAX31790 Fan Controller + +maintainers: + - Guenter Roeck <linux@roeck-us.net> + +description: > + The MAX31790 controls the speeds of up to six fans using six + independent PWM outputs. The desired fan speeds (or PWM duty cycles) + are written through the I2C interface. + + Datasheets: + https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf + +properties: + compatible: + const: maxim,max31790 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + +required: + - compatible + - reg + +allOf: + - $ref: fan-common.yaml# + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + fan-controller@20 { + compatible = "maxim,max31790"; + reg = <0x20>; + }; + };
Add a device tree bindings for max31790 device. Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com> --- Changes in v2: - Update filename of the maxim,max31790.yaml [Krzysztof] - Add the common fan schema to $ref [Krzysztof] - Update the node name to "fan-controller" in maxim,max31790.yaml [Krzysztof] - Drop "driver" in commit title [Krzysztof] --- .../bindings/hwmon/maxim,max31790.yaml | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml