| Message ID | 20240425070948.25788-2-jose.sanbuenaventura@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add adm1281 support | expand |
On Thu, Apr 25, 2024 at 03:09:47PM +0800, Jose Ramon San Buenaventura wrote: > Add support for the adm1281 Hot-Swap Controller and Digital Power > and Energy Monitor > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> I acked this, but I'm having second thoughts. The 1281 follows the same codepaths in the driver as the 1278, why is the 1278 not used as a fallback compatible here? Thanks, Conor. > --- > Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > index b68061294..5b076d677 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > @@ -5,7 +5,7 @@ > $id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors > +title: Analog Devices ADM1075/ADM127x/ADM1281/ADM129x digital power monitors > > maintainers: > - Krzysztof Kozlowski <krzk@kernel.org> > @@ -27,6 +27,7 @@ properties: > - adi,adm1275 > - adi,adm1276 > - adi,adm1278 > + - adi,adm1281 > - adi,adm1293 > - adi,adm1294 > > @@ -91,6 +92,7 @@ allOf: > contains: > enum: > - adi,adm1278 > + - adi,adm1281 > - adi,adm1293 > - adi,adm1294 > then: > -- > 2.39.2 >
On 4/25/24 00:19, Conor Dooley wrote: > On Thu, Apr 25, 2024 at 03:09:47PM +0800, Jose Ramon San Buenaventura wrote: >> Add support for the adm1281 Hot-Swap Controller and Digital Power >> and Energy Monitor >> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> > > I acked this, but I'm having second thoughts. The 1281 follows the same > codepaths in the driver as the 1278, why is the 1278 not used as a > fallback compatible here? > That is rare for those devices es but true in this case. Technically possible, though it would result in a "Device mismatch" notification by the driver since it compares the configured vs. actual device IDs. I would prefer to avoid that, if for nothing else to avoid having to deal with concerned users. Thanks, Guenter
On Thu, Apr 25, 2024 at 03:09:47PM +0800, Jose Ramon San Buenaventura wrote: > Add support for the adm1281 Hot-Swap Controller and Digital Power > and Energy Monitor > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> Applied. Thanks, Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml index b68061294..5b076d677 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml @@ -5,7 +5,7 @@ $id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors +title: Analog Devices ADM1075/ADM127x/ADM1281/ADM129x digital power monitors maintainers: - Krzysztof Kozlowski <krzk@kernel.org> @@ -27,6 +27,7 @@ properties: - adi,adm1275 - adi,adm1276 - adi,adm1278 + - adi,adm1281 - adi,adm1293 - adi,adm1294 @@ -91,6 +92,7 @@ allOf: contains: enum: - adi,adm1278 + - adi,adm1281 - adi,adm1293 - adi,adm1294 then: