| Message ID | 20240512161921.850683-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (nzxt-kraken3) Bail out for unsupported device variants | expand |
On Sun, May 12, 2024 at 09:19:21AM GMT, Guenter Roeck wrote: > Dan Carpenter reports: > > Commit cbeb479ff4cd ("hwmon: (nzxt-kraken3) Decouple device names > from kinds") from Apr 28, 2024 (linux-next), leads to the following > Smatch static checker warning: > > drivers/hwmon/nzxt-kraken3.c:957 kraken3_probe() > error: uninitialized symbol 'device_name'. > > Indeed, 'device_name' will be uninitizalized if an unknown product is > encountered. In practice this should not matter because the driver > should not instantiate on unknown products, but lets play safe and > bail out if that happens. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/linux-hwmon/b1738c50-db42-40f0-a899-9c027c131ffb@moroto.mountain/ > Cc: Jonas Malaco <jonas@protocubo.io> > Cc: Aleksa Savic <savicaleksa83@gmail.com> > Fixes: cbeb479ff4cd ("hwmon: (nzxt-kraken3) Decouple device names from kinds") > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > I updated the SHA in Dan's report; the branch has since been rebased. > > drivers/hwmon/nzxt-kraken3.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/nzxt-kraken3.c b/drivers/hwmon/nzxt-kraken3.c > index 0b3f04c740b0..00f3ac90a290 100644 > --- a/drivers/hwmon/nzxt-kraken3.c > +++ b/drivers/hwmon/nzxt-kraken3.c > @@ -928,7 +928,8 @@ static int kraken3_probe(struct hid_device *hdev, const struct hid_device_id *id > device_name = "kraken2023elite"; > break; > default: > - break; > + ret = -ENODEV; > + goto fail_and_close; > } > > priv->buffer = devm_kzalloc(&hdev->dev, MAX_REPORT_LENGTH, GFP_KERNEL); > -- > 2.39.2 > Acked-by: Jonas Malaco <jonas@protocubo.io>
diff --git a/drivers/hwmon/nzxt-kraken3.c b/drivers/hwmon/nzxt-kraken3.c index 0b3f04c740b0..00f3ac90a290 100644 --- a/drivers/hwmon/nzxt-kraken3.c +++ b/drivers/hwmon/nzxt-kraken3.c @@ -928,7 +928,8 @@ static int kraken3_probe(struct hid_device *hdev, const struct hid_device_id *id device_name = "kraken2023elite"; break; default: - break; + ret = -ENODEV; + goto fail_and_close; } priv->buffer = devm_kzalloc(&hdev->dev, MAX_REPORT_LENGTH, GFP_KERNEL);
Dan Carpenter reports: Commit cbeb479ff4cd ("hwmon: (nzxt-kraken3) Decouple device names from kinds") from Apr 28, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/hwmon/nzxt-kraken3.c:957 kraken3_probe() error: uninitialized symbol 'device_name'. Indeed, 'device_name' will be uninitizalized if an unknown product is encountered. In practice this should not matter because the driver should not instantiate on unknown products, but lets play safe and bail out if that happens. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/linux-hwmon/b1738c50-db42-40f0-a899-9c027c131ffb@moroto.mountain/ Cc: Jonas Malaco <jonas@protocubo.io> Cc: Aleksa Savic <savicaleksa83@gmail.com> Fixes: cbeb479ff4cd ("hwmon: (nzxt-kraken3) Decouple device names from kinds") Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- I updated the SHA in Dan's report; the branch has since been rebased. drivers/hwmon/nzxt-kraken3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)