diff mbox series

[v3,7/8] hwmon: (k10temp) Remove unused HAVE_TDIE() macro

Message ID 20240523-fix-smn-bad-read-v3-7-aa44c622de39@amd.com (mailing list archive)
State Handled Elsewhere
Headers show
Series Enhance AMD SMN Error Checking | expand

Commit Message

Yazen Ghannam May 23, 2024, 6:26 p.m. UTC
...to address the following warning:

drivers/hwmon/k10temp.c:104:9:
warning: macro is not used [-Wunused-macros]

No functional change is intended.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
 drivers/hwmon/k10temp.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Guenter Roeck May 23, 2024, 7:31 p.m. UTC | #1
On 5/23/24 11:26, Yazen Ghannam wrote:
> ...to address the following warning:
> 
> drivers/hwmon/k10temp.c:104:9:
> warning: macro is not used [-Wunused-macros]
> 
> No functional change is intended.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/k10temp.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 6deb272c7cef..a2d203304533 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -101,7 +101,6 @@ struct k10temp_data {
>   #define TCCD_BIT(x)	((x) + 2)
>   
>   #define HAVE_TEMP(d, channel)	((d)->show_temp & BIT(channel))
> -#define HAVE_TDIE(d)		HAVE_TEMP(d, TDIE_BIT)
>   
>   struct tctl_offset {
>   	u8 model;
>
Markus Elfring May 25, 2024, 3 p.m. UTC | #2
> ...to address the following warning:
>
> drivers/hwmon/k10temp.c:104:9:
> warning: macro is not used [-Wunused-macros]

Can such a source code cleanup matter also for the tag “Fixes”?

Regards,
Markus
diff mbox series

Patch

diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 6deb272c7cef..a2d203304533 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -101,7 +101,6 @@  struct k10temp_data {
 #define TCCD_BIT(x)	((x) + 2)
 
 #define HAVE_TEMP(d, channel)	((d)->show_temp & BIT(channel))
-#define HAVE_TDIE(d)		HAVE_TEMP(d, TDIE_BIT)
 
 struct tctl_offset {
 	u8 model;