From patchwork Thu Jul 4 11:16:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gupta, Akshay" X-Patchwork-Id: 13723606 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2043.outbound.protection.outlook.com [40.107.212.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B921AC239; Thu, 4 Jul 2024 11:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720091842; cv=fail; b=Ohw/KFocT+I+ZcuvDeRV6NwI9s3sfbnilKgwLJ7zZQFKW8h9yZHeAT+H/PlXbRY8pjQcLSVddWaGIigCw7yb6xJtR4IUmXYXtudjvCRWZgDW97v6mZNQYUccYlVDSmG54XvU2KM2eBDLp/Kh4EGjpnAEx6unTYr6mvU+91+xbnY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720091842; c=relaxed/simple; bh=bDm2eHGu41dBL3E9XGAQtjIImxSSfeRSjlDtn0B0NQk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DjYic5E0fhq/ZdXnLcdgddsMjf3YdUkKWg2+GQGbBnRETkIcPSSoIn+KEmuZ7BtHTxVXpJNbE0rxM+VxjgmBAj+bFd6hTuRxmkVv10JR5SzKxt5xXGaYYj7L6ZbzymntNEHfVa0mAd2d+UnGVX+t5wEoTuAJFBc1QrKDqWf08Lk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=VEduwK0w; arc=fail smtp.client-ip=40.107.212.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="VEduwK0w" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAi1GciATgVwu0hVfhti3bViOmRlFZEm7ADAIJh2lQSf8Fn8PaS4ujWlPAsMVqsRLTtX7qdI/uT5/0LA1cEhBkjqNfz7nge+VMSjt4pfWa3WgwS9ThkVzZ+XyWS3VWATvBZE3qDtna0LU7W7jet17YlQifxTdk/ZcBxoNjKIfsXtcUUM9+sSZF8o85aHgdXZ7xAbmnoHWmTIjNm0wZo+jiGk/hTsU27JOsP8gTkl2n4/pzaRWUidbQtqbmqoDW2puWRRxUsLG0OucxU9snVOrnPFWBLCKpahJSN2U91Uz6zEtjqBAhS3Ld8wzH2B41frllgqZReVxg4mCK6F4NFP7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zi7ASdHE7n3FnM018yPhb0oYrehFJ1BbtVpBL90/Qo0=; b=iV9prymR4B/jlprZa4FiPz2KgZO9YarnKulsAfiVuGr+HSvigOb8PcSmGfSpIssYDc7l5cwqFTCc9VJDqcPe0U5qEsZyc3v4kF0tKYDqZOe5BhlgsLPpSW5p58TIpV21BCY43NnPsBnyCDozbfaJwjzZcX4KtJWjh5Ak3PszEMWAddyz56mCnFAy7J7NTTNhquKg/8YEJdtvmJV8/UOv+/6SfsqzR/seSiTk9eDEjJbtI3R2LwuHWjMjN9CbAMVn0M8AKu1hOVXbIXNfK/qXo++o+Zd2Jx9BKkYzqt1jjeEcgzPCOA31NdVM9xxrSxibkWdsmA5u/4lbLMIomv4rtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zi7ASdHE7n3FnM018yPhb0oYrehFJ1BbtVpBL90/Qo0=; b=VEduwK0w+LS/ESIhCFXnXKEUUJeC+Zj/gDV5kzIb1g1se2B0lBtT4ris07pkY5f7wzOx5b13NcehEtab9r8l0b6lC79k2HfPTTlBKJwww6DhNYwvsWYW7/Rh/7cEVfik0prHbC6m4dct9jypOeKIZM8sH3lWrJ0Rs+m8fugsy8U= Received: from CH0PR04CA0023.namprd04.prod.outlook.com (2603:10b6:610:76::28) by PH0PR12MB7011.namprd12.prod.outlook.com (2603:10b6:510:21c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.32; Thu, 4 Jul 2024 11:17:17 +0000 Received: from DS2PEPF0000343B.namprd02.prod.outlook.com (2603:10b6:610:76:cafe::af) by CH0PR04CA0023.outlook.office365.com (2603:10b6:610:76::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.29 via Frontend Transport; Thu, 4 Jul 2024 11:17:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS2PEPF0000343B.mail.protection.outlook.com (10.167.18.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.18 via Frontend Transport; Thu, 4 Jul 2024 11:17:16 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 4 Jul 2024 06:17:13 -0500 From: Akshay Gupta To: , , , , CC: , Akshay Gupta Subject: [PATCH 4/6] misc: sbrmi: Clear sbrmi status register bit SwAlertSts Date: Thu, 4 Jul 2024 11:16:22 +0000 Message-ID: <20240704111624.1583460-5-akshay.gupta@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240704111624.1583460-1-akshay.gupta@amd.com> References: <20240704111624.1583460-1-akshay.gupta@amd.com> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343B:EE_|PH0PR12MB7011:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ee42336-6c7d-4c06-04ee-08dc9c1adcbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: WQs0DNvOsGkrztYNphaVuFy7Cha7JrXD4lY338Hj4Djf45vbYMIaXOOKDaBmMcte7SO1kJYRvQh4NivOchn4S0JtxzAeniyypVmTqCswz5ntF4TNrNjlhjfs7EBFyhyLJBsBWdzZdVAPySba9Ub9pRmP2bbfNrtPuFD8R3k3Xm1pJUvNnxPHajMndz5wx76oIPV8F6A4IwHUG4CMJdNCNH0jC1hSyRt5pvBgi5xYXmKQ6gzmoAygEikI9uXfBxR9ngIVA5tj1DzjqMejcfyDGQRoiHIMFFbr99xDsojLdltSJ6LVtp3Jf/uoHqo9uQM5CJqzG+N6hx1B65M9eHc1gXs6gkwUyJXKFTXkg6I80SMnDQOBm6G8arPUkTGx81OYzCfdR+Nuu5LTBuOzBWjMtvFRKBU4GDXnpsJOSdGwbH8hP+DOIbuhySl4omra9JD/hRiXUqOwJHmR1N18YFQRqFFiJVpaiGKI69RVUunfMjx0aiLcdKNhzKdG4wZcykRRT2NnQLC1Xt57D7MfeOzc/6kmFUO7Aez2zU6zhPzHSZoM1Ft0/2R45ASH5+/VPjNrb74j2f0mE4JRYPeFNA7WqTdLSX8lwPaaNhlJ7wq55qc1l+Y5cqbNmV+9bttbvT8hz8cDAXFc1lOEPIU4ZyoSSsVgLPdEk5pqGruBqocyAlCDV+iOHoeE87z4oACDvg9mVwsrsI01e32nbmZRq/JMf34UQf76Gzv0wnkki/DAdT1qA1wZqATlSNFkqq6BpW3oMvAzSQs+8PR1tX4i6WDHRJKAJ5Q4ChZANJT+RsYSsoh+zx0W1QqkWHuGeS1ZbX7aOwyFYGO6BpYS7HwoZ3KEGcjvhB7+Gv92U6TTXw3kRrYusHb4PZyxaUeJJym8JEJ9N7TivXKnHYyMq3aFvaTHWjjWh42wE25GPJ6vtogB2XriD+AZOnUx5r02AD087CZCIectVF8BNmyXbKV8EySTLdCOCaVoP4KvThqK/1NPd3aho4HjfeMKj5vOiC2Ko4y72qwKKKcqf0kv0G8v5yBOBu6VfJLXIQB2IQsjHsYIZutiZBlID/AJn6FocH8yFiMQUOhmfOpk4dbaz8eksM3EOoSV0NQH/4pxeXFNO6VZXwGwR2Ss/thQGDr5gIe8ndrCTaSOYQ2RhLUZx5GjWuPKKVXNy2rHYoYpFWsmOlf0ipdd9vdwJuxZk5jI+r8KvPtNgOjHzQmc0L7v9pgYEaHm8L+/GsgvSLHy+OnYoseWxp9UukVxNvxikH9qNbUuBwJM3/bIJmsrzl3W9j/Z1P5T/cYY0MVs5mQ6kRnxXQwbn9dd/H3wzJO+acCszmxPbt4OhPnkdPAgE5vUU6uJZriFJSKxyF34IXBMR1bb3VcqX5Nk1jnSp7g1GajFwVwxWi6ZW0IcVirdKosH+f05Oq3NGu2+0mXFetPasXoi+t2oo+3+UN5chOrL+jmBR5+158fZ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 11:17:16.5222 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ee42336-6c7d-4c06-04ee-08dc9c1adcbc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7011 - SBRMI register status b1' SwAlertSts sets in below conditions - Completion of Mailbox command - syncflood event If the bit is set for syncfllod event, it may be interpretted as mailbox command compleition. This patch clears the bit before start of mailbox protocol. Signed-off-by: Akshay Gupta Reviewed-by: Naveen Krishna Chatradhi --- drivers/misc/amd-sb/sbrmi-core.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/misc/amd-sb/sbrmi-core.c b/drivers/misc/amd-sb/sbrmi-core.c index b2437a4044ac..e528b7314447 100644 --- a/drivers/misc/amd-sb/sbrmi-core.c +++ b/drivers/misc/amd-sb/sbrmi-core.c @@ -42,6 +42,22 @@ enum sbrmi_reg { SBRMI_SW_INTERRUPT, }; +static int sbrmi_clear_status_alert(struct sbrmi_data *data) +{ + int sw_status, ret; + + ret = regmap_read(data->regmap, SBRMI_STATUS, + &sw_status); + if (ret < 0) + return ret; + + if (!(sw_status & SW_ALERT_MASK)) + return 0; + + return regmap_write(data->regmap, SBRMI_STATUS, + SW_ALERT_MASK); +} + int rmi_mailbox_xfer(struct sbrmi_data *data, struct sbrmi_mailbox_msg *msg) { @@ -52,6 +68,10 @@ int rmi_mailbox_xfer(struct sbrmi_data *data, mutex_lock(&data->lock); + ret = sbrmi_clear_status_alert(data); + if (ret < 0) + goto exit_unlock; + /* Indicate firmware a command is to be serviced */ ret = regmap_write(data->regmap, SBRMI_INBNDMSG7, START_CMD); if (ret < 0)