| Message ID | 20240713213402.1085599-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] hwmon: (max6697) Fix swapped temp{1,8} critical alarms | expand |
On Sat, Jul 13, 2024 at 02:34:01PM -0700, Guenter Roeck wrote: > The critical alarm bit for the local temperature sensor (temp1) is in > bit 7 of register 0x45 (not bit 6), and the critical alarm bit for remote > temperature sensor 7 (temp8) is in bit 6 (not bit 7). > > This only affects MAX6581 since all other chips supported by this driver > do not support those critical alarms. > > Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles") > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Double checked with the datasheet[1], Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/max6581.pdf
On 7/14/24 00:06, Tzung-Bi Shih wrote: > On Sat, Jul 13, 2024 at 02:34:01PM -0700, Guenter Roeck wrote: >> The critical alarm bit for the local temperature sensor (temp1) is in >> bit 7 of register 0x45 (not bit 6), and the critical alarm bit for remote >> temperature sensor 7 (temp8) is in bit 6 (not bit 7). >> >> This only affects MAX6581 since all other chips supported by this driver >> do not support those critical alarms. >> >> Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles") >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > Double checked with the datasheet[1], I checked this several times because I couldn't believe that I got it wrong when I wrote the driver. Thanks a lot for the reviews and for cross-checking ! Guenter > Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> > > [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/max6581.pdf >
diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c index b28b7b9448aa..1111b2ea55ee 100644 --- a/drivers/hwmon/max6697.c +++ b/drivers/hwmon/max6697.c @@ -428,14 +428,14 @@ static SENSOR_DEVICE_ATTR_RO(temp6_max_alarm, alarm, 20); static SENSOR_DEVICE_ATTR_RO(temp7_max_alarm, alarm, 21); static SENSOR_DEVICE_ATTR_RO(temp8_max_alarm, alarm, 23); -static SENSOR_DEVICE_ATTR_RO(temp1_crit_alarm, alarm, 14); +static SENSOR_DEVICE_ATTR_RO(temp1_crit_alarm, alarm, 15); static SENSOR_DEVICE_ATTR_RO(temp2_crit_alarm, alarm, 8); static SENSOR_DEVICE_ATTR_RO(temp3_crit_alarm, alarm, 9); static SENSOR_DEVICE_ATTR_RO(temp4_crit_alarm, alarm, 10); static SENSOR_DEVICE_ATTR_RO(temp5_crit_alarm, alarm, 11); static SENSOR_DEVICE_ATTR_RO(temp6_crit_alarm, alarm, 12); static SENSOR_DEVICE_ATTR_RO(temp7_crit_alarm, alarm, 13); -static SENSOR_DEVICE_ATTR_RO(temp8_crit_alarm, alarm, 15); +static SENSOR_DEVICE_ATTR_RO(temp8_crit_alarm, alarm, 14); static SENSOR_DEVICE_ATTR_RO(temp2_fault, alarm, 1); static SENSOR_DEVICE_ATTR_RO(temp3_fault, alarm, 2);
The critical alarm bit for the local temperature sensor (temp1) is in bit 7 of register 0x45 (not bit 6), and the critical alarm bit for remote temperature sensor 7 (temp8) is in bit 6 (not bit 7). This only affects MAX6581 since all other chips supported by this driver do not support those critical alarms. Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles") Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/hwmon/max6697.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)