diff mbox series

hwmon: ltc2991: fix register bits defines

Message ID 20240830111349.30531-1-paweldembicki@gmail.com (mailing list archive)
State Accepted
Headers show
Series hwmon: ltc2991: fix register bits defines | expand

Commit Message

Pawel Dembicki Aug. 30, 2024, 11:13 a.m. UTC
In the LTC2991, V5 and V6 channels use the low nibble of the
"V5, V6, V7, and V8 Control Register" for configuration, but currently,
the high nibble is defined.

This patch changes the defines to use the low nibble.

Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
---
 drivers/hwmon/ltc2991.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Guenter Roeck Sept. 1, 2024, 1:40 p.m. UTC | #1
On Fri, Aug 30, 2024 at 01:13:50PM +0200, Pawel Dembicki wrote:
> In the LTC2991, V5 and V6 channels use the low nibble of the
> "V5, V6, V7, and V8 Control Register" for configuration, but currently,
> the high nibble is defined.
> 
> This patch changes the defines to use the low nibble.
> 
> Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ltc2991.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/ltc2991.c b/drivers/hwmon/ltc2991.c
> index 573cd8f5721b..7ca139e4b6af 100644
> --- a/drivers/hwmon/ltc2991.c
> +++ b/drivers/hwmon/ltc2991.c
> @@ -42,9 +42,9 @@
>  #define LTC2991_V7_V8_FILT_EN		BIT(7)
>  #define LTC2991_V7_V8_TEMP_EN		BIT(5)
>  #define LTC2991_V7_V8_DIFF_EN		BIT(4)
> -#define LTC2991_V5_V6_FILT_EN		BIT(7)
> -#define LTC2991_V5_V6_TEMP_EN		BIT(5)
> -#define LTC2991_V5_V6_DIFF_EN		BIT(4)
> +#define LTC2991_V5_V6_FILT_EN		BIT(3)
> +#define LTC2991_V5_V6_TEMP_EN		BIT(1)
> +#define LTC2991_V5_V6_DIFF_EN		BIT(0)
>  
>  #define LTC2991_REPEAT_ACQ_EN		BIT(4)
>  #define LTC2991_T_INT_FILT_EN		BIT(3)
diff mbox series

Patch

diff --git a/drivers/hwmon/ltc2991.c b/drivers/hwmon/ltc2991.c
index 573cd8f5721b..7ca139e4b6af 100644
--- a/drivers/hwmon/ltc2991.c
+++ b/drivers/hwmon/ltc2991.c
@@ -42,9 +42,9 @@ 
 #define LTC2991_V7_V8_FILT_EN		BIT(7)
 #define LTC2991_V7_V8_TEMP_EN		BIT(5)
 #define LTC2991_V7_V8_DIFF_EN		BIT(4)
-#define LTC2991_V5_V6_FILT_EN		BIT(7)
-#define LTC2991_V5_V6_TEMP_EN		BIT(5)
-#define LTC2991_V5_V6_DIFF_EN		BIT(4)
+#define LTC2991_V5_V6_FILT_EN		BIT(3)
+#define LTC2991_V5_V6_TEMP_EN		BIT(1)
+#define LTC2991_V5_V6_DIFF_EN		BIT(0)
 
 #define LTC2991_REPEAT_ACQ_EN		BIT(4)
 #define LTC2991_T_INT_FILT_EN		BIT(3)