| Message ID | 20240906061421.9392-3-Delphine_CC_Chiu@wiwynn.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hwmon: (isl28022) new driver for ISL28022 power monitor | expand |
Hi Delphine CC Chiu, I guess binding should be first patch, otherwise you get undocumented warnings for driver patch as it is the first patch. Then you could move MAINTAINERS from this patch to driver patch Also, it is missing your SoB. Cheers, Biju > -----Original Message----- > From: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > Sent: Friday, September 6, 2024 7:14 AM > Subject: [PATCH v6 2/3] dt-bindings: hwmon: add renesas,isl28022 > > From: Carsten Spieß <mail@carsten-spiess.de> > > Add dt-bindings for Renesas ISL28022 power monitor. > > Signed-off-by: Carsten Spieß <mail@carsten-spiess.de> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/hwmon/renesas,isl28022.yaml | 64 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml > b/Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml > new file mode 100644 > index 000000000000..dd82a80e4115 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/renesas,isl28022.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas ISL28022 power monitor > + > +maintainers: > + - Carsten Spieß <mail@carsten-spiess.de> > + > +description: | > + The ISL28022 is a power monitor with I2C interface. The device > +monitors > + voltage, current via shunt resistor and calculated power. > + > + Datasheets: > + https://www.renesas.com/us/en/www/doc/datasheet/isl28022.pdf > + > +properties: > + compatible: > + const: renesas,isl28022 > + > + reg: > + maxItems: 1 > + > + shunt-resistor-micro-ohms: > + description: > + Shunt resistor value in micro-Ohm > + minimum: 800 > + default: 10000 > + > + renesas,shunt-range-microvolt: > + description: > + Maximal shunt voltage range of +/- 40 mV, 80 mV, 160 mV or 320 mV > + default: 320000 > + enum: [40000, 80000, 160000, 320000] > + > + renesas,average-samples: > + description: > + Number of samples to be used to report voltage, current and power values. > + default: 1 > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 4, 8, 16, 32, 64, 128] > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + power-monitor@40 { > + compatible = "renesas,isl28022"; > + reg = <0x40>; > + shunt-resistor-micro-ohms = <8000>; > + renesas,shunt-range-microvolt = <40000>; > + renesas,average-samples = <128>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d39199ed51da..d5809cf181ff 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11936,6 +11936,7 @@ ISL28022 HARDWARE MONITORING DRIVER > M: Carsten Spieß <mail@carsten-spiess.de> > L: linux-hwmon@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml > F: Documentation/hwmon/isl28022.rst > F: drivers/hwmon/isl28022.c > > -- > 2.25.1 >
On 06/09/2024 08:14, Delphine CC Chiu wrote: > From: Carsten Spieß <mail@carsten-spiess.de> > > Add dt-bindings for Renesas ISL28022 power monitor. > > Signed-off-by: Carsten Spieß <mail@carsten-spiess.de> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Your SoB is missing. This must be fixed. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml b/Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml new file mode 100644 index 000000000000..dd82a80e4115 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/renesas,isl28022.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas ISL28022 power monitor + +maintainers: + - Carsten Spieß <mail@carsten-spiess.de> + +description: | + The ISL28022 is a power monitor with I2C interface. The device monitors + voltage, current via shunt resistor and calculated power. + + Datasheets: + https://www.renesas.com/us/en/www/doc/datasheet/isl28022.pdf + +properties: + compatible: + const: renesas,isl28022 + + reg: + maxItems: 1 + + shunt-resistor-micro-ohms: + description: + Shunt resistor value in micro-Ohm + minimum: 800 + default: 10000 + + renesas,shunt-range-microvolt: + description: + Maximal shunt voltage range of +/- 40 mV, 80 mV, 160 mV or 320 mV + default: 320000 + enum: [40000, 80000, 160000, 320000] + + renesas,average-samples: + description: + Number of samples to be used to report voltage, current and power values. + default: 1 + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [1, 2, 4, 8, 16, 32, 64, 128] + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + power-monitor@40 { + compatible = "renesas,isl28022"; + reg = <0x40>; + shunt-resistor-micro-ohms = <8000>; + renesas,shunt-range-microvolt = <40000>; + renesas,average-samples = <128>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index d39199ed51da..d5809cf181ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11936,6 +11936,7 @@ ISL28022 HARDWARE MONITORING DRIVER M: Carsten Spieß <mail@carsten-spiess.de> L: linux-hwmon@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/hwmon/renesas,isl28022.yaml F: Documentation/hwmon/isl28022.rst F: drivers/hwmon/isl28022.c