| Message ID | 20241012070627.20788-2-wenliang202407@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [linux,dev-6.11,1/2] v3: hwmon: modified ina2xx to match SY24655 | expand |
On 12/10/2024 09:06, Wenliang wrote: > Modified the binding of ina2xx to make it compatible with SY24655. > Your subject is odd. We do not develop v6.11, that's something already old. The cc-list suggest you just want it for next release, so rebase on mainline or next and avoid any unusual patch prefixes. OTOH, v3 is not part of subject. Use b4 or git format-patch -v3. > Signed-off-by: Wenliang <wenliang202407@163.com> > --- > > SY24655 is a fixed gain power monitor from Silergy, with a power supply > of 2.7-5.5V and communication mode of IIC capable of detecting bus voltage > and voltage on shunt resistors. Its first 5 registers are identical to > ina226, and also have alert and limit functions. So, the sy24655 is > compatible with the ina2xx devices. This is hardware description, why it is not part of commit message? Best regards, Krzysztof
On 10/12/24 03:06, Krzysztof Kozlowski wrote: > On 12/10/2024 09:06, Wenliang wrote: >> Modified the binding of ina2xx to make it compatible with SY24655. >> > > Your subject is odd. We do not develop v6.11, that's something already > old. The cc-list suggest you just want it for next release, so rebase on > mainline or next and avoid any unusual patch prefixes. > The submitter also still refuses to use imperative mood. I don't know how often this has to be repeated. I take this as "does not address feedback" and will not even look at the patches anymore until the reported problems have been fixed. Oh, and I just noticed that this version has been sent as response to the previous version, which is also discouraged. On top of that, there is no change log. Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml index 6ae961732e6b..05a9cb36cd82 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml @@ -20,6 +20,7 @@ description: | properties: compatible: enum: + - silergy,sy24655 - ti,ina209 - ti,ina219 - ti,ina220
Modified the binding of ina2xx to make it compatible with SY24655. Signed-off-by: Wenliang <wenliang202407@163.com> --- SY24655 is a fixed gain power monitor from Silergy, with a power supply of 2.7-5.5V and communication mode of IIC capable of detecting bus voltage and voltage on shunt resistors. Its first 5 registers are identical to ina226, and also have alert and limit functions. So, the sy24655 is compatible with the ina2xx devices. Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + 1 file changed, 1 insertion(+)