diff mbox series

hwmon: tmp108: fix I3C dependency

Message ID 20241113175615.2442851-1-arnd@kernel.org (mailing list archive)
State Accepted
Headers show
Series hwmon: tmp108: fix I3C dependency | expand

Commit Message

Arnd Bergmann Nov. 13, 2024, 5:55 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

It's possible to build a kernel with tmp108 built-in but i3c support
in a loadable module, but that results in a link failure:

x86_64-linux-ld: drivers/hwmon/tmp108.o: in function `p3t1085_i3c_probe':
tmp108.c:(.text+0x5f9): undefined reference to `i3cdev_to_dev'

Add a Kconfig dependency to ensure only the working configurations
are allowed.

Fixes: c40655e33106 ("hwmon: (tmp108) Add support for I3C device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Nov. 13, 2024, 8:04 p.m. UTC | #1 
On Wed, Nov 13, 2024 at 06:55:33PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> It's possible to build a kernel with tmp108 built-in but i3c support
> in a loadable module, but that results in a link failure:
> 
> x86_64-linux-ld: drivers/hwmon/tmp108.o: in function `p3t1085_i3c_probe':
> tmp108.c:(.text+0x5f9): undefined reference to `i3cdev_to_dev'
> 
> Add a Kconfig dependency to ensure only the working configurations
> are allowed.
> 
> Fixes: c40655e33106 ("hwmon: (tmp108) Add support for I3C device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I knew I missed something ;-).

Thanks a lot for the patch. Applied.

Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index f15e72b319af..dd376602f3f1 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -2297,6 +2297,7 @@  config SENSORS_TMP103
 config SENSORS_TMP108
 	tristate "Texas Instruments TMP108"
 	depends on I2C
+	depends on I3C || !I3C
 	select REGMAP_I2C
 	select REGMAP_I3C if I3C
 	help