| Message ID | 20241206062839.313292-1-dheeraj.linuxdev@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [hwmon-next] hwmon: (pmbus/tps25990) Remove unnecessary call | expand |
Hi, On 12/5/24 22:28, Dheeraj Reddy Jonnalagadda wrote: > This commit addresses a structurally dead code issue detected by > Coverity (CID 1602227). An integer is returned early in one of the > switch cases causing the later statements to never be called. The > return statement is removed following convention in the other switch > cases. > > Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com> This has already been fixed. Thanks, Guenter > --- > drivers/hwmon/pmbus/tps25990.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c > index cc0f5c7cecb0..0d2655e69549 100644 > --- a/drivers/hwmon/pmbus/tps25990.c > +++ b/drivers/hwmon/pmbus/tps25990.c > @@ -130,7 +130,6 @@ static int tps25990_read_word_data(struct i2c_client *client, > break; > > case PMBUS_VIRT_READ_IIN_MAX: > - return TPS25990_READ_IIN_PEAK; > ret = pmbus_read_word_data(client, page, phase, > TPS25990_READ_IIN_PEAK); > break;
diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c index cc0f5c7cecb0..0d2655e69549 100644 --- a/drivers/hwmon/pmbus/tps25990.c +++ b/drivers/hwmon/pmbus/tps25990.c @@ -130,7 +130,6 @@ static int tps25990_read_word_data(struct i2c_client *client, break; case PMBUS_VIRT_READ_IIN_MAX: - return TPS25990_READ_IIN_PEAK; ret = pmbus_read_word_data(client, page, phase, TPS25990_READ_IIN_PEAK); break;
This commit addresses a structurally dead code issue detected by Coverity (CID 1602227). An integer is returned early in one of the switch cases causing the later statements to never be called. The return statement is removed following convention in the other switch cases. Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com> --- drivers/hwmon/pmbus/tps25990.c | 1 - 1 file changed, 1 deletion(-)