diff mbox series

hwmon: (pwm-fan): Make use of device properties everywhere

Message ID 20250102170429.791912-1-peter@korsgaard.com (mailing list archive)
State Accepted
Headers show
Series hwmon: (pwm-fan): Make use of device properties everywhere | expand

Commit Message

Peter Korsgaard Jan. 2, 2025, 5:04 p.m. UTC
Commit 255ab27a0743 ("hwmon: (pwm-fan) Introduce start from stopped state
handling") added two of_property_read_u32() calls after the driver was
reworked to use device_property_* in commit dfd977d85b15 ("hwmon: (pwm-fan)
Make use of device properties"), so convert those as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 drivers/hwmon/pwm-fan.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Marek Vasut Jan. 2, 2025, 5:46 p.m. UTC | #1
On 1/2/25 6:04 PM, Peter Korsgaard wrote:
> Commit 255ab27a0743 ("hwmon: (pwm-fan) Introduce start from stopped state
> handling") added two of_property_read_u32() calls after the driver was
> reworked to use device_property_* in commit dfd977d85b15 ("hwmon: (pwm-fan)
> Make use of device properties"), so convert those as well.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Marek Vasut <marex@denx.de>

Thanks
Guenter Roeck Jan. 6, 2025, 5 p.m. UTC | #2
On Thu, Jan 02, 2025 at 06:04:29PM +0100, Peter Korsgaard wrote:
> Commit 255ab27a0743 ("hwmon: (pwm-fan) Introduce start from stopped state
> handling") added two of_property_read_u32() calls after the driver was
> reworked to use device_property_* in commit dfd977d85b15 ("hwmon: (pwm-fan)
> Make use of device properties"), so convert those as well.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Reviewed-by: Marek Vasut <marex@denx.de>

Applied.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 53a1a968d00d..231b3b348263 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -638,16 +638,16 @@  static int pwm_fan_probe(struct platform_device *pdev)
 		channels[1] = &ctx->fan_channel;
 	}
 
-	ret = of_property_read_u32(dev->of_node, "fan-stop-to-start-percent",
-				   &pwm_min_from_stopped);
+	ret = device_property_read_u32(dev, "fan-stop-to-start-percent",
+				       &pwm_min_from_stopped);
 	if (!ret && pwm_min_from_stopped) {
 		ctx->pwm_duty_cycle_from_stopped =
 			DIV_ROUND_UP_ULL(pwm_min_from_stopped *
 					 (ctx->pwm_state.period - 1),
 					 100);
 	}
-	ret = of_property_read_u32(dev->of_node, "fan-stop-to-start-us",
-				   &ctx->pwm_usec_from_stopped);
+	ret = device_property_read_u32(dev, "fan-stop-to-start-us",
+				       &ctx->pwm_usec_from_stopped);
 	if (ret)
 		ctx->pwm_usec_from_stopped = 250000;