[v3] hwmon: (pmbus/isl68137) Add support for RAA229621

Commit Message

Chiang Brian March 3, 2025, 8:35 a.m. UTC

From: Chiang Brian <[e-mail]>

From: Chiang Brian<[e-mail]>

The RAA229621 is a digital dual output multiphase
(X+Y ≤ 8) PWM controller designed to be compliant
with AMD SVI3 specifications, targeting
VDDCR_CPU and VDDCR_SOC rails.
Add support for it to the isl68137 driver.

Signed-off-by: Chiang Brian <[e-mail]>
---
 drivers/hwmon/pmbus/isl68137.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Guenter Roeck March 3, 2025, 2:03 p.m. UTC | #1

On Mon, Mar 03, 2025 at 04:35:37PM +0800, Chiang Brian wrote:
> From: Chiang Brian <[e-mail]>
> 
> From: Chiang Brian<[e-mail]>
> 

?

> The RAA229621 is a digital dual output multiphase
> (X+Y ≤ 8) PWM controller designed to be compliant
> with AMD SVI3 specifications, targeting
> VDDCR_CPU and VDDCR_SOC rails.
> Add support for it to the isl68137 driver.
> 
> Signed-off-by: Chiang Brian <[e-mail]>

Again no change log. Please consider this the last warning: I will not
apply any of your patches unless you provide change logs.

checkpatch says

WARNING: DT compatible string "renesas,raa229621" appears un-documented -- check ./Documentation/devicetree/bindings/
#139: FILE: drivers/hwmon/pmbus/isl68137.c:517:
+	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },

The new compatible needs to be documented.

Guenter

Patch

diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 2af921039309..c52c55d2e7f4 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -63,6 +63,7 @@  enum chips {
 	raa228228,
 	raa229001,
 	raa229004,
+	raa229621,
 };
 
 enum variants {
@@ -465,6 +466,7 @@  static const struct i2c_device_id raa_dmpvr_id[] = {
 	{"raa228228", raa_dmpvr2_2rail_nontc},
 	{"raa229001", raa_dmpvr2_2rail},
 	{"raa229004", raa_dmpvr2_2rail},
+	{"raa229621", raa_dmpvr2_2rail},
 	{}
 };
 
@@ -512,6 +514,7 @@  static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
+	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },
 	{ },
 };