| Message ID | 20250327131841.15013-5-wenliang202407@163.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hwmon:(ina238)Add support for SQ52206 | expand |
On Thu, 27 Mar 2025 09:18:41 -0400, Wenliang Yan wrote: > Add the sq52206 compatible to the ina2xx.yaml > > Signed-off-by: Wenliang Yan <wenliang202407@163.com> > --- > > Add the meaning of 'shunt-gain' in SQ52206. > > v5->v6:add content to meet the update requirements of the ina2xx.yaml > > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml: allOf:1:if:properties:compatible:contains:enum: ['silergy,sy24655', 'silergy,sy24655', 'ti,ina209', 'ti,ina219', 'ti,ina220', 'ti,ina226', 'ti,ina230', 'ti,ina231', 'ti,ina237', 'ti,ina238', 'ti,ina260'] has non-unique elements hint: "enum" must be an array of either integers or strings from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250327131841.15013-5-wenliang202407@163.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 3/27/25 06:18, Wenliang Yan wrote: > Add the sq52206 compatible to the ina2xx.yaml > > Signed-off-by: Wenliang Yan <wenliang202407@163.com> > --- > > Add the meaning of 'shunt-gain' in SQ52206. > > v5->v6:add content to meet the update requirements of the ina2xx.yaml > > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > index bc03781342c0..8cd672e6bf62 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > @@ -19,6 +19,7 @@ description: | > properties: > compatible: > enum: > + - silergy,sq52206 > - silergy,sy24655 > - ti,ina209 > - ti,ina219 > @@ -58,6 +59,9 @@ properties: > shunt voltage, and a value of 4 maps to ADCRANGE=0 such that a wider > voltage range is used. > > + For SQ52206,the shunt-gain value 1 mapps to ADCRANGE=10/11, the value 2 > + mapps to ADCRANGE=01, and the value 4 mapps to ADCRANGE=00. > + > The default value is device dependent, and is defined by the reset value > of PGA/ADCRANGE in the respective configuration registers. > $ref: /schemas/types.yaml#/definitions/uint32 > @@ -97,6 +101,7 @@ allOf: > compatible: > contains: > enum: > + - silergy,sy24655 silergy,sq52206 ? > - silergy,sy24655 > - ti,ina209 > - ti,ina219
At 2025-03-28 06:53:02, "Guenter Roeck" <linux@roeck-us.net> wrote: >On 3/27/25 06:18, Wenliang Yan wrote: >> Add the sq52206 compatible to the ina2xx.yaml >> >> Signed-off-by: Wenliang Yan <wenliang202407@163.com> >> --- >> >> Add the meaning of 'shunt-gain' in SQ52206. >> >> v5->v6:add content to meet the update requirements of the ina2xx.yaml >> >> Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml >> index bc03781342c0..8cd672e6bf62 100644 >> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml >> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml >> @@ -19,6 +19,7 @@ description: | >> properties: >> compatible: >> enum: >> + - silergy,sq52206 >> - silergy,sy24655 >> - ti,ina209 >> - ti,ina219 >> @@ -58,6 +59,9 @@ properties: >> shunt voltage, and a value of 4 maps to ADCRANGE=0 such that a wider >> voltage range is used. >> >> + For SQ52206,the shunt-gain value 1 mapps to ADCRANGE=10/11, the value 2 >> + mapps to ADCRANGE=01, and the value 4 mapps to ADCRANGE=00. >> + >> The default value is device dependent, and is defined by the reset value >> of PGA/ADCRANGE in the respective configuration registers. >> $ref: /schemas/types.yaml#/definitions/uint32 >> @@ -97,6 +101,7 @@ allOf: >> compatible: >> contains: >> enum: >> + - silergy,sy24655 > >silergy,sq52206 ? > Yes, it is my oversight, which may be the reason why 'make dt_binding_check' fails >> - silergy,sy24655 >> - ti,ina209 >> - ti,ina219 Thanks, Wenliang Yan
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml index bc03781342c0..8cd672e6bf62 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml @@ -19,6 +19,7 @@ description: | properties: compatible: enum: + - silergy,sq52206 - silergy,sy24655 - ti,ina209 - ti,ina219 @@ -58,6 +59,9 @@ properties: shunt voltage, and a value of 4 maps to ADCRANGE=0 such that a wider voltage range is used. + For SQ52206,the shunt-gain value 1 mapps to ADCRANGE=10/11, the value 2 + mapps to ADCRANGE=01, and the value 4 mapps to ADCRANGE=00. + The default value is device dependent, and is defined by the reset value of PGA/ADCRANGE in the respective configuration registers. $ref: /schemas/types.yaml#/definitions/uint32 @@ -97,6 +101,7 @@ allOf: compatible: contains: enum: + - silergy,sy24655 - silergy,sy24655 - ti,ina209 - ti,ina219
Add the sq52206 compatible to the ina2xx.yaml Signed-off-by: Wenliang Yan <wenliang202407@163.com> --- Add the meaning of 'shunt-gain' in SQ52206. v5->v6:add content to meet the update requirements of the ina2xx.yaml Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 5 +++++ 1 file changed, 5 insertions(+)