diff mbox series

[v3] hwmon: (nct6683) Add another customer ID for MSI

Message ID 43w0nnxd04iDaHsiW0YhJOpdkr4W2DNlLQ1zRJOG0B_dd5se040WWEupLETO53QEyvVzQw88MgzWa5H-_X7TJGz3cZZPQBjtjWdLFnEBD4M=@proton.me (mailing list archive)
State Accepted
Headers show
Series [v3] hwmon: (nct6683) Add another customer ID for MSI | expand

Commit Message

John Jan. 7, 2025, 1:17 a.m. UTC 
On Monday, January 6th, 2025 at 5:57 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> More serious though is what checkpatch has to say:
> 
> WARNING: From:/Signed-off-by: email address mismatch: 'From: John Audia therealgraysky@proton.me' != 'Signed-off-by: John Audia thereadgraysky@proton.me'
> 
> 
> Notice "therealgraysky" vs. "thereadgraysky"
> ^ ^
> 
> This means I can't fix the problems myself (which I would have done
> since I already spent way too much time on this).

Apologizes for the typo.

From e4aea88b0c8423d0b3293e43ab7f3beb4c3936f8 Mon Sep 17 00:00:00 2001
From: John Audia <therealgraysky@proton.me>
Date: Wed, 1 Jan 2025 08:27:59 -0500
Subject: [PATCH v3] hwmon: (nct6683) Add another customer ID for MSI

The new customer ID was found on a MPG X870E CARBON WIFI (MS-7E49) with
a NCT6687D chip.

Signed-off-by: John Audia <therealgraysky@proton.me>
---
 V2 -> V3: commit msg changed/correct email address mismatch typo

 Documentation/hwmon/nct6683.rst | 1 +
 drivers/hwmon/nct6683.c         | 3 +++
 2 files changed, 4 insertions(+)

Comments

Guenter Roeck Jan. 7, 2025, 3:24 a.m. UTC | #1 
On 1/6/25 17:17, John wrote:
> On Monday, January 6th, 2025 at 5:57 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> 
>> More serious though is what checkpatch has to say:
>>
>> WARNING: From:/Signed-off-by: email address mismatch: 'From: John Audia therealgraysky@proton.me' != 'Signed-off-by: John Audia thereadgraysky@proton.me'
>>
>>
>> Notice "therealgraysky" vs. "thereadgraysky"
>> ^ ^
>>
>> This means I can't fix the problems myself (which I would have done
>> since I already spent way too much time on this).
> 
> Apologizes for the typo.
> 

Why didn't you send the e-mail below as patch, as would have been expected ?

Never mind, applied, after resolving conflicts and dropping the non-patch
part of the patch.

Guenter
diff mbox series

Patch

diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
index 2a7a78eb1b46..2302b1ac95b1 100644
--- a/Documentation/hwmon/nct6683.rst
+++ b/Documentation/hwmon/nct6683.rst
@@ -65,4 +65,5 @@  ASRock X570	NCT6683D EC firmware version 1.0 build 06/28/19
 ASRock X670E	NCT6686D EC firmware version 1.0 build 05/19/22
 MSI B550	NCT6687D EC firmware version 1.0 build 05/07/20
 MSI X670-P	NCT6687D EC firmware version 0.0 build 09/27/22
+MSI X870E	NCT6687D EC firmware version 0.0 build 11/13/24
 =============== ===============================================
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index f71615e06a8f..288f497d364a 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -175,6 +175,7 @@  superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_MSI		0x201
 #define NCT6683_CUSTOMER_ID_MSI2	0x200
 #define NCT6683_CUSTOMER_ID_MSI3	0x207
+#define NCT6683_CUSTOMER_ID_MSI4	0x20d
 #define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
 #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
 #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
@@ -1227,6 +1228,8 @@  static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_MSI3:
 		break;
+	case NCT6683_CUSTOMER_ID_MSI4:
+		break;
 	case NCT6683_CUSTOMER_ID_ASROCK:
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK2: