From patchwork Wed Oct 9 20:05:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13829167 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 290861B3F30 for ; Wed, 9 Oct 2024 20:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728504305; cv=none; b=bfCN3YSRQ7sy11M//cEY6pcsiyuOVKd5kauFHRrRcXRWsi4sWUyQ+IgqRKB6bG88iSsSXNAbIoCDQrIk2rCJIYnFY/mqCbGpg8qzN+GwN8QDIdZJ7WlTqM71GZ030vPw2dA+9FOK8YMEJThd9rPMG8kimM5yiSWR4ZbvJPmPlEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728504305; c=relaxed/simple; bh=sCWXV4FxPgIGOT/2VFnKprN0mcc+B0HEHv2UK2jVgFg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=o3nMonOk+TQL1w8Z1tq7xNA9d5+kenJfImJ2gxQmjDKilyDpWZ8S81MI+XzqvfbLvmLESb3oOL+O4i8m6oEi/nduL74cxZgVLT/pm+vSGWFB1SM+hJVn5QRco/KUj7U12bV0aRDgcmuo5qmcF9in1UjXTTH/+zXkkkiJNmkCA1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VMNzuri/; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VMNzuri/" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c5bca6603aso111639a12.1 for ; Wed, 09 Oct 2024 13:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728504302; x=1729109102; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8mZDWEiIlQg7S2xqDiuV0YH/rM3kGck5+SNp5nnXt4U=; b=VMNzuri/3Znfhw7N6BjY4sgiMLnWKC8ssY5YFOXQuNt9EAhHcOGA5k1yRxBDnV+2Sp bSPEQ93yV58SHZFYgO8xsauLRBwdKwQgenL2rOOB0siIwhvAWbb3FDAHYzrDfyCiU4Il PTPBvFClA0Jc+34+3Vv8rlltzQe5C19yMHIeYbbKX73PkbYh5OmIJZHtkRtwxOVbk3gV V2NuZVsDkVGtfE2CI0RhD4vqECyXTNxcqMrC9FVulyDqHIAoMav0HmSjoxeDFNGaEzF1 iLf6RL440l49AcDtDNr2cyIeNMyFQJsPw2E0XBz3NLoaBlcsa3yHTzWPFtKQ8uHY0f06 Y6Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728504302; x=1729109102; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8mZDWEiIlQg7S2xqDiuV0YH/rM3kGck5+SNp5nnXt4U=; b=W0qjppSSSdDOLLvQuTmMx5SV3jwf7NAwMPtY2/ZUO4GrmiyR/H/1J9LmzJIuK7XqKN 9h3e99X+oR97dVAICoEINMp52JDiqXIzuP5CCzfU3Y3Zk4mpZf2Hci3b0R7ZZ0udhhBT UzAVwzJB4VgF+HtDIbnIiC0s4r4f3gVGIOtrkTQOcda5EWCbxd6KXR+KJDVaz5yupCHP MEyeT0YhQ9YoNHqd4fz3TT110BiJlQmupyrhfTQcD+JR7w6bkxY5bvBn56SCZCaCwopZ d/Lb6Tt63KDvf2cLcpmo3xfhAZR4JQXaaDo/geILIt/yc1cIpZhEKGPPw0tav4lCupR0 W0gA== X-Forwarded-Encrypted: i=1; AJvYcCVbOE+mFHLSlT9VPxPH/WnBSfv6YV1MJUuKdoUm5fYkdOaN0hPe0PrfxtyfXIwtHPhT6ZCs+7iSpkwctg==@vger.kernel.org X-Gm-Message-State: AOJu0YxgTTUhnP4HU/5ov3k/tXLJn9ISr2xM7G8wZjfuo9lpPHtnC9Tm IKk2hZBmuHTeuffE467k7NjEkKRAGnbhhHyF0NROWrnRS0PaPGlM X-Google-Smtp-Source: AGHT+IHZHnjB/xXUwQPxQQfvhZHy+bc8ZdURKjvdyqInkMtPvuOa/xxpUrvLbZYAMMABBGjRj1lSuw== X-Received: by 2002:a05:6402:1e90:b0:5c2:1910:8e9 with SMTP id 4fb4d7f45d1cf-5c91d6c98c0mr3339018a12.36.1728504302159; Wed, 09 Oct 2024 13:05:02 -0700 (PDT) Received: from ?IPV6:2a02:3100:b338:6300:ac71:eea5:34f6:504b? (dynamic-2a02-3100-b338-6300-ac71-eea5-34f6-504b.310.pool.telefonica.de. [2a02:3100:b338:6300:ac71:eea5:34f6:504b]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5c8e05f3bf0sm5848472a12.88.2024.10.09.13.05.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2024 13:05:01 -0700 (PDT) Message-ID: <5eba910e-709e-4275-a018-17fa287dfb19@gmail.com> Date: Wed, 9 Oct 2024 22:05:00 +0200 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/9] hwmon: surface_fan: Use new helper hwmon_visible_0444 From: Heiner Kallweit To: Tim Harvey , Jean Delvare , Guenter Roeck , Xu Yilun , Tom Rix , Jonas Malaco , =?utf-8?q?Tho?= =?utf-8?q?mas_Wei=C3=9Fschuh?= , Florian Fainelli , Michael Walle , Maximilian Luz , Ivor Wanders Cc: Broadcom internal kernel review list , "linux-hwmon@vger.kernel.org" , linux-rpi-kernel@lists.infradead.org, "linux-arm-kernel@lists.infradead.org" References: <3aecbfc5-e11b-4425-9c6b-88dac2d32945@gmail.com> Content-Language: en-US Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <3aecbfc5-e11b-4425-9c6b-88dac2d32945@gmail.com> Use new helper hwmon_visible_0444 to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/hwmon/surface_fan.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/hwmon/surface_fan.c b/drivers/hwmon/surface_fan.c index de3c5a240..2f173c51d 100644 --- a/drivers/hwmon/surface_fan.c +++ b/drivers/hwmon/surface_fan.c @@ -18,14 +18,6 @@ SSAM_DEFINE_SYNC_REQUEST_CL_R(__ssam_fan_rpm_get, __le16, { .command_id = 0x01, }); -// hwmon -static umode_t surface_fan_hwmon_is_visible(const void *drvdata, - enum hwmon_sensor_types type, u32 attr, - int channel) -{ - return 0444; -} - static int surface_fan_hwmon_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, int channel, long *val) @@ -49,7 +41,7 @@ static const struct hwmon_channel_info *const surface_fan_info[] = { }; static const struct hwmon_ops surface_fan_hwmon_ops = { - .is_visible = surface_fan_hwmon_is_visible, + .is_visible = hwmon_visible_0444, .read = surface_fan_hwmon_read, };