| Message ID | 6f75a80453097e5f05f26782b42ab48f0da8e502.1499232764.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jul 05, 2017 at 11:04:04AM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by <linux/sysfs.h> work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 10055 7032 0 17087 42bf drivers/hwmon/adt7475.o > > File size After adding 'const': > text data bss dec hex filename > 10567 6520 0 17087 42bf drivers/hwmon/adt7475.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/adt7475.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c > index c803e3c..973f17a 100644 > --- a/drivers/hwmon/adt7475.c > +++ b/drivers/hwmon/adt7475.c > @@ -1205,14 +1205,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_auto_point2_pwm, S_IRUGO | S_IWUSR, show_pwm, > NULL > }; > > -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; > -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; > -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; > -static struct attribute_group in0_attr_group = { .attrs = in0_attrs }; > -static struct attribute_group in3_attr_group = { .attrs = in3_attrs }; > -static struct attribute_group in4_attr_group = { .attrs = in4_attrs }; > -static struct attribute_group in5_attr_group = { .attrs = in5_attrs }; > -static struct attribute_group vid_attr_group = { .attrs = vid_attrs }; > +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; > +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; > +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; > +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs }; > +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs }; > +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs }; > +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs }; > +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs }; > > static int adt7475_detect(struct i2c_client *client, > struct i2c_board_info *info) -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c index c803e3c..973f17a 100644 --- a/drivers/hwmon/adt7475.c +++ b/drivers/hwmon/adt7475.c @@ -1205,14 +1205,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_auto_point2_pwm, S_IRUGO | S_IWUSR, show_pwm, NULL }; -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; -static struct attribute_group in0_attr_group = { .attrs = in0_attrs }; -static struct attribute_group in3_attr_group = { .attrs = in3_attrs }; -static struct attribute_group in4_attr_group = { .attrs = in4_attrs }; -static struct attribute_group in5_attr_group = { .attrs = in5_attrs }; -static struct attribute_group vid_attr_group = { .attrs = vid_attrs }; +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs }; +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs }; +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs }; +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs }; +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs }; static int adt7475_detect(struct i2c_client *client, struct i2c_board_info *info)
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 10055 7032 0 17087 42bf drivers/hwmon/adt7475.o File size After adding 'const': text data bss dec hex filename 10567 6520 0 17087 42bf drivers/hwmon/adt7475.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/hwmon/adt7475.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)