From patchwork Wed Jul 5 05:06:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9825835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 510A260317 for ; Wed, 5 Jul 2017 05:06:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F6BD20007 for ; Wed, 5 Jul 2017 05:06:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 442602013D; Wed, 5 Jul 2017 05:06:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D875E20007 for ; Wed, 5 Jul 2017 05:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbdGEFGv (ORCPT ); Wed, 5 Jul 2017 01:06:51 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34744 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbdGEFGu (ORCPT ); Wed, 5 Jul 2017 01:06:50 -0400 Received: by mail-pf0-f195.google.com with SMTP id c24so18709745pfe.1; Tue, 04 Jul 2017 22:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=PCGTCjzZHhdSfuAk6xhhaU+9LOiBiB43FrdUtHMJynA=; b=gpliPRARfIvyu3dbhRO1tje/9kZusBxjQP/oN+lnBd9kg/nFREQcryD5VfYSywn66V XhSRfVS2mTaqReAasDtiK9h3acF1ONhAq9kHMfWBNXODg8t1M9v9wNHnb1+FBHm8y8W4 mRTDuRvodtTx49rxqQPRywLdvxMSXtSoHeCwTR/nCGxX8SUK9ujelD5cxiPUsGv9xOMD HvSahRl1rQ/lMTGt7Bu+gnmKkiviGmnFFU+bWo40HcelTHkz0thYCVlOSl5/6184xMUi N1GwNAU23CL1C2wvMTJDRbRUq8hfQxcEi3k70vyr4ZNHT60UktsmeEfn+f+8tgZ224rB A1EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PCGTCjzZHhdSfuAk6xhhaU+9LOiBiB43FrdUtHMJynA=; b=nJKeBy+8N/aMSb1B0mfhozdIN6OwrXJPtBPZGNsMoc7Q2UDK+KZ799d7Y0DfJu9AqM hq5EsAaTVoYIg80wMdqC3dWAdBrDxgWPXMhlRhuTNWCCLF0/+XaypGqmmjHN0gs2lqHA MbT8rXK0X87Ctrh+hiM4bbnZ3bwz5Nagu6kQdMD7lWpfJoKW4k3ZuiCMh+FqkCXHMhVz AXZckLtjoX62hxRWPUbGqwSIkoDiWlYMhTBekoSnz/p0Danne2cqV7huXK3G6dlxIQuv Sxa3e/CcZDWC3MlQnjlwLScKjBiZkmy7mhR5EY+lzWDLerBmz6bfuSFRaFfZsZ4VRVuw oAuw== X-Gm-Message-State: AIVw113RMGSM2/jp0vVv0YeWHCV316YP/uPvZGldnYzFfL3qKJBXzlxI pRlz0iij2LLSew== X-Received: by 10.98.80.89 with SMTP id e86mr17155783pfb.195.1499231209910; Tue, 04 Jul 2017 22:06:49 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id r17sm27541735pfk.73.2017.07.04.22.06.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 22:06:49 -0700 (PDT) From: Arvind Yadav To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: nct7802: constify attribute_group structures. Date: Wed, 5 Jul 2017 10:36:33 +0530 Message-Id: <7a32d92ba635b2c14442ce2df8d82cd9e32e42a2.1499231145.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 6655 304 0 6959 1b2f drivers/hwmon/hwmon.o File size After adding 'const': text data bss dec hex filename 6703 240 0 6943 1b1f drivers/hwmon/hwmon.o Signed-off-by: Arvind Yadav --- drivers/hwmon/nct7802.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index 12b94b0..2876c18 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c @@ -704,7 +704,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_temp_group = { +static const struct attribute_group nct7802_temp_group = { .attrs = nct7802_temp_attrs, .is_visible = nct7802_temp_is_visible, }; @@ -802,7 +802,7 @@ static umode_t nct7802_in_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_in_group = { +static const struct attribute_group nct7802_in_group = { .attrs = nct7802_in_attrs, .is_visible = nct7802_in_is_visible, }; @@ -880,7 +880,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_fan_group = { +static const struct attribute_group nct7802_fan_group = { .attrs = nct7802_fan_attrs, .is_visible = nct7802_fan_is_visible, }; @@ -898,7 +898,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, NULL }; -static struct attribute_group nct7802_pwm_group = { +static const struct attribute_group nct7802_pwm_group = { .attrs = nct7802_pwm_attrs, }; @@ -1011,7 +1011,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, S_IRUGO | S_IWUSR, NULL }; -static struct attribute_group nct7802_auto_point_group = { +static const struct attribute_group nct7802_auto_point_group = { .attrs = nct7802_auto_point_attrs, };