drivers/hwmon/acpi_power_meter.c: Change log level

Commit Message

Shenran Wang July 22, 2019, 2:50 p.m. UTC

From ce991220c17873821bd1e2bd011686201b3daaff Mon Sep 17 00:00:00 2001
From: Wang Shenran <[e-mail]>
Date: Mon, 22 Jul 2019 14:38:10 +0300
Subject: [PATCH] drivers/hwmon/acpi_power_meter.c: Change log level

At boot time, the acpi_power_meter driver logs the following error level
message: "Ignoring unsafe software power cap". Having read about it from
a few sources, it seems that the error message can be quite misleading.

While the message can imply that Linux is ignoring the fact that the
system is operating in potentially dangerous conditions, the truth is
the driver found an ACPI_PMC object that supports software power
capping. The driver simply decides not to use it, perhaps because it
doesn't support the object.

The best solution is probably changing the log level from error to warning.
All sources I have found, regarding the error, have downplayed its
significance. There is not much of a reason for it to be on error level,
while causing potential confusions or misinterpretations.

Signed-off-by: Wang Shenran <[e-mail]>
---
 drivers/hwmon/acpi_power_meter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

                }

Comments

Guenter Roeck July 22, 2019, 6:27 p.m. UTC | #1

On Mon, Jul 22, 2019 at 05:50:34PM +0300, Shenran Wang wrote:
> From ce991220c17873821bd1e2bd011686201b3daaff Mon Sep 17 00:00:00 2001
> From: Wang Shenran <[e-mail]>
> Date: Mon, 22 Jul 2019 14:38:10 +0300
> Subject: [PATCH] drivers/hwmon/acpi_power_meter.c: Change log level
> 
> At boot time, the acpi_power_meter driver logs the following error level
> message: "Ignoring unsafe software power cap". Having read about it from
> a few sources, it seems that the error message can be quite misleading.
> 
> While the message can imply that Linux is ignoring the fact that the
> system is operating in potentially dangerous conditions, the truth is
> the driver found an ACPI_PMC object that supports software power
> capping. The driver simply decides not to use it, perhaps because it
> doesn't support the object.
> 
> The best solution is probably changing the log level from error to warning.
> All sources I have found, regarding the error, have downplayed its
> significance. There is not much of a reason for it to be on error level,
> while causing potential confusions or misinterpretations.
> 
> Signed-off-by: Wang Shenran <[e-mail]>
> ---
>  drivers/hwmon/acpi_power_meter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
> index 6ba1a08253f0..ee0363e5be43 100644
> --- a/drivers/hwmon/acpi_power_meter.c
> +++ b/drivers/hwmon/acpi_power_meter.c
> @@ -681,7 +681,7 @@ static int setup_attrs(struct
> acpi_power_meter_resource *resource)
> 

This patch is corrupted. Split line above, tabs replaced with spaces below.

Guenter

>         if (resource->caps.flags & POWER_METER_CAN_CAP) {
>                 if (!can_cap_in_hardware()) {
> -                       dev_err(&resource->acpi_dev->dev,
> +                       dev_warn(&resource->acpi_dev->dev,
>                                 "Ignoring unsafe software power cap!\n");
>                         goto skip_unsafe_cap;
>                 }
> -- 
> 2.20.1

Patch

diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
index 6ba1a08253f0..ee0363e5be43 100644
--- a/drivers/hwmon/acpi_power_meter.c
+++ b/drivers/hwmon/acpi_power_meter.c
@@ -681,7 +681,7 @@  static int setup_attrs(struct
acpi_power_meter_resource *resource)

        if (resource->caps.flags & POWER_METER_CAN_CAP) {
                if (!can_cap_in_hardware()) {
-                       dev_err(&resource->acpi_dev->dev,
+                       dev_warn(&resource->acpi_dev->dev,
                                "Ignoring unsafe software power cap!\n");
                        goto skip_unsafe_cap;