diff mbox series

[v2] hwmon: (nct6683) Add another customer ID for MSI

Message ID KY1Lwa2kjE7V78ZKOvQv0IavCNAQXJMIL4LYAALEUI52yxCxzzucAifFH8Y1wRFUm38ZZsBvCM0poaJL6bIqnjS1tL1o9K-h_h5-JJAe2rk=@proton.me (mailing list archive)
State Changes Requested
Headers show
Series [v2] hwmon: (nct6683) Add another customer ID for MSI | expand

Commit Message

John Jan. 6, 2025, 7:47 p.m. UTC 
> On Monday, January 6th, 2025 at 11:55 AM, Guenter Roeck linux@roeck-us.net wrote:

> > Please resend. The patch itself is almost ok, except I'd suggest to replace
> > "The value" with "The new customer ID" or similar in the patch description.
> > Also, please define the customer ID as "0x20d" (no leading 0) to be in line
> > with the other MSI customer IDs.

Incorporated this change as well as reworded the commit message.

From 0d95ea92928715b0de029b801b8604c1fdb4f78c Mon Sep 17 00:00:00 2001
From: John Audia <therealgraysky@proton.me>
Date: Wed, 1 Jan 2025 08:27:59 -0500
Subject: [PATCH] hwmon: (nct6683) Add another customer ID for MSI
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The new customer ID was found on a MPG X870E CARBON WIFI (MS-7E49) with
a NCT6687D chip.

For reference, sample output of sensors with this commit applied. Note-
the value of -40.0 for Thermistor 0 is to be expected as I do not have
a probe connected to that sensor.

nct6687-isa-0a20
Adapter: ISA adapter
VIN0:               1.01 V  (min =  +0.00 V, max =  +0.00 V)
VIN1:               1.01 V  (min =  +0.00 V, max =  +0.00 V)
VIN2:               1.30 V  (min =  +0.00 V, max =  +0.00 V)
VIN3:             672.00 mV (min =  +0.00 V, max =  +0.00 V)
VIN4:             704.00 mV (min =  +0.00 V, max =  +0.00 V)
VIN5:               2.03 V  (min =  +0.00 V, max =  +0.00 V)
VIN6:             448.00 mV (min =  +0.00 V, max =  +0.00 V)
VIN7:               1.50 V  (min =  +0.00 V, max =  +0.00 V)
VCC:                3.26 V  (min =  +0.00 V, max =  +0.00 V)
VSB:                3.33 V  (min =  +0.00 V, max =  +0.00 V)
AVSB:               3.33 V  (min =  +0.00 V, max =  +0.00 V)
VTT:                2.03 V  (min =  +0.00 V, max =  +0.00 V)
VBAT:               3.22 V  (min =  +0.00 V, max =  +0.00 V)
VREF:               1.79 V  (min =  +0.00 V, max =  +0.00 V)
fan1:              635 RPM  (min =    0 RPM)
fan2:              647 RPM  (min =    0 RPM)
fan3:                0 RPM  (min =    0 RPM)
fan4:                0 RPM  (min =    0 RPM)
fan12:               0 RPM  (min =    0 RPM)
fan13:               0 RPM  (min =    0 RPM)
fan14:               0 RPM  (min =    0 RPM)
fan15:               0 RPM  (min =    0 RPM)
fan16:               0 RPM  (min =    0 RPM)
AMD TSI Addr 98h:  +45.0°C  (low  =  +0.0°C)
                            (high =  +0.0°C, hyst =  +0.0°C)
                            (crit =  +0.0°C)  sensor = AMD AMDSI
Diode 0 (curr):    +52.0°C  (low  =  +0.0°C)
                            (high =  +0.0°C, hyst =  +0.0°C)
                            (crit =  +0.0°C)  sensor = thermal diode
Thermistor 15:     +47.5°C  (low  =  +0.0°C)
                            (high = +124.0°C, hyst = +34.0°C)
                            (crit =  +0.0°C)  sensor = thermistor
SMBus 0:           +53.0°C  (low  =  +0.0°C)
                            (high =  +0.0°C, hyst =  +0.0°C)
                            (crit =  +0.0°C)
SMBus 1:           +52.0°C  (low  =  +0.0°C)
                            (high =  +0.0°C, hyst =  +0.0°C)
                            (crit =  +0.0°C)
Thermistor 0:      -40.0°C  (low  =  +0.0°C)
                            (high =  +0.0°C, hyst =  +0.0°C)
                            (crit =  +0.0°C)  sensor = thermistor
Thermistor 15:     +47.5°C  (low  =  +0.0°C)
                            (high = +124.0°C, hyst = +34.0°C)
                            (crit =  +0.0°C)  sensor = thermistor
intrusion0:       ALARM
beep_enable:      disabled

Signed-off-by: John Audia <thereadgraysky@proton.me>
---
V1 -> V2: Leading 0 removed from customer ID, commit msg changed

 Documentation/hwmon/nct6683.rst | 1 +
 drivers/hwmon/nct6683.c         | 3 +++
 2 files changed, 4 insertions(+)

Comments

Guenter Roeck Jan. 6, 2025, 10:57 p.m. UTC | #1 
On 1/6/25 11:47, John wrote:
>> On Monday, January 6th, 2025 at 11:55 AM, Guenter Roeck linux@roeck-us.net wrote:
> 
>>> Please resend. The patch itself is almost ok, except I'd suggest to replace
>>> "The value" with "The new customer ID" or similar in the patch description.
>>> Also, please define the customer ID as "0x20d" (no leading 0) to be in line
>>> with the other MSI customer IDs.
> 
> Incorporated this change as well as reworded the commit message.
> 

That is still not the expected format. The above is unnecessary, and the 'sensors'
command output is irrelevant for the patch description.

More serious though is what checkpatch has to say:

WARNING: From:/Signed-off-by: email address mismatch: 'From: John Audia <therealgraysky@proton.me>' != 'Signed-off-by: John Audia <thereadgraysky@proton.me>'

Notice "therealgraysky" vs. "thereadgraysky"
               ^                    ^

This means I can't fix the problems myself (which I would have done
since I already spent way too much time on this).

Guenter

>>From 0d95ea92928715b0de029b801b8604c1fdb4f78c Mon Sep 17 00:00:00 2001
> From: John Audia <therealgraysky@proton.me>
> Date: Wed, 1 Jan 2025 08:27:59 -0500
> Subject: [PATCH] hwmon: (nct6683) Add another customer ID for MSI
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The new customer ID was found on a MPG X870E CARBON WIFI (MS-7E49) with
> a NCT6687D chip.
> 
> For reference, sample output of sensors with this commit applied. Note-
> the value of -40.0 for Thermistor 0 is to be expected as I do not have
> a probe connected to that sensor.
> 
> nct6687-isa-0a20
> Adapter: ISA adapter
> VIN0:               1.01 V  (min =  +0.00 V, max =  +0.00 V)
> VIN1:               1.01 V  (min =  +0.00 V, max =  +0.00 V)
> VIN2:               1.30 V  (min =  +0.00 V, max =  +0.00 V)
> VIN3:             672.00 mV (min =  +0.00 V, max =  +0.00 V)
> VIN4:             704.00 mV (min =  +0.00 V, max =  +0.00 V)
> VIN5:               2.03 V  (min =  +0.00 V, max =  +0.00 V)
> VIN6:             448.00 mV (min =  +0.00 V, max =  +0.00 V)
> VIN7:               1.50 V  (min =  +0.00 V, max =  +0.00 V)
> VCC:                3.26 V  (min =  +0.00 V, max =  +0.00 V)
> VSB:                3.33 V  (min =  +0.00 V, max =  +0.00 V)
> AVSB:               3.33 V  (min =  +0.00 V, max =  +0.00 V)
> VTT:                2.03 V  (min =  +0.00 V, max =  +0.00 V)
> VBAT:               3.22 V  (min =  +0.00 V, max =  +0.00 V)
> VREF:               1.79 V  (min =  +0.00 V, max =  +0.00 V)
> fan1:              635 RPM  (min =    0 RPM)
> fan2:              647 RPM  (min =    0 RPM)
> fan3:                0 RPM  (min =    0 RPM)
> fan4:                0 RPM  (min =    0 RPM)
> fan12:               0 RPM  (min =    0 RPM)
> fan13:               0 RPM  (min =    0 RPM)
> fan14:               0 RPM  (min =    0 RPM)
> fan15:               0 RPM  (min =    0 RPM)
> fan16:               0 RPM  (min =    0 RPM)
> AMD TSI Addr 98h:  +45.0°C  (low  =  +0.0°C)
>                              (high =  +0.0°C, hyst =  +0.0°C)
>                              (crit =  +0.0°C)  sensor = AMD AMDSI
> Diode 0 (curr):    +52.0°C  (low  =  +0.0°C)
>                              (high =  +0.0°C, hyst =  +0.0°C)
>                              (crit =  +0.0°C)  sensor = thermal diode
> Thermistor 15:     +47.5°C  (low  =  +0.0°C)
>                              (high = +124.0°C, hyst = +34.0°C)
>                              (crit =  +0.0°C)  sensor = thermistor
> SMBus 0:           +53.0°C  (low  =  +0.0°C)
>                              (high =  +0.0°C, hyst =  +0.0°C)
>                              (crit =  +0.0°C)
> SMBus 1:           +52.0°C  (low  =  +0.0°C)
>                              (high =  +0.0°C, hyst =  +0.0°C)
>                              (crit =  +0.0°C)
> Thermistor 0:      -40.0°C  (low  =  +0.0°C)
>                              (high =  +0.0°C, hyst =  +0.0°C)
>                              (crit =  +0.0°C)  sensor = thermistor
> Thermistor 15:     +47.5°C  (low  =  +0.0°C)
>                              (high = +124.0°C, hyst = +34.0°C)
>                              (crit =  +0.0°C)  sensor = thermistor
> intrusion0:       ALARM
> beep_enable:      disabled
> 
> Signed-off-by: John Audia <thereadgraysky@proton.me>
> ---
> V1 -> V2: Leading 0 removed from customer ID, commit msg changed
> 
>   Documentation/hwmon/nct6683.rst | 1 +
>   drivers/hwmon/nct6683.c         | 3 +++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
> index 2a7a78eb1b46..2302b1ac95b1 100644
> --- a/Documentation/hwmon/nct6683.rst
> +++ b/Documentation/hwmon/nct6683.rst
> @@ -65,4 +65,5 @@ ASRock X570	NCT6683D EC firmware version 1.0 build 06/28/19
>   ASRock X670E	NCT6686D EC firmware version 1.0 build 05/19/22
>   MSI B550	NCT6687D EC firmware version 1.0 build 05/07/20
>   MSI X670-P	NCT6687D EC firmware version 0.0 build 09/27/22
> +MSI X870E	NCT6687D EC firmware version 0.0 build 11/13/24
>   =============== ===============================================
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index f71615e06a8f..288f497d364a 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -175,6 +175,7 @@ superio_exit(int ioreg)
>   #define NCT6683_CUSTOMER_ID_MSI		0x201
>   #define NCT6683_CUSTOMER_ID_MSI2	0x200
>   #define NCT6683_CUSTOMER_ID_MSI3	0x207
> +#define NCT6683_CUSTOMER_ID_MSI4	0x20d
>   #define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
>   #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
>   #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
> @@ -1227,6 +1228,8 @@ static int nct6683_probe(struct platform_device *pdev)
>   		break;
>   	case NCT6683_CUSTOMER_ID_MSI3:
>   		break;
> +	case NCT6683_CUSTOMER_ID_MSI4:
> +		break;
>   	case NCT6683_CUSTOMER_ID_ASROCK:
>   		break;
>   	case NCT6683_CUSTOMER_ID_ASROCK2:
diff mbox series

Patch

diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
index 2a7a78eb1b46..2302b1ac95b1 100644
--- a/Documentation/hwmon/nct6683.rst
+++ b/Documentation/hwmon/nct6683.rst
@@ -65,4 +65,5 @@  ASRock X570	NCT6683D EC firmware version 1.0 build 06/28/19
 ASRock X670E	NCT6686D EC firmware version 1.0 build 05/19/22
 MSI B550	NCT6687D EC firmware version 1.0 build 05/07/20
 MSI X670-P	NCT6687D EC firmware version 0.0 build 09/27/22
+MSI X870E	NCT6687D EC firmware version 0.0 build 11/13/24
 =============== ===============================================
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index f71615e06a8f..288f497d364a 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -175,6 +175,7 @@  superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_MSI		0x201
 #define NCT6683_CUSTOMER_ID_MSI2	0x200
 #define NCT6683_CUSTOMER_ID_MSI3	0x207
+#define NCT6683_CUSTOMER_ID_MSI4	0x20d
 #define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
 #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
 #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
@@ -1227,6 +1228,8 @@  static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_MSI3:
 		break;
+	case NCT6683_CUSTOMER_ID_MSI4:
+		break;
 	case NCT6683_CUSTOMER_ID_ASROCK:
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK2: