From patchwork Wed Jan 1 14:15:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John X-Patchwork-Id: 13924203 Received: from mail-10697.protonmail.ch (mail-10697.protonmail.ch [79.135.106.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B985D2119 for ; Wed, 1 Jan 2025 14:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735740935; cv=none; b=DSMQ5IjMLwVIJh4ZJykqj47cj0tKd7V9/GpFK0bFm2nKEEt4Ib3meYpH01g/d+B3Ger1X9l/4QWGGWa0iWDtqIDpGWcgLROBGbFu3SJLOoMsBEbE6FxqTrD+jaLZiDe6q2qlpXrxBfYjZ4rJyMc/HJMZikpHDQoKCEflZhf2TTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735740935; c=relaxed/simple; bh=PsDgxFIPHdjKywUN8Eh2lwfvOq/h4YiCNAtSYH8Qi8E=; h=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=UyTUoo6sxJS9k+PZqvSdwZ21t9C+QU142iuzC63JkWBNI2Ksdu046qXyJGtVKuwac7+tw6AXNtd/Zc8lNB9Gu09leJZAXOzo9oV/LgySAzPnCyGB41Q7p6yQ2lkOgZVPzISeLsjWPkYS+ljC7V1bbdSsW1DuCLvtPPFCkF8MYVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=AYjll68b; arc=none smtp.client-ip=79.135.106.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="AYjll68b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1735740925; x=1736000125; bh=04A3A1uSeq8jy0tAdg6cI8DjLUZQeHn6+99GqE5ZNAs=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=AYjll68baNHTtTeyW6ejuuDGi4BHTYDdP0aw4VgBDcCayeQBeoCGOS2FjBp9hxpXn s+2HDSF0dukZhAdI/PorRBM93xZMvtP+UvavloQlxbpSBciX1rXevo/WhW/ZeHslAs EzYUKIHpH7weMNbvIyKLsFMzUD/Kez6OcbuwS2Ik/PXt+NgUMYvccSILvwH0Ke+Gjr YSrGkyvfZRBSwPtOHCQTE9VJK45Ys8Wywy71lNXeBe18v4oEeCNph5MXHvq0fYT51c orls5miLPvDhIz6gpp6YLPIGQ3pEdJp41qTTnu+8rvIFIS+iEnRaVU+/SBE8DdHGsT WRzNzQGCgoqEw== Date: Wed, 01 Jan 2025 14:15:20 +0000 To: "linux-hwmon@vger.kernel.org" From: John Cc: Jean Delvare , Guenter Roeck Subject: [PATCH] hwmon: (nct6683) Add another customer ID for MSI Message-ID: Feedback-ID: 47473199:user:proton X-Pm-Message-ID: 32d549a81d57f154fa2d8039180e3a509d30f989 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The attached is my attempt to add support for a new MSI motherboard with a NCT6687D on board. I do not know why one of the sensors it reads gets reported at -40.0 however. Calling sensors multiple times shows that -40.0 value seems to bounce around from "Thermistor 0" and "Chipset B." Feedback is appreciated. For reference, I attached a sample output of sensors for the new chip with this patch applied: nct6687-isa-0a20 Adapter: ISA adapter VIN0: 1.01 V (min = +0.00 V, max = +0.00 V) VIN1: 1.01 V (min = +0.00 V, max = +0.00 V) VIN2: 1.30 V (min = +0.00 V, max = +0.00 V) VIN3: 672.00 mV (min = +0.00 V, max = +0.00 V) VIN4: 1.01 V (min = +0.00 V, max = +0.00 V) VIN5: 2.03 V (min = +0.00 V, max = +0.00 V) VIN6: 464.00 mV (min = +0.00 V, max = +0.00 V) VIN7: 1.52 V (min = +0.00 V, max = +0.00 V) VCC: 3.28 V (min = +0.00 V, max = +0.00 V) VSB: 3.33 V (min = +0.00 V, max = +0.00 V) AVSB: 3.33 V (min = +0.00 V, max = +0.00 V) VTT: 2.03 V (min = +0.00 V, max = +0.00 V) VBAT: 3.18 V (min = +0.00 V, max = +0.00 V) VREF: 1.79 V (min = +0.00 V, max = +0.00 V) fan1: 747 RPM (min = 0 RPM) fan2: 745 RPM (min = 0 RPM) fan3: 0 RPM (min = 0 RPM) fan4: 0 RPM (min = 0 RPM) fan12: 0 RPM (min = 0 RPM) fan13: 0 RPM (min = 0 RPM) fan14: 0 RPM (min = 0 RPM) fan15: 0 RPM (min = 0 RPM) fan16: 0 RPM (min = 0 RPM) AMD TSI Addr 98h: +49.0°C (low = +0.0°C) (high = +0.0°C, hyst = +0.0°C) (crit = +0.0°C) sensor = AMD AMDSI Diode 0 (curr): +56.0°C (low = +0.0°C) (high = +0.0°C, hyst = +0.0°C) (crit = +0.0°C) sensor = thermal diode Thermistor 15: +52.0°C (low = +0.0°C) (high = +124.0°C, hyst = +34.0°C) (crit = +0.0°C) sensor = thermistor SMBus 0: +56.0°C (low = +0.0°C) (high = +0.0°C, hyst = +0.0°C) (crit = +0.0°C) SMBus 1: +56.0°C (low = +0.0°C) (high = +0.0°C, hyst = +0.0°C) (crit = +0.0°C) Thermistor 0: -40.0°C (low = +0.0°C) (high = +0.0°C, hyst = +0.0°C) (crit = +0.0°C) sensor = thermistor Thermistor 15: +52.0°C (low = +0.0°C) (high = +124.0°C, hyst = +34.0°C) (crit = +0.0°C) sensor = thermistor intrusion0: ALARM beep_enable: disabled From 5520629e6d63a83a6f6772b99aef408c11f58025 Mon Sep 17 00:00:00 2001 From: John Audia Date: Wed, 1 Jan 2025 08:27:59 -0500 Subject: [PATCH] hwmon: (nct6683) Add another customer ID for MSI This value was found on an MSI MPG X870E CARBON WIFI (MS-7E49) with an NCT6687D chip. Signed-off-by: John Audia --- Documentation/hwmon/nct6683.rst | 1 + drivers/hwmon/nct6683.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst index 2a7a78eb1b46..2302b1ac95b1 100644 --- a/Documentation/hwmon/nct6683.rst +++ b/Documentation/hwmon/nct6683.rst @@ -65,4 +65,5 @@ ASRock X570 NCT6683D EC firmware version 1.0 build 06/28/19 ASRock X670E NCT6686D EC firmware version 1.0 build 05/19/22 MSI B550 NCT6687D EC firmware version 1.0 build 05/07/20 MSI X670-P NCT6687D EC firmware version 0.0 build 09/27/22 +MSI X870E NCT6687D EC firmware version 0.0 build 11/13/24 =============== =============================================== diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index f71615e06a8f..e1f2736ee3d2 100644 --- a/drivers/hwmon/nct6683.c +++ b/drivers/hwmon/nct6683.c @@ -175,6 +175,7 @@ superio_exit(int ioreg) #define NCT6683_CUSTOMER_ID_MSI 0x201 #define NCT6683_CUSTOMER_ID_MSI2 0x200 #define NCT6683_CUSTOMER_ID_MSI3 0x207 +#define NCT6683_CUSTOMER_ID_MSI4 0x020d #define NCT6683_CUSTOMER_ID_ASROCK 0xe2c #define NCT6683_CUSTOMER_ID_ASROCK2 0xe1b #define NCT6683_CUSTOMER_ID_ASROCK3 0x1631 @@ -1227,6 +1228,8 @@ static int nct6683_probe(struct platform_device *pdev) break; case NCT6683_CUSTOMER_ID_MSI3: break; + case NCT6683_CUSTOMER_ID_MSI4: + break; case NCT6683_CUSTOMER_ID_ASROCK: break; case NCT6683_CUSTOMER_ID_ASROCK2: -- 2.47.1