[v2,1/2] dt-bindings: hwmon: Add mps mp2891 driver bindings

Commit Message

Noah Wang May 23, 2024, 9:33 a.m. UTC

Add a device tree bindings for mp2891 device.

Signed-off-by: Noah Wang <[e-mail]>
---
 .../bindings/hwmon/pmbus/mps,mp2891.yaml      | 43 +++++++++++++++++++
 MAINTAINERS                                   |  8 ++++
 2 files changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mp2891.yaml

Comments

Krzysztof Kozlowski May 23, 2024, 9:53 a.m. UTC | #1

On 23/05/2024 11:33, Noah Wang wrote:
> Add a device tree bindings for mp2891 device.
> 
> Signed-off-by: Noah Wang <[e-mail]>

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Subject: drop driver and describe hardware

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.


> ---
>  .../bindings/hwmon/pmbus/mps,mp2891.yaml      | 43 +++++++++++++++++++
>  MAINTAINERS                                   |  8 ++++
>  2 files changed, 51 insertions(+)


...

>  
> +MPS MP2891 DRIVER
> +M:	Noah Wang <[e-mail]>
> +L:	[e-mail]
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/hwmon/mps,mp2891.yaml
> +F:	Documentation/hwmon/mp2891.rst

There is no such file.

> +F:	drivers/hwmon/pmbus/mp2891.c

There is no such file.

Are you sure your patchset is fully bisectable (including paths here)?

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mp2891.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mp2891.yaml
new file mode 100644
index 000000000..9afa7fd3f
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mp2891.yaml
@@ -0,0 +1,43 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
++$id: http://devicetree.org/schemas/hwmon/mps,mp2891.yaml#
++$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The MPS MP2891 Multi-phase Digital VR Controller
+
+maintainers:
+  - Noah Wang <[e-mail]>
+
+description:
+  The MP2891 is a dual-rail, digital, multi-phase voltage regulator with
+  PWM-VID and I2C interface for Industrial use.
+
+  Datasheets:
+    https://www.monolithicpower.com/en/mp2891.html
+
+properties:
+  compatible:
+    const: mps,mp2891
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      mp2891@1f {
+        compatible = "mps,mp2891";
+        reg = <0x1f>;
+      };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index e5dbbf1ed..bbe9a3ca8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22683,6 +22683,14 @@  S:	Maintained
 F:	Documentation/hwmon/tps546d24.rst
 F:	drivers/hwmon/pmbus/tps546d24.c
 
+MPS MP2891 DRIVER
+M:	Noah Wang <[e-mail]>
+L:	[e-mail]
+S:	Maintained
+F:	Documentation/devicetree/bindings/hwmon/mps,mp2891.yaml
+F:	Documentation/hwmon/mp2891.rst
+F:	drivers/hwmon/pmbus/mp2891.c
+
 TQ SYSTEMS BOARD & DRIVER SUPPORT
 L:	[e-mail]
 S:	Supported