From patchwork Tue Jan 10 05:48:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 9506371 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8A9C460231 for ; Tue, 10 Jan 2017 05:48:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77825283F6 for ; Tue, 10 Jan 2017 05:48:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A50728452; Tue, 10 Jan 2017 05:48:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E23FA283F6 for ; Tue, 10 Jan 2017 05:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764837AbdAJFsY (ORCPT ); Tue, 10 Jan 2017 00:48:24 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:58114 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdAJFsP (ORCPT ); Tue, 10 Jan 2017 00:48:15 -0500 X-IronPort-AV: E=Sophos;i="5.33,342,1477954800"; d="scan'208";a="208561797" Received: from wlan.dagstuhl.de (HELO [192.168.12.123]) ([192.76.146.51]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2017 06:48:02 +0100 Date: Tue, 10 Jan 2017 06:48:02 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaghathiswari Rankappagounder Natarajan cc: openbmc@lists.ozlabs.org, joel@jms.id.au, jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] drivers: hwmon: fix device_node_continue.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci CC: Jaghathiswari Rankappagounder Natarajan Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- The patch would not be needed if aspeed_create_type etc perform a second get, beyond the one in the iterator. aspeed-pwm-tacho.c | 3 --- 1 file changed, 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -833,21 +833,18 @@ static int aspeed_pwm_tacho_probe(struct type_np = of_get_child_by_name(np, "type_values"); for_each_child_of_node(type_np, child) { aspeed_create_type(child, priv, type_index++); - of_node_put(child); } of_node_put(type_np); pwm_np = of_get_child_by_name(np, "pwm_port"); for_each_child_of_node(pwm_np, child) { aspeed_create_pwm_port(child, priv, pwm_index++, group_index++); - of_node_put(child); } of_node_put(pwm_np); fan_tach_np = of_get_child_by_name(np, "fan_tach_channel"); for_each_child_of_node(fan_tach_np, child) { aspeed_create_fan_tach_channel(&pdev->dev, child, priv, fan_index++, group_index++); - of_node_put(child); } of_node_put(fan_tach_np); of_node_put(np);