diff mbox series

[v1,2/4] dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter

Message ID ba6346942dfed14440e0243a6da510581389fbdd.1642434222.git.sylv@sylv.io (mailing list archive)
State Changes Requested
Headers show
Series Support bcm6123 Bus Converter | expand

Commit Message

Marcello Sylvester Bauer Jan. 17, 2022, 4:12 p.m. UTC 
Add bindings for BCM6123 Bus Converter from Vicor Corporation.

Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
---
 .../bindings/hwmon/pmbus/vicor,bcm6123.yaml   | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml

Comments

Guenter Roeck Jan. 17, 2022, 5:06 p.m. UTC | #1 
On 1/17/22 8:12 AM, Marcello Sylvester Bauer wrote:
> Add bindings for BCM6123 Bus Converter from Vicor Corporation.
> 
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>

Can this be added to trivial devices instead ?

Guenter

> ---
>   .../bindings/hwmon/pmbus/vicor,bcm6123.yaml   | 41 +++++++++++++++++++
>   1 file changed, 41 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> new file mode 100644
> index 000000000000..5559d22e00f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,bcm6123.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Vicor Corporation BCM6123 Bus Converter
> +
> +description: |
> +  The BCM6123 is an isolated Fixed-Ratio DC-DC Converter,
> +  operating from a 260V to 410V primary bus to deliver an unregulated
> +  ratiometric secondary voltage.
> +
> +  Datasheet: https://www.vicorpower.com/documents/datasheets/ds_BCM6123xD1E5135yzz.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - vicor,bcm6123
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        bcm6123@5f {
> +            compatible = "vicor,bcm6123";
> +            reg = <0x5f>;
> +        };
> +    };
>
Rob Herring Jan. 18, 2022, 1:32 a.m. UTC | #2 
On Mon, 17 Jan 2022 17:12:48 +0100, Marcello Sylvester Bauer wrote:
> Add bindings for BCM6123 Bus Converter from Vicor Corporation.
> 
> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> ---
>  .../bindings/hwmon/pmbus/vicor,bcm6123.yaml   | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml: 'maintainers' is a required property
	hint: Metaschema for devicetree binding documentation
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml: ignoring, error in schema: 
Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.example.dt.yaml:0:0: /example-0/i2c/bcm6123@5f: failed to match any schema with compatible: ['vicor,bcm6123']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1580909

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Marcello Sylvester Bauer Jan. 18, 2022, 7:48 a.m. UTC | #3 
On Mon, 2022-01-17 at 09:06 -0800, Guenter Roeck wrote:
> On 1/17/22 8:12 AM, Marcello Sylvester Bauer wrote:
> > Add bindings for BCM6123 Bus Converter from Vicor Corporation.
> > 
> > Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
> 
> Can this be added to trivial devices instead ?
> 
> Guenter

Indeed. Thanks.

Marcello

> 
> > ---
> >   .../bindings/hwmon/pmbus/vicor,bcm6123.yaml   | 41 +++++++++++++++++++
> >   1 file changed, 41 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> > new file mode 100644
> > index 000000000000..5559d22e00f1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,bcm6123.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Vicor Corporation BCM6123 Bus Converter
> > +
> > +description: |
> > +  The BCM6123 is an isolated Fixed-Ratio DC-DC Converter,
> > +  operating from a 260V to 410V primary bus to deliver an unregulated
> > +  ratiometric secondary voltage.
> > +
> > +  Datasheet: https://www.vicorpower.com/documents/datasheets/ds_BCM6123xD1E5135yzz.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - vicor,bcm6123
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        bcm6123@5f {
> > +            compatible = "vicor,bcm6123";
> > +            reg = <0x5f>;
> > +        };
> > +    };
> > 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
new file mode 100644
index 000000000000..5559d22e00f1
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
@@ -0,0 +1,41 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,bcm6123.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Vicor Corporation BCM6123 Bus Converter
+
+description: |
+  The BCM6123 is an isolated Fixed-Ratio DC-DC Converter,
+  operating from a 260V to 410V primary bus to deliver an unregulated
+  ratiometric secondary voltage.
+
+  Datasheet: https://www.vicorpower.com/documents/datasheets/ds_BCM6123xD1E5135yzz.pdf
+
+properties:
+  compatible:
+    enum:
+      - vicor,bcm6123
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        bcm6123@5f {
+            compatible = "vicor,bcm6123";
+            reg = <0x5f>;
+        };
+    };