From patchwork Wed Jul 5 05:11:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9825841 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EAB8E60317 for ; Wed, 5 Jul 2017 05:11:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC61E204BE for ; Wed, 5 Jul 2017 05:11:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE34420952; Wed, 5 Jul 2017 05:11:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AE4B204BE for ; Wed, 5 Jul 2017 05:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750825AbdGEFLi (ORCPT ); Wed, 5 Jul 2017 01:11:38 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35694 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdGEFLi (ORCPT ); Wed, 5 Jul 2017 01:11:38 -0400 Received: by mail-pg0-f66.google.com with SMTP id d193so11516111pgc.2; Tue, 04 Jul 2017 22:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cN7MghMSDc+zTNZTI2zdQy6UercUF9FhafePnefkKZM=; b=Z7vtD9IXCH6cTX9GltI7aSsH+QPHgmidfM71RV81RaAtGB5mCmHhx2pIfwwi65KWe8 rLDBhQRpyacup9QoPzL/TeMp9PIB31t3sP5imQlR8NLUaEetC4eS/uO7YzKd4FUf8rey 6wM4IdhBfKmKrcrgXtCdGrEp/x0ooL2av+tecus4HlhYaFGUYKm8Nw/cNl712GgbJOVi H4GqHerBhJPzpv99AfEzJNvGzRjhIupPTzooHxbDxCswqvYEekFX1xWRjzpGD+2Tfgyv XALi+5FiCpgr/sGBJulPHiFaucM5GpFxApfce6m0R+DXXhM+n79qyjE2MM2Bzm2IMb6Q WCww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cN7MghMSDc+zTNZTI2zdQy6UercUF9FhafePnefkKZM=; b=RPqC9Frx3bbL5ZppKTY4mVMyPCn8MYW+l23CfXd1XLGbzKZd5JQMVDQ3ag08/n01HE cWp30E0ajRslMXPzt1UnaW+bzR6aPU6HtVQvOz2QeGmBFeBEXom1BBvB7sI/IXqznrk9 hMvS3PoQZFkmhaGvQ3Da02tTmbKOSkr90v/sQZRprW2Ssa5Qx3YSmtmFLlU6ZGbqE8HY lt4ND3Mscz2jVt/UmEtPAs7KNE1JaxiL8GUqOtLapONJB5u7KaPcNxi2ZBwiK6aEd3Oh GYABnz4CaaiDqanVrt3r+FLxIIFYTRaWkI3Rqlo5nJwp60OB3GGBou+AjLTMAUtHPF0S q3ew== X-Gm-Message-State: AIVw110aP4UuSwJW8rNrAqDpo0hLCuIC+9Z/FnS5Szl+01HmferDw+kR y28T6CnmnRklhg== X-Received: by 10.98.93.136 with SMTP id n8mr18521576pfj.211.1499231497546; Tue, 04 Jul 2017 22:11:37 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id f10sm42183830pgu.54.2017.07.04.22.11.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 22:11:36 -0700 (PDT) From: Arvind Yadav To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] hwmon: nct7802: constify attribute_group structures. Date: Wed, 5 Jul 2017 10:41:18 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 6161 9400 0 15561 3cc9 drivers/hwmon/nct7802.o File size After adding 'const': text data bss dec hex filename 6465 9080 0 15545 3cb9 drivers/hwmon/nct7802.o Signed-off-by: Arvind Yadav --- Changes in v1: Subject was not correct. Now comparing size of nct7802.c drivers/hwmon/nct7802.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index 12b94b0..2876c18 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c @@ -704,7 +704,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_temp_group = { +static const struct attribute_group nct7802_temp_group = { .attrs = nct7802_temp_attrs, .is_visible = nct7802_temp_is_visible, }; @@ -802,7 +802,7 @@ static umode_t nct7802_in_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_in_group = { +static const struct attribute_group nct7802_in_group = { .attrs = nct7802_in_attrs, .is_visible = nct7802_in_is_visible, }; @@ -880,7 +880,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_fan_group = { +static const struct attribute_group nct7802_fan_group = { .attrs = nct7802_fan_attrs, .is_visible = nct7802_fan_is_visible, }; @@ -898,7 +898,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, NULL }; -static struct attribute_group nct7802_pwm_group = { +static const struct attribute_group nct7802_pwm_group = { .attrs = nct7802_pwm_attrs, }; @@ -1011,7 +1011,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, S_IRUGO | S_IWUSR, NULL }; -static struct attribute_group nct7802_auto_point_group = { +static const struct attribute_group nct7802_auto_point_group = { .attrs = nct7802_auto_point_attrs, };