[v2,0/4] bus: Make remove callback return void

Message

Uwe Kleine-König July 6, 2021, 3:47 p.m. UTC

Hello,

compared to (implicit) v1 that I sent earlier today
(https://lore.kernel.org/r/[e-mail])
the following is changed:

 - Add three more patches preparing some s390 specific busses
   and adapt them in the last patch. Thanks to Cornelia Huck for
   pointing this out.
 - Add various Acks to the last patch

I now tested allmodconfig on arm, powerpc, s390 and amd64.

As before this depends on "PCI: endpoint: Make struct pci_epf_driver::remove
return void" that is not yet applied, see
https://lore.kernel.org/r/[e-mail].

Best regards
Uwe

Uwe Kleine-König (4):
  s390/cio: Make struct css_driver::remove return void
  s390/ccwgroup: Drop if with an always false condition
  s390/scm: Make struct scm_driver::remove return void
  bus: Make remove callback return void

 arch/arm/common/locomo.c                  | 3 +--
 arch/arm/common/sa1111.c                  | 4 +---
 arch/arm/mach-rpc/ecard.c                 | 4 +---
 arch/mips/sgi-ip22/ip22-gio.c             | 3 +--
 arch/parisc/kernel/drivers.c              | 5 ++---
 arch/powerpc/platforms/ps3/system-bus.c   | 3 +--
 arch/powerpc/platforms/pseries/ibmebus.c  | 3 +--
 arch/powerpc/platforms/pseries/vio.c      | 3 +--
 arch/s390/include/asm/eadm.h              | 2 +-
 drivers/acpi/bus.c                        | 3 +--
 drivers/amba/bus.c                        | 4 +---
 drivers/base/auxiliary.c                  | 4 +---
 drivers/base/isa.c                        | 4 +---
 drivers/base/platform.c                   | 4 +---
 drivers/bcma/main.c                       | 6 ++----
 drivers/bus/sunxi-rsb.c                   | 4 +---
 drivers/cxl/core.c                        | 3 +--
 drivers/dax/bus.c                         | 4 +---
 drivers/dma/idxd/sysfs.c                  | 4 +---
 drivers/firewire/core-device.c            | 4 +---
 drivers/firmware/arm_scmi/bus.c           | 4 +---
 drivers/firmware/google/coreboot_table.c  | 4 +---
 drivers/fpga/dfl.c                        | 4 +---
 drivers/hid/hid-core.c                    | 4 +---
 drivers/hid/intel-ish-hid/ishtp/bus.c     | 4 +---
 drivers/hv/vmbus_drv.c                    | 5 +----
 drivers/hwtracing/intel_th/core.c         | 4 +---
 drivers/i2c/i2c-core-base.c               | 5 +----
 drivers/i3c/master.c                      | 4 +---
 drivers/input/gameport/gameport.c         | 3 +--
 drivers/input/serio/serio.c               | 3 +--
 drivers/ipack/ipack.c                     | 4 +---
 drivers/macintosh/macio_asic.c            | 4 +---
 drivers/mcb/mcb-core.c                    | 4 +---
 drivers/media/pci/bt8xx/bttv-gpio.c       | 3 +--
 drivers/memstick/core/memstick.c          | 3 +--
 drivers/mfd/mcp-core.c                    | 3 +--
 drivers/misc/mei/bus.c                    | 4 +---
 drivers/misc/tifm_core.c                  | 3 +--
 drivers/mmc/core/bus.c                    | 4 +---
 drivers/mmc/core/sdio_bus.c               | 4 +---
 drivers/net/netdevsim/bus.c               | 3 +--
 drivers/ntb/core.c                        | 4 +---
 drivers/ntb/ntb_transport.c               | 4 +---
 drivers/nvdimm/bus.c                      | 3 +--
 drivers/pci/endpoint/pci-epf-core.c       | 4 +---
 drivers/pci/pci-driver.c                  | 3 +--
 drivers/pcmcia/ds.c                       | 4 +---
 drivers/platform/surface/aggregator/bus.c | 4 +---
 drivers/platform/x86/wmi.c                | 4 +---
 drivers/pnp/driver.c                      | 3 +--
 drivers/rapidio/rio-driver.c              | 4 +---
 drivers/rpmsg/rpmsg_core.c                | 4 +---
 drivers/s390/block/scm_drv.c              | 4 +---
 drivers/s390/cio/ccwgroup.c               | 6 +-----
 drivers/s390/cio/chsc_sch.c               | 3 +--
 drivers/s390/cio/css.c                    | 7 +++----
 drivers/s390/cio/css.h                    | 2 +-
 drivers/s390/cio/device.c                 | 9 +++------
 drivers/s390/cio/eadm_sch.c               | 4 +---
 drivers/s390/cio/scm.c                    | 5 +++--
 drivers/s390/cio/vfio_ccw_drv.c           | 3 +--
 drivers/s390/crypto/ap_bus.c              | 4 +---
 drivers/scsi/scsi_debug.c                 | 3 +--
 drivers/siox/siox-core.c                  | 4 +---
 drivers/slimbus/core.c                    | 4 +---
 drivers/soc/qcom/apr.c                    | 4 +---
 drivers/spi/spi.c                         | 4 +---
 drivers/spmi/spmi.c                       | 3 +--
 drivers/ssb/main.c                        | 4 +---
 drivers/staging/fieldbus/anybuss/host.c   | 4 +---
 drivers/staging/greybus/gbphy.c           | 4 +---
 drivers/target/loopback/tcm_loop.c        | 5 ++---
 drivers/thunderbolt/domain.c              | 4 +---
 drivers/tty/serdev/core.c                 | 4 +---
 drivers/usb/common/ulpi.c                 | 4 +---
 drivers/usb/serial/bus.c                  | 4 +---
 drivers/usb/typec/bus.c                   | 4 +---
 drivers/vdpa/vdpa.c                       | 4 +---
 drivers/vfio/mdev/mdev_driver.c           | 4 +---
 drivers/virtio/virtio.c                   | 3 +--
 drivers/vme/vme.c                         | 4 +---
 drivers/xen/xenbus/xenbus.h               | 2 +-
 drivers/xen/xenbus/xenbus_probe.c         | 4 +---
 include/linux/device/bus.h                | 2 +-
 sound/aoa/soundbus/core.c                 | 4 +---
 86 files changed, 95 insertions(+), 236 deletions(-)


base-commit: 79160a603bdb51916226caf4a6616cc4e1c58a58
prerequisite-patch-id: e5c7b97ea399fddc2695e8cf5d0c02d14175abac

Comments

Uwe Kleine-König July 6, 2021, 6:32 p.m. UTC | #1

Hello,

v1 was acked by some more after I stopped looking in my mailbox while
preparing v2:

On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> 
> Acked-by: Russell King (Oracle) <[e-mail]> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <[e-mail]>
> Acked-by: Chen-Yu Tsai <[e-mail]> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <[e-mail]>
> Acked-by: Mauro Carvalho Chehab <[e-mail]> (for drivers/media)
> Acked-by: Hans de Goede <[e-mail]> (For drivers/platform)
> Acked-by: Alexandre Belloni <[e-mail]>
> Acked-By: Vinod Koul <[e-mail]>
> Acked-by: Juergen Gross <[e-mail]> (For Xen)
> Acked-by: Lee Jones <[e-mail]> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <[e-mail]> (For drivers/mcb)
> Acked-by: Johan Hovold <[e-mail]>
> Acked-by: Srinivas Kandagatla <[e-mail]> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <[e-mail]> (For drivers/vfio)
> Acked-by: Maximilian Luz <[e-mail]>
> Acked-by: Heikki Krogerus <[e-mail]> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <[e-mail]> (For ipack)
> Reviewed-by: Tom Rix <[e-mail]> (For fpga)
> Acked-by: Geoff Levand <[e-mail]> (For ps3)

Acked-by: Yehezkel Bernat <[e-mail]> (For thunderbolt)
Reviewed-by: Mathieu Poirier <[e-mail]>
Acked-by: Alexander Shishkin <[e-mail]> (For intel_th)
Acked-by: Dominik Brodowski <[e-mail]> (For pcmcia)

> Signed-off-by: Uwe Kleine-König <[e-mail]>

Best regards
Uwe

Dan Williams July 6, 2021, 6:51 p.m. UTC | #2

On Tue, Jul 6, 2021 at 8:51 AM Uwe Kleine-König
<[e-mail]> wrote:
>
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>

>  drivers/cxl/core.c                        | 3 +--
>  drivers/dax/bus.c                         | 4 +---
>  drivers/nvdimm/bus.c                      | 3 +--

For CXL, DAX, and NVDIMM

Acked-by: Dan Williams <[e-mail]>

Benjamin Tissoires July 7, 2021, 2:24 p.m. UTC | #3

On 7/6/21 5:48 PM, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> 
> Acked-by: Russell King (Oracle) <[e-mail]> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <[e-mail]>
> Acked-by: Chen-Yu Tsai <[e-mail]> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <[e-mail]>
> Acked-by: Mauro Carvalho Chehab <[e-mail]> (for drivers/media)
> Acked-by: Hans de Goede <[e-mail]> (For drivers/platform)
> Acked-by: Alexandre Belloni <[e-mail]>
> Acked-By: Vinod Koul <[e-mail]>
> Acked-by: Juergen Gross <[e-mail]> (For Xen)
> Acked-by: Lee Jones <[e-mail]> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <[e-mail]> (For drivers/mcb)
> Acked-by: Johan Hovold <[e-mail]>
> Acked-by: Srinivas Kandagatla <[e-mail]> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <[e-mail]> (For drivers/vfio)
> Acked-by: Maximilian Luz <[e-mail]>
> Acked-by: Heikki Krogerus <[e-mail]> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <[e-mail]> (For ipack)
> Reviewed-by: Tom Rix <[e-mail]> (For fpga)
> Acked-by: Geoff Levand <[e-mail]> (For ps3)
> Signed-off-by: Uwe Kleine-König <[e-mail]>
> ---
> 

[...]

>   drivers/hid/hid-core.c                    | 4 +---
>   drivers/hid/intel-ish-hid/ishtp/bus.c     | 4 +---

[...]

> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 7db332139f7d..dbed2524fd47 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2302,7 +2302,7 @@ static int hid_device_probe(struct device *dev)
>   	return ret;
>   }
>   
> -static int hid_device_remove(struct device *dev)
> +static void hid_device_remove(struct device *dev)
>   {
>   	struct hid_device *hdev = to_hid_device(dev);
>   	struct hid_driver *hdrv;
> @@ -2322,8 +2322,6 @@ static int hid_device_remove(struct device *dev)
>   
>   	if (!hdev->io_started)
>   		up(&hdev->driver_input_lock);
> -
> -	return 0;
>   }
>   
>   static ssize_t modalias_show(struct device *dev, struct device_attribute *a,
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index f0802b047ed8..8a51bd9cd093 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -255,7 +255,7 @@ static int ishtp_cl_bus_match(struct device *dev, struct device_driver *drv)
>    *
>    * Return: Return value from driver remove() call.
>    */
> -static int ishtp_cl_device_remove(struct device *dev)
> +static void ishtp_cl_device_remove(struct device *dev)
>   {
>   	struct ishtp_cl_device *device = to_ishtp_cl_device(dev);
>   	struct ishtp_cl_driver *driver = to_ishtp_cl_driver(dev->driver);
> @@ -267,8 +267,6 @@ static int ishtp_cl_device_remove(struct device *dev)
>   
>   	if (driver->remove)
>   		driver->remove(device);
> -
> -	return 0;
>   }
>   
>   /**

For the HID part:

Acked-by: Benjamin Tissoires <[e-mail]>

Cheers,
Benjamin

Uwe Kleine-König July 8, 2021, 5:38 a.m. UTC | #4

On Wed, Jul 07, 2021 at 10:08:53PM -0400, Sven Van Asbroeck wrote:
> On Tue, Jul 6, 2021 at 11:50 AM Uwe Kleine-König
> <[e-mail]> wrote:
> >
> >  drivers/staging/fieldbus/anybuss/host.c   | 4 +---
> 
> Awesome !
> 
> Acked-by: Sven Van Asbroeck <[e-mail]>

I note that as an Ack for patch 4 only, as the others don't touch this
file.

Best regards
Uwe

Ulf Hansson July 8, 2021, 12:41 p.m. UTC | #5

On Tue, 6 Jul 2021 at 17:53, Uwe Kleine-König
<[e-mail]> wrote:
>
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>
> Acked-by: Russell King (Oracle) <[e-mail]> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <[e-mail]>
> Acked-by: Chen-Yu Tsai <[e-mail]> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <[e-mail]>
> Acked-by: Mauro Carvalho Chehab <[e-mail]> (for drivers/media)
> Acked-by: Hans de Goede <[e-mail]> (For drivers/platform)
> Acked-by: Alexandre Belloni <[e-mail]>
> Acked-By: Vinod Koul <[e-mail]>
> Acked-by: Juergen Gross <[e-mail]> (For Xen)
> Acked-by: Lee Jones <[e-mail]> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <[e-mail]> (For drivers/mcb)
> Acked-by: Johan Hovold <[e-mail]>
> Acked-by: Srinivas Kandagatla <[e-mail]> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <[e-mail]> (For drivers/vfio)
> Acked-by: Maximilian Luz <[e-mail]>
> Acked-by: Heikki Krogerus <[e-mail]> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <[e-mail]> (For ipack)
> Reviewed-by: Tom Rix <[e-mail]> (For fpga)
> Acked-by: Geoff Levand <[e-mail]> (For ps3)
> Signed-off-by: Uwe Kleine-König <[e-mail]>

Acked-by: Ulf Hansson <[e-mail]> # For MMC

[...]

Kind regards
Uffe