| Message ID | 20211227074529.1660398-1-xiaoning.wang@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | i3c: master: svc: some bug fixes and add runtime pm support | expand |
On Mon, 27 Dec 2021 15:45:21 +0800, Clark Wang wrote: > Currently, only the fourth patch needs to be reviewed, and the rest have been > added with your review tag. > > Thank you very much for your comments! :) > > V5 changes: > - i3c: master: svc: add support for slave to stop returning data > - remove <%s> in logs > - add some spaces > - !SVC_I3C_MSTATUS_STATE(reg) -> SVC_I3C_MSTATUS_STATE_IDLE(reg) > - i3c: master: svc: add runtime pm support > - create svc_i3c_master_prepare_clks() and svc_i3c_master_unprepare_clks() > > [...] Applied, thanks! [1/8] i3c: master: svc: move module reset behind clk enable commit: 57d8d3fc060c7337bc78376ccc699ab80162b7d5 [2/8] i3c: master: svc: fix atomic issue commit: a84a9222b2be2949f11f2d7c487052ac2afed4d4 [3/8] i3c: master: svc: separate err, fifo and disable interrupt of reset function commit: 9fd6b5ce8523460b024361a802f5e5738d2da543 [4/8] i3c: master: svc: add support for slave to stop returning data commit: d5e512574dd2eb06ace859b27cafb0de41743bb5 [5/8] i3c: master: svc: set ODSTOP to let I2C device see the STOP signal commit: 173fcb27210b18b38f1080f1c8f806e02cf8a53b [6/8] i3c: master: svc: add runtime pm support commit: 05be23ef78f76a741d529226a8764d81c719a1e3 [7/8] i3c: master: svc: add the missing module device table commit: c5d4587bb9a9a03b30bbc928b4a007fcd1f8c279 [8/8] i3c: master: svc: enable the interrupt in the enable ibi function commit: 7ff730ca458e841dbcdc87f264d7afe3eaed525e Best regards,
Hi Miquel, Currently, only the fourth patch needs to be reviewed, and the rest have been added with your review tag. Thank you very much for your comments! :) V5 changes: - i3c: master: svc: add support for slave to stop returning data - remove <%s> in logs - add some spaces - !SVC_I3C_MSTATUS_STATE(reg) -> SVC_I3C_MSTATUS_STATE_IDLE(reg) - i3c: master: svc: add runtime pm support - create svc_i3c_master_prepare_clks() and svc_i3c_master_unprepare_clks() V4 changes: - New patches: - i3c: master: svc: separate err, fifo and disable interrupt of reset function - i3c: master: svc: add the missing module device table - i3c: master: svc: enable the interrupt in the enable ibi function - i3c: master: svc: add support for slave to stop returning data - Only use COMPLETE flag in the read function. - Add a reset before each transfer. - i3c: master: svc: add runtime pm support - error path emit_stop only used in svc_i3c_master_do_daa() for one time, so remove it. Or it needs another goto command at the end of the function to skip it and to go to rpm_out. V3 changes: - i3c: master: svc: add runtime pm support: - restore the error path of probe function - enable runtime pm just before i3c module reset V2 changes: - align the parameters of the function in the second patch - add a new patch to support runtime PM. Clark Wang (8): i3c: master: svc: move module reset behind clk enable i3c: master: svc: fix atomic issue i3c: master: svc: separate err, fifo and disable interrupt of reset function i3c: master: svc: add support for slave to stop returning data i3c: master: svc: set ODSTOP to let I2C device see the STOP signal i3c: master: svc: add runtime pm support i3c: master: svc: add the missing module device table i3c: master: svc: enable the interrupt in the enable ibi function drivers/i3c/master/svc-i3c-master.c | 341 ++++++++++++++++++++-------- 1 file changed, 250 insertions(+), 91 deletions(-)