| Message ID | 1565548386-4485-1-git-send-email-wenwen@cs.uga.edu (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7afe9a4e56658bd659660ea10671831664469e5f |
| Headers | show |
| Series | i3c: master: fix a memory leak bug | expand |
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index d6f8b03..562f69f 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1084,8 +1084,10 @@ static int i3c_master_getmwl_locked(struct i3c_master_controller *master, if (ret) goto out; - if (dest.payload.len != sizeof(*mwl)) - return -EIO; + if (dest.payload.len != sizeof(*mwl)) { + ret = -EIO; + goto out; + } info->max_write_len = be16_to_cpu(mwl->len);
In i3c_master_getmwl_locked(), the buffer used for the dest payload data is allocated using kzalloc() in i3c_ccc_cmd_dest_init(). Later on, the length of the dest payload data is checked against 'sizeof(*mwl)'. If they are not equal, -EIO is returned to indicate the error. However, the allocated buffer is not deallocated on this path, leading to a memory leak. To fix the above issue, free the buffer before returning the error. Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> --- drivers/i3c/master.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)