| Message ID | 20191217120150.2134326-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 026d8450d499904f4712676e2149cdb758d0a601 |
| Headers | show |
| Series | i3c: make 'i3c_bus_set_mode' static | expand |
Hello Ben, On Tue, 17 Dec 2019 12:01:50 +0000 "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk> wrote: > The function i3c_bus_set_mode() is not declared or > exported, so make it static to avoid the following > warning: > > drivers/i3c/master.c:530:5: warning: symbol 'i3c_bus_set_mode' was not declared. Should it be static? > > If it is needed in the future, then it should be declared > and suitably exported. > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> Thanks for this patch, but I already a similar fix [1]. Regards, Boris [1]https://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git/commit/?h=i3c/next&id=026d8450d499904f4712676e2149cdb758d0a601 > --- > Cc: Boris Brezillon <bbrezillon@kernel.org> > Cc: linux-i3c@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/i3c/master.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 043691656245..7f8f896fa0c3 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -527,8 +527,8 @@ static const struct device_type i3c_masterdev_type = { > .groups = i3c_masterdev_groups, > }; > > -int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, > - unsigned long max_i2c_scl_rate) > +static int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, > + unsigned long max_i2c_scl_rate) > { > struct i3c_master_controller *master = i3c_bus_to_i3c_master(i3cbus); >
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 043691656245..7f8f896fa0c3 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -527,8 +527,8 @@ static const struct device_type i3c_masterdev_type = { .groups = i3c_masterdev_groups, }; -int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, - unsigned long max_i2c_scl_rate) +static int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, + unsigned long max_i2c_scl_rate) { struct i3c_master_controller *master = i3c_bus_to_i3c_master(i3cbus);
The function i3c_bus_set_mode() is not declared or exported, so make it static to avoid the following warning: drivers/i3c/master.c:530:5: warning: symbol 'i3c_bus_set_mode' was not declared. Should it be static? If it is needed in the future, then it should be declared and suitably exported. Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/i3c/master.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)