| Message ID | 20210127040636.1535722-1-davidgow@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency | expand |
On Tue, 26 Jan 2021, David Gow wrote: > The MIPI i3c HCI driver makes use of IOMEM functions like > devm_platform_ioremap_resource(), which are only available if > CONFIG_HAS_IOMEM is defined. > > This causes the driver to be enabled under make ARCH=um allyesconfig, > even though it won't build. > > By adding a dependency on HAS_IOMEM, the driver will not be enabled on > architectures which don't support it. > > Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver") > Signed-off-by: David Gow <davidgow@google.com> Acked-by: Nicolas Pitre <npitre@baylibre.com> > --- > drivers/i3c/master/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i3c/master/Kconfig b/drivers/i3c/master/Kconfig > index e68f15f4b4d0..afff0e2320f7 100644 > --- a/drivers/i3c/master/Kconfig > +++ b/drivers/i3c/master/Kconfig > @@ -25,6 +25,7 @@ config DW_I3C_MASTER > config MIPI_I3C_HCI > tristate "MIPI I3C Host Controller Interface driver (EXPERIMENTAL)" > depends on I3C > + depends on HAS_IOMEM > help > Support for hardware following the MIPI Aliance's I3C Host Controller > Interface specification. > -- > 2.30.0.280.ga3ce27912f-goog > > > -- > linux-i3c mailing list > linux-i3c@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-i3c >
On Tue, 26 Jan 2021 20:06:37 -0800, David Gow wrote: > The MIPI i3c HCI driver makes use of IOMEM functions like > devm_platform_ioremap_resource(), which are only available if > CONFIG_HAS_IOMEM is defined. > > This causes the driver to be enabled under make ARCH=um allyesconfig, > even though it won't build. > > [...] Applied, thanks! [1/1] i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency commit: 9d909f1b1e91b4aa7d016ed14b7b76dbf2675414 Best regards,
diff --git a/drivers/i3c/master/Kconfig b/drivers/i3c/master/Kconfig index e68f15f4b4d0..afff0e2320f7 100644 --- a/drivers/i3c/master/Kconfig +++ b/drivers/i3c/master/Kconfig @@ -25,6 +25,7 @@ config DW_I3C_MASTER config MIPI_I3C_HCI tristate "MIPI I3C Host Controller Interface driver (EXPERIMENTAL)" depends on I3C + depends on HAS_IOMEM help Support for hardware following the MIPI Aliance's I3C Host Controller Interface specification.
The MIPI i3c HCI driver makes use of IOMEM functions like devm_platform_ioremap_resource(), which are only available if CONFIG_HAS_IOMEM is defined. This causes the driver to be enabled under make ARCH=um allyesconfig, even though it won't build. By adding a dependency on HAS_IOMEM, the driver will not be enabled on architectures which don't support it. Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver") Signed-off-by: David Gow <davidgow@google.com> --- drivers/i3c/master/Kconfig | 1 + 1 file changed, 1 insertion(+)