diff mbox series

i3c: Correct the macro module_i3c_i2c_driver

Message ID 20221205105413.937704-1-naveenkrishna.chatradhi@amd.com (mailing list archive)
State Accepted
Headers show
Series i3c: Correct the macro module_i3c_i2c_driver | expand

Commit Message

Chatradhi, Naveen Krishna Dec. 5, 2022, 10:54 a.m. UTC 
From: Naveen Krishna Chatradhi <nchatrad@amd.com>

Present definition for module_i3c_i2c_driver uses only the
1st argument i.e., struct i3c_driver.
Irrespective of CONFIG_I3C being enabled/disabled,
struct i2c_driver is never passed to module_driver()

Passing struct i2c_driver as the 4th argument works.

Signed-off-by: Akshay Gupta <Akshay.Gupta@amd.com>
Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
---
 include/linux/i3c/device.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alexandre Belloni Dec. 11, 2022, 8:22 p.m. UTC | #1 
On Mon, 5 Dec 2022 10:54:13 +0000, Naveen Krishna Chatradhi wrote:
> From: Naveen Krishna Chatradhi <nchatrad@amd.com>
> 
> Present definition for module_i3c_i2c_driver uses only the
> 1st argument i.e., struct i3c_driver.
> Irrespective of CONFIG_I3C being enabled/disabled,
> struct i2c_driver is never passed to module_driver()
> 
> [...]

Applied, thanks!

[1/1] i3c: Correct the macro module_i3c_i2c_driver
      commit: 01744ce9f07f0b76b0b2d30adba2a7c104f1ff2a

Best regards,
diff mbox series

Patch

diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
index 8242e13e7b0b..419192b5cc4d 100644
--- a/include/linux/i3c/device.h
+++ b/include/linux/i3c/device.h
@@ -287,7 +287,8 @@  static inline void i3c_i2c_driver_unregister(struct i3c_driver *i3cdrv,
 #define module_i3c_i2c_driver(__i3cdrv, __i2cdrv)	\
 	module_driver(__i3cdrv,				\
 		      i3c_i2c_driver_register,		\
-		      i3c_i2c_driver_unregister)
+		      i3c_i2c_driver_unregister,	\
+		      __i2cdrv)
 
 int i3c_device_do_priv_xfers(struct i3c_device *dev,
 			     struct i3c_priv_xfer *xfers,