From patchwork Sat Mar 18 23:33:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13180479 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68136C7618A for ; Sun, 19 Mar 2023 17:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lhCvOnjccRfE0NROUmxhUIDoh0wkQbMS10WQsf9h8Co=; b=h1QHzeLM1RH3Tu dFDUIk2xh3VVOPHg5wpFupYjE9X+K7Ru557Jn/Ks1Ib+iZUi5RrmQ1P/BzIwBRwusnL17O25/MUT9 0XMZtc9G5wnKWnnsSV8Js2TdMfJ1rGFmZIOMdpvWkmw+DfldivR9e4umEFZiHkHOyqOTCx/OKe1eJ kwnG7mUCKgLNxj/S8b1yEdvWLvuTn9gJbHeNVmeCXXFg3bceEr0MENhcSgzGEIxYqaIRjQpHMSFJn Z4+X+J52q2952e3WhcjvsRRgknI2vGt9LvzuG6zOQy2JQpDyqmrfya6A0fB05GVjwG3zUMumfheFJ vw3ptrSuFFGE6xrlelFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdwVd-0074P3-1W; Sun, 19 Mar 2023 17:07:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdg3C-005ZUA-1t for linux-i3c@lists.infradead.org; Sat, 18 Mar 2023 23:33:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdg39-00026F-P5; Sun, 19 Mar 2023 00:33:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pdg39-0056V7-0L; Sun, 19 Mar 2023 00:33:23 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pdg37-005zQt-Pq; Sun, 19 Mar 2023 00:33:21 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Alexandre Belloni Cc: linux-i3c@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/5] i3c: dw: Convert to platform remove callback returning void Date: Sun, 19 Mar 2023 00:33:08 +0100 Message-Id: <20230318233311.265186-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> References: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1813; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=htTuUT4c/2CCmv0QHZ6AOTyXnCc1zupZ0qWEhfKT3Ow=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkFkouXH20m1uYEZXD20y2TttfZFqDt8qp8SzlO l89RghdcPOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBZKLgAKCRCPgPtYfRL+ Tlo7CAC7bYv+krow+fzsxEQdRKIMng3ol0TOBGvseQ2UVcptAjOHRGchXKZZZFleLWXJMm+lS04 zTzarw4pl05iJfBwxKgRbk7vP68QbuSH4Jq1MdSCmLLL1298pk2JJ/XrZI9xJCur1CBg6t1QmwW lt8PITNNSoWo2a4t7CVYl2Iic3x+J2q+nseLFPtcY2sqojHM3pf3whB+ttM6iBB2cm40NQAGWFV TuU2n9p2vcIs5XnaKx9LgWSNmOHPS2ebhwfmMM8AWifujeoYYxsDDyvZp1yv8jICeGaw9mkkVoe YLXtFpUN8GNBm87GnRsJPOmUCNjmrSdOtoFBehd+Pl+VWRwi X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i3c@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_163326_672771_2DE33E66 X-CRM114-Status: GOOD ( 15.66 ) X-Mailman-Approved-At: Sun, 19 Mar 2023 10:07:52 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/i3c/master/dw-i3c-master.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index 7135daada3e3..f5d3b7c04c88 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1182,7 +1182,7 @@ static int dw_i3c_probe(struct platform_device *pdev) return ret; } -static int dw_i3c_remove(struct platform_device *pdev) +static void dw_i3c_remove(struct platform_device *pdev) { struct dw_i3c_master *master = platform_get_drvdata(pdev); @@ -1191,8 +1191,6 @@ static int dw_i3c_remove(struct platform_device *pdev) reset_control_assert(master->core_rst); clk_disable_unprepare(master->core_clk); - - return 0; } static const struct of_device_id dw_i3c_master_of_match[] = { @@ -1203,7 +1201,7 @@ MODULE_DEVICE_TABLE(of, dw_i3c_master_of_match); static struct platform_driver dw_i3c_driver = { .probe = dw_i3c_probe, - .remove = dw_i3c_remove, + .remove_new = dw_i3c_remove, .driver = { .name = "dw-i3c-master", .of_match_table = of_match_ptr(dw_i3c_master_of_match),