From patchwork Sat Mar 18 23:33:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13180481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E348AC76195 for ; Sun, 19 Mar 2023 17:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yxpB+r8VhVA4t0OvVDNcRZ5XOZpfs/rLxcBVflSG7Og=; b=xSVHhy0TAwyxMZ wOwL/UytK+wkGXzY4IgeE2q21pHAW9vk14ZQsYhIVm26P4/GwrwEsRJ33fphW5zkeBWrl+0Vsa1w2 s17peqFbvVF9nwOF2Ol2k9MoNkRmVNhAL4jwL1ZtZe4ulKg0Xt8fzFqdtZWrhdDFq7YxRxM1xBgP/ ip/2Gg/zAE4Kz1ywXLX4wmrro3Jn7m7snAFs4yJpVDc85gCIVoQKc5Zi9mCZqllfDnc7m5dC0ZTXR WpCQ2bzSnj9ZMpCw3fDKkgAm4ONmnwsYHDkDko/VOAVga3kZuaajg2wGKuX2gI81kjk/vsIwPvSjO IVyrd2EI4+cm8CmLMotA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdwVe-0074PO-1o; Sun, 19 Mar 2023 17:07:54 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdg3C-005ZUF-1t for linux-i3c@lists.infradead.org; Sat, 18 Mar 2023 23:33:29 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdg39-00026G-R0; Sun, 19 Mar 2023 00:33:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pdg39-0056V8-11; Sun, 19 Mar 2023 00:33:23 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pdg38-005zQw-2m; Sun, 19 Mar 2023 00:33:22 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: =?utf-8?q?Przemys=C5=82aw_Gaj?= , Alexandre Belloni Cc: linux-i3c@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 3/5] i3c: cdns: Convert to platform remove callback returning void Date: Sun, 19 Mar 2023 00:33:09 +0100 Message-Id: <20230318233311.265186-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> References: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=8roCA0Odkx2Qe+8O5bBbJPRTbaX7hFvW3o6ZvVO0byw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkFkovGERkF8KP481dmK3ldmgOoNdksd3JAmxkL wfDgKrlfquJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBZKLwAKCRCPgPtYfRL+ Tv5YB/9SAcNUuhPrU9qTlmCd1ikg8AwS4zMuqd04M3JU/a6tfOEq/yDdt7OrUhwh9rpiAQAsnxY pp701cY0fJI5ltjz4KX3U5+Dbwyzs8F75sVeR03ElYZsPyiNILb7vxdExlH+lxNQd3KxGH7KGm7 VLOgyeycDQKz4aoj/65am08aGmLbfnVKM3hIPzlwmvxdNsG/2TvVW85QFQzIOpshUzisZXT4wmN 3p7fu56R//o7N+/+Q8B9Sdo1KSc00LkN8nS3YwT9uGOTnPziXl8+CeGGnkr8qTj9dPh8fL82/wc lWSqFFFS7VA0uexE3FOWorcas81qvzBP+0MtAiYVUHl175wR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i3c@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_163326_672914_4B2B9A57 X-CRM114-Status: GOOD ( 15.28 ) X-Mailman-Approved-At: Sun, 19 Mar 2023 10:07:52 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/i3c/master/i3c-master-cdns.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c index 454925c5e097..01610fa5b0cc 100644 --- a/drivers/i3c/master/i3c-master-cdns.c +++ b/drivers/i3c/master/i3c-master-cdns.c @@ -1662,7 +1662,7 @@ static int cdns_i3c_master_probe(struct platform_device *pdev) return ret; } -static int cdns_i3c_master_remove(struct platform_device *pdev) +static void cdns_i3c_master_remove(struct platform_device *pdev) { struct cdns_i3c_master *master = platform_get_drvdata(pdev); @@ -1670,13 +1670,11 @@ static int cdns_i3c_master_remove(struct platform_device *pdev) clk_disable_unprepare(master->sysclk); clk_disable_unprepare(master->pclk); - - return 0; } static struct platform_driver cdns_i3c_master = { .probe = cdns_i3c_master_probe, - .remove = cdns_i3c_master_remove, + .remove_new = cdns_i3c_master_remove, .driver = { .name = "cdns-i3c-master", .of_match_table = cdns_i3c_master_of_ids,