From patchwork Sat Mar 18 23:33:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13180480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92D4DC7618E for ; Sun, 19 Mar 2023 17:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lDPySDHInyvX7uc/saWi/oKc+53BgnecNRNUQyaFLiw=; b=jfIA5KICUtwZeR vEoRyvLom0UpjSx+y/umcYDOgYKcOA/Utq52rWg0CjA0EQdxtmT2T71sjOcAs71JLrLpcv7aV+wg7 cwuLpFz/4Pu8oarPRCpr3bnJiq+yIkxBoxInVShC3VR8nQfNxJ0YwSLf3z9dllvIwmu0cq5ZbDXrR OyGMh5lt10H8Mx6zWQtuy4SA6O7g+7M+IdXDURz2bao8qWLGEX0kGZ3PYDp4fevfoFU9fxxogxbbf Ed9zhCAdPxRHgSQASzt1MwwZVAyaecqpIHmrFYG/lU/+tFRnw8h7RoYL36Oc0pIhZ2x5dUoXDtePM YdVq5Da5rSdiF/SosCcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdwVd-0074P8-35; Sun, 19 Mar 2023 17:07:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdg3C-005ZUB-1t for linux-i3c@lists.infradead.org; Sat, 18 Mar 2023 23:33:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdg39-00026E-P6; Sun, 19 Mar 2023 00:33:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pdg38-0056V4-Tz; Sun, 19 Mar 2023 00:33:22 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pdg38-005zR0-9b; Sun, 19 Mar 2023 00:33:22 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Alexandre Belloni Cc: linux-i3c@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 4/5] i3c: mipi-i3c-hci: Convert to platform remove callback returning void Date: Sun, 19 Mar 2023 00:33:10 +0100 Message-Id: <20230318233311.265186-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> References: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1695; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=nsieFt6mg9CaybaICqixNjISERpRyQorI3iQO6kK0k4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkFkowfPkBNRUuGohmQbrKeNS+bStDp5DiRoswG yUIeOvxzGeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBZKMAAKCRCPgPtYfRL+ TuylB/4rJ66LT4wux88L1Ai06G/JzO8wnwNVG92+S+kp8+UwlaPVwdU+nSonBmHGYK/dkR854OY ynsoLRJi+8bFzVz0Venj3tojA89Pljhek0iiFC4i7kt9wgXq0OmRXxPn6si9ONbyo5meKj1n9hg nYq873Hwpz3+zIwhZXCWn3fGIfmzrqT3WQLR5ccS8jSln+OtkECTnbRaL++Q37+IFKqPTQEUkqU fyMtddJG2gMV9sk0pCrtuAbjIUDW6Pql+O9GYPo8uTHGq1HXHe91yCObMZ1GtwVo55WNY1+Oz1h OHM5VfYJ/B982myhA15bjF+WncqqISoAJDGEZ9V6/a/MaZ5l X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i3c@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_163326_672771_7BBD5100 X-CRM114-Status: GOOD ( 15.61 ) X-Mailman-Approved-At: Sun, 19 Mar 2023 10:07:52 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/i3c/master/mipi-i3c-hci/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c index f9bc58366a72..837af83c85f4 100644 --- a/drivers/i3c/master/mipi-i3c-hci/core.c +++ b/drivers/i3c/master/mipi-i3c-hci/core.c @@ -765,13 +765,11 @@ static int i3c_hci_probe(struct platform_device *pdev) return 0; } -static int i3c_hci_remove(struct platform_device *pdev) +static void i3c_hci_remove(struct platform_device *pdev) { struct i3c_hci *hci = platform_get_drvdata(pdev); i3c_master_unregister(&hci->master); - - return 0; } static const __maybe_unused struct of_device_id i3c_hci_of_match[] = { @@ -782,7 +780,7 @@ MODULE_DEVICE_TABLE(of, i3c_hci_of_match); static struct platform_driver i3c_hci_driver = { .probe = i3c_hci_probe, - .remove = i3c_hci_remove, + .remove_new = i3c_hci_remove, .driver = { .name = "mipi-i3c-hci", .of_match_table = of_match_ptr(i3c_hci_of_match),