From patchwork Sat Mar 18 23:33:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13180484 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE95BC761A6 for ; Sun, 19 Mar 2023 17:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hcrZolh8V+5bq8T5CBddmPXL8iMu5lpqa2Nu0RMRiJs=; b=TTaaIcswXhMczr OymgO8wx0MZFX4V144+ijiLjC1txijarQz5j1NJ6R+1MqUg/W58G8BSdc0lwSkCLZXTSDg6YdJNAe HIpFuRTbM226K80/QETjxGlIuLvfiQ/hpaqwNyBLTqEL8RNi1MrMCj2pEf75XJTvW84aKiS9rb0wd 50CVDcSImUbDxMZ6BRPHpK6gQlHsL16OpxD10MK12bbTGzz0GIY7NNAimR7Qj0Vtzag5NAB2xMCYF onJ1bx2SiXP12/KlblHs4kh9XV1/ywHpcoQ4lmV9BpbHsGf1n9BL/K60clij10SgOPwEHYfWcCKbd pGh507dOYg1gPkMFkV9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdwVe-0074PH-0o; Sun, 19 Mar 2023 17:07:54 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdg3D-005ZUP-0c for linux-i3c@lists.infradead.org; Sat, 18 Mar 2023 23:33:29 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdg3A-00026H-3p; Sun, 19 Mar 2023 00:33:24 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pdg39-0056VD-DB; Sun, 19 Mar 2023 00:33:23 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pdg38-005zR4-Fu; Sun, 19 Mar 2023 00:33:22 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Conor Culhane , Alexandre Belloni Cc: linux-i3c@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 5/5] i3c: svc: Convert to platform remove callback returning void Date: Sun, 19 Mar 2023 00:33:11 +0100 Message-Id: <20230318233311.265186-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> References: <20230318233311.265186-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1881; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=X1MRC8dZ6L3SY9IGorYLDJgu18rnXTtbRXFDOkbscEg=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhQxL8Md/hpp+5evtl9fKGT9fJLzvF9XPqhcNz1/cjb3g 3zXgonynYzGLAyMXAyyYoos9o1rMq2q5CI71/67DDOIlQlkCgMXpwBMZKI4+/8gw/X+1Qrqz9eE y2+e8j/SJuNiUZFaZqzwLo8VSUmtZqzGF0ryeyPDN3e1RT86ucMhM4GpukpGc4sgx5/5l5bOmCJ tPqU77oTR3b+32SSYtkW5rk/Pynj9keNb1W+NJ9EvEj/mebWbGHC+PB6bFdL52THOL4E1QtvvcK Alxzuj87Vyh/Wdtm6QY9RLd7q4Za9TqBib+43ZeTlPIgveCfmFfpnkELP6mKxM4gMZtfBTTm4zi /XcVtvuS9606urqMLm1UpkGusuSvJ8aZf9JOvxvzhu3BWzRT8qeqXdPF5k255THcymJexfky68p KLx/XnmCS9yP91JqJzv3d8aM+Ted5F1XTGpOjp/T9ZARAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i3c@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_163327_229466_86F1D225 X-CRM114-Status: GOOD ( 15.27 ) X-Mailman-Approved-At: Sun, 19 Mar 2023 10:07:52 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Miquel Raynal --- drivers/i3c/master/svc-i3c-master.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index e5476d04b403..e3f454123805 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1569,7 +1569,7 @@ static int svc_i3c_master_probe(struct platform_device *pdev) return ret; } -static int svc_i3c_master_remove(struct platform_device *pdev) +static void svc_i3c_master_remove(struct platform_device *pdev) { struct svc_i3c_master *master = platform_get_drvdata(pdev); @@ -1577,8 +1577,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev) pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev) @@ -1616,7 +1614,7 @@ MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); static struct platform_driver svc_i3c_master = { .probe = svc_i3c_master_probe, - .remove = svc_i3c_master_remove, + .remove_new = svc_i3c_master_remove, .driver = { .name = "silvaco-i3c-master", .of_match_table = svc_i3c_master_of_match_tbl,