| Message ID | 20230703053048.275709-2-matt@codeconstruct.com.au (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | I3C MCTP net driver | expand |
On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@codeconstruct.com.au> wrote: > > This property is used to describe a I3C bus with attached MCTP I3C > target devices. > > Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> > --- > Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml > index fdb4212149e7..08731e2484f2 100644 > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml > @@ -55,6 +55,10 @@ properties: > > May not be supported by all controllers. > > + mctp-controller: > + description: | > + Indicates that this bus hosts MCTP-over-I3C target devices. I have doubts you actually tested it - there is no type/ref. Also, your description is a bit different than existing from dtschema. Why? Aren't these the same things? Best regards, Krzysztof
On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote: > On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@codeconstruct.com.au> wrote: > > > > This property is used to describe a I3C bus with attached MCTP I3C > > target devices. > > > > Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> > > --- > > Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml > > index fdb4212149e7..08731e2484f2 100644 > > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml > > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml > > @@ -55,6 +55,10 @@ properties: > > > > May not be supported by all controllers. > > > > + mctp-controller: > > + description: | > > + Indicates that this bus hosts MCTP-over-I3C target devices. > > I have doubts you actually tested it - there is no type/ref. Also, > your description is a bit different than existing from dtschema. Why? > Aren't these the same things? Ah, I'll add $ref: /schemas/types.yaml#/definitions/flag I ran dt_binding_check andmake dt_binding_check \ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i3c/i3c.yaml ? > > Best regards, > Krzysztof >
On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote: > On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@codeconstruct.com.au> wrote: > > > > This property is used to describe a I3C bus with attached MCTP I3C > > target devices. > > > > Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> > > --- > > Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml > > index fdb4212149e7..08731e2484f2 100644 > > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml > > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml > > @@ -55,6 +55,10 @@ properties: > > > > May not be supported by all controllers. > > > > + mctp-controller: > > + description: | > > + Indicates that this bus hosts MCTP-over-I3C target devices. > > I have doubts you actually tested it - there is no type/ref. Also, > your description is a bit different than existing from dtschema. Why? > Aren't these the same things? (sorry my reply minutes ago was somehow an old draft, please ignore) Ah, I'll add $ref: /schemas/types.yaml#/definitions/flag Testing with make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml I don't see any warnings, and neither after adding mctp-controller to a .dts (out of tree) and testing with make CHECK_DTBS=y DT_SCHEMA_FILES=i3c.yaml aspeed-test.dtb Should that pick it up? For the description, do you mean it differs to the other properties in i3c.yaml, or something else? Thanks, Matt
On 03/07/2023 10:14, Matt Johnston wrote: > On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote: >> On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@codeconstruct.com.au> wrote: >>> >>> This property is used to describe a I3C bus with attached MCTP I3C >>> target devices. >>> >>> Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> >>> --- >>> Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml >>> index fdb4212149e7..08731e2484f2 100644 >>> --- a/Documentation/devicetree/bindings/i3c/i3c.yaml >>> +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml >>> @@ -55,6 +55,10 @@ properties: >>> >>> May not be supported by all controllers. >>> >>> + mctp-controller: >>> + description: | >>> + Indicates that this bus hosts MCTP-over-I3C target devices. >> >> I have doubts you actually tested it - there is no type/ref. Also, >> your description is a bit different than existing from dtschema. Why? >> Aren't these the same things? > > (sorry my reply minutes ago was somehow an old draft, please ignore) > > Ah, I'll add > $ref: /schemas/types.yaml#/definitions/flag Although does not matter, but use the same as in dtschema. type: boolean > > Testing with > make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml > I don't see any warnings, and neither after adding mctp-controller to a .dts > (out of tree) and testing with > make CHECK_DTBS=y DT_SCHEMA_FILES=i3c.yaml aspeed-test.dtb > > Should that pick it up? > > For the description, do you mean it differs to the other properties in > i3c.yaml, or something else? It differs than existing mctp-controller property. If this was on purpose, please share a bit more why. If not, maybe use the same description? Best regards, Krzysztof
On Mon, 2023-07-03 at 16:16 +0200, Krzysztof Kozlowski wrote: > On 03/07/2023 10:14, Matt Johnston wrote: > > On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote: > > > On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@codeconstruct.com.au> wrote: > > > > > > > > + mctp-controller: > > > > + description: | > > > > + Indicates that this bus hosts MCTP-over-I3C target devices. > > > > > > I have doubts you actually tested it - there is no type/ref. Also, > > > your description is a bit different than existing from dtschema. Why? > > > Aren't these the same things? > > > > Ah, I'll add > > $ref: /schemas/types.yaml#/definitions/flag > > Although does not matter, but use the same as in dtschema. > type: boolean OK, thanks. > > For the description, do you mean it differs to the other properties in > > i3c.yaml, or something else? > > It differs than existing mctp-controller property. If this was on > purpose, please share a bit more why. If not, maybe use the same > description? The mctp-controller property has the same meaning as for I2C, so I'll use the existing I2C text for I3C as well. That will also be more suitable if in future Linux works as an I3C target device (currently it's controller only). "indicates that the system is accessible via this bus as an endpoint for MCTP over I3C transport." Thanks, Matt
diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml index fdb4212149e7..08731e2484f2 100644 --- a/Documentation/devicetree/bindings/i3c/i3c.yaml +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml @@ -55,6 +55,10 @@ properties: May not be supported by all controllers. + mctp-controller: + description: | + Indicates that this bus hosts MCTP-over-I3C target devices. + required: - "#address-cells" - "#size-cells"
This property is used to describe a I3C bus with attached MCTP I3C target devices. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> --- Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++ 1 file changed, 4 insertions(+)