| Message ID | 20230905213842.3035779-5-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | I3C Slave Mode support | expand |
On 05/09/2023 23:38, Frank Li wrote: > Add compatible string 'silvaco,i3c-slave-v1' for slave mode. > No, it's the same device. Anyway, this was not tested. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Wed, Sep 06, 2023 at 10:01:40AM +0200, Krzysztof Kozlowski wrote: > On 05/09/2023 23:38, Frank Li wrote: > > Add compatible string 'silvaco,i3c-slave-v1' for slave mode. > > > > No, it's the same device. > > Anyway, this was not tested. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. Thank you for your comments. I write notes at RFC cover letter, this patches is not totally completed yet. I want to get more feedback about i3c slave mode API and configfs design, which will impact the overall design. So I have not included tty mail list and you in review list. I send out all patches just because let i3c reviewer know how to use these API. Frank > > > Best regards, > Krzysztof >
On 07/09/2023 16:28, Frank Li wrote: > On Wed, Sep 06, 2023 at 10:01:40AM +0200, Krzysztof Kozlowski wrote: >> On 05/09/2023 23:38, Frank Li wrote: >>> Add compatible string 'silvaco,i3c-slave-v1' for slave mode. >>> >> >> No, it's the same device. >> >> Anyway, this was not tested. >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time, thus I will skip this patch entirely till you follow >> the process allowing the patch to be tested. >> >> Please kindly resend and include all necessary To/Cc entries. > > Thank you for your comments. I write notes at RFC cover letter, this > patches is not totally completed yet. I want to get more feedback about > i3c slave mode API and configfs design, which will impact the overall > design. > > So I have not included tty mail list and you in review list. > I send out all patches just because let i3c reviewer know how to use these > API. Other people send RFC and they, surprise, expect comments. Probably because RFC means Requests For Comments. If you do not expect comments, review, call it somehow else, like "BROKEN", so we will know to ignore it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index 133855f11b4f5..da8a2f358505a 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Silvaco I3C master +title: Silvaco I3C master/slave maintainers: - Conor Culhane <conor.culhane@silvaco.com> @@ -14,7 +14,10 @@ allOf: properties: compatible: - const: silvaco,i3c-master-v1 + const: + enum: + - silvaco,i3c-master-v1 + - silvaco,i3c-slave-v1 reg: maxItems: 1
Add compatible string 'silvaco,i3c-slave-v1' for slave mode. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)