| Message ID | 20230921082410.25548-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs | expand |
On Thu, 21 Sep 2023 16:24:10 +0800, Dinghao Liu wrote: > put_device() needs to be called on failure of device_register() > to give up the reference initialized in it to avoid refcount leak. > > Applied, thanks! [1/1] i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs commit: cab63f64887616e3c4e31cfd8103320be6ebc8d3 Best regards,
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 87283e4a4607..0e9ff5500a77 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1525,9 +1525,11 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master) desc->dev->dev.of_node = desc->boardinfo->of_node; ret = device_register(&desc->dev->dev); - if (ret) + if (ret) { dev_err(&master->dev, "Failed to add I3C device (err = %d)\n", ret); + put_device(&desc->dev->dev); + } } }
put_device() needs to be called on failure of device_register() to give up the reference initialized in it to avoid refcount leak. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/i3c/master.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)