From patchwork Thu Oct 19 22:27:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13429905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99C0AC00A98 for ; Thu, 19 Oct 2023 22:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=inXNQBgK2d6c2rpcYBz2jgatG6bBY7hG9ob405T9nNU=; b=aFkIEC0wyQcWLH x47xA+zmSzuNKuHS0mjXDIrGq3Rz15IJfwzB/lpCssOsgDeZsAFIwUfTRtBPddTICKlGhvErp8jkL FIw23vPLv8uSfXjlfcNr2ktFp8RuoyiuZcxJpP1NffRwG2lntbFfaaArMVblvC9ZjtPJBQuvc4pIU FtFf3GGIZM/H8c/pEJyTPeTc2hpifVF+FnmaERtPIDqWRpgVpAllXEM8XjrcglLD5Y/hUsVHlEmwK DsbURqNRZpFZekwU3ZJX43cfAo9e7/dpwacZDoHr9qE6OFATocLDBjsBwHy4kRa7NCmbKf4Y8IXBt 1QmNKgPHRUcyeACuxiSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtbUo-000o5b-0b; Thu, 19 Oct 2023 22:28:02 +0000 Received: from mail-am6eur05on20611.outbound.protection.outlook.com ([2a01:111:f400:7e1b::611] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtbUl-000o1V-0P for linux-i3c@lists.infradead.org; Thu, 19 Oct 2023 22:28:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKbOHy+o3VwCdz6G4CPqj3/ZEtGhNBkThMsBR+FKR0du7EAlHuy5O4GpUVujI3wXVYxDmrasfWD415z2SJvDFJAqN9yjdz8l3OSQExOVT7jcHxdI5QLEZQfSjsusszAnFVsYqSDYxqkswcVlxqglLj9cQw/+EXXirZnfyHVlNV6vzauSbMs3yAaYyQok0NntIyVmrCqawASPa7lTCOkqD17vzVwzuhfHrA7X05Uve58j8F/lLci33zos8C5/iZIc/IbVFwZyYHkXY9PUavYrot5moCl/3yjF+XdOc+iAqfbwVw5iFYTtBPDF+CP1/o/iuevPWJoVtnTvnYVdhnhj1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghMi/AjqmeuflsZPjowu1AoqUyQlM4/JO+IAd05K8m8=; b=LKa+Q+cIBBI4VOo8n+jXBuDCCEvgPX1ZxIym0ZI5GnpDKGn1FnhOoD9K2GFX4gvmjdOref1UVOM73i9owLZM84Qi5N/oxyWYre+Uu5qD0CoZXZwfbBtIy/Gmq280/kX9+UsboVOdAM1XFAg7hqnJac9IyH1OI2qGZuckG2ycEvwLC+uJ8PI2yittoxIxxNIDok6dAkq5Z7UPLupjRjVap0IhAYwX2J4SlPs/6PyOd4eD8NVPcvg4eRwPPrPScF13fzrRxSx6O/UNhLLAFVa4pffAdcod5AcfVClkN0iz4+VmXSYMo6iXr1Yg7VDxmZVHSXn5YQSrJ9vLib7Sx/TOCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghMi/AjqmeuflsZPjowu1AoqUyQlM4/JO+IAd05K8m8=; b=Tdiaah2yXz74YD/N5Cqwi/OB+DLbE472SGwRW8G4DBK5bCdefMFZNIzyq6ClRpeRbrsbYkoy9w9wWSVxbYsSCRUc4Ouzxk0enJTQ6BnzXEl1PxJB0dCmI+tdFCP1AxhoQoYp62LiJ4A6CewYl/GNMQkq98/gLOac+GaYtI/atKA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by DBBPR04MB7708.eurprd04.prod.outlook.com (2603:10a6:10:20d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.10; Thu, 19 Oct 2023 22:27:51 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Thu, 19 Oct 2023 22:27:51 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/6] i3c: master: svc: fix check wrong status register in irq handler Date: Thu, 19 Oct 2023 18:27:23 -0400 Message-Id: <20231019222725.3598022-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231019222725.3598022-1-Frank.Li@nxp.com> References: <20231019222725.3598022-1-Frank.Li@nxp.com> X-ClientProxiedBy: PH7PR17CA0042.namprd17.prod.outlook.com (2603:10b6:510:323::21) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|DBBPR04MB7708:EE_ X-MS-Office365-Filtering-Correlation-Id: b8d65c76-b00d-4f54-353f-08dbd0f2a135 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mTZ6lEItdrFHmEZu+5m6mBF8BlYcmFPwlP3p9xc+cyzpL3T6Dnr7OcS2BGB30+fB+LExQ02+iSHqcSSCD9BgVjZqH/yZ3qfP0tHLtG/wkj1SqkkAzV97ih5gTlTPQsNVJ0KO2dZNeX4f3yl+5jBx3jErA8IOzjJdgYTdtVkrJtTVC87DL11gnriEiFECQqPW7MxpCf/ZsiCefFvdYFbpBP40lpV6X9g96+vGgfOl9NeJCCIIIPkP/FW4MAJUfRlfCSOqnXvof6PFMCSIMnKatYJRcl/luSZEZnhPAyVmkZ4LpMRSaWTlCCsS078135h80CMohdKzrUVTa234fr/R6rX2N3yT0mGFOTKY4xDKPTn5pXDU8RGqnuAO8OlJ44xQktw1rGWywIgLzL80EyhqgJs2opOI1rCvS6n7RAqqYCgF4n/DD3JrUH5CPnvOc/3zspqv8wjOEesZED6wyFK9mbnryrHoqamrO96RP6mmBczE34Wrfg9AIJeR83rLCzGvSKA5WP8AuFtSleYGyCPKH9tn8D4HkKM5r5mWcf7xgRl7n17yHynNd6evseq86e2pi8iCbAXTCLouzL6YkQ846tRBDmicQsBNFKqVJRkRzdWP/xYGijMqyF4lbsQwCFSxemSdm//+I5/8mrVElfc/EhB3Ms+x1MYnCkUtqXxHWR0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(366004)(346002)(39860400002)(376002)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(6506007)(83380400001)(6512007)(38100700002)(478600001)(36756003)(66476007)(66556008)(66946007)(316002)(6916009)(86362001)(6486002)(52116002)(2616005)(1076003)(26005)(6666004)(5660300002)(2906002)(41300700001)(8676002)(8936002)(4326008)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g3RXzKyWyGbdomcsJaPgK+NIvibljavZG3h0HhdHuMb8YN4Hk9tSpuLmPin3e1Vycs+dW/ZHC2AmX+/yTHTJw5m/hmt+SejgDn4Xb5CKqi9XZrlhw3jyYTJkmfUJdnq7fsPP1kVK10AbC1/+iwWr/Gl8npp8I+skjWwFA33UBf4THLaGkb8pdADWZqWtdwJm7pQYVgqaQD867FdW8KaMWHa54r+n3VmLZYG2Q1/gMRQw9O93hGi4LBL0n4hUPOhZip4LX1n+ywEBxvjaON3805aZVUBsR5zYmCnT6JlYxxXBegSICZl6NzKjow+du83dAy04FS0HNq217KJ3+7sVe1VI9koO9zFo4ZZGtp1XkdTMCzPftgG/LQ+2j1ILq7F4gCr8G2rtLUiiWden4Y48gi4KRHItAJ+7kqBDwk14oiNsh8rNJ5rXGKuYLC/F8bD1wpovzs0YnlcErm47/UeOgeWjcH2C8cNc8u88n9h4YZW8sY38Sm/kWAwkRzkvIzMkkZS8CpVgAjPSYHx+IwLc2Ok+two3+/CcgsEdQyoY4B+tJQVJhdw2TxXjnPWwvWQZZ7AcCVfSjxGnbuMDNCgn0dXobwhq15fB2XreTwwj+1mURTwGqtuI2nw6nLKZiMkyoJMz9jCH677BNv5c3T3MNIXpIz6xhY6SovRtSGD9QQk5mApHrnkvyeJgoTZoIWNwTHudZeQwu+X4CcEYah4kOlWSOPqEXmf6OLU2bk3ofrnumCm+UEjb2pp2Vsw52BCpQV4OmbYQI6wnIIlZTKduTUTczhcqoBIWVNYBuPbnvFYGDXZIKL+l0oeS1zEtVd/TlrISzLog0o0seXlGvkb+tSgqJmM/wBspXyShBDRjUOt6VuLlLMJOa4VcTfVmd0BE4YBjmdehs9A8pHWbHblHzxpPtjLPXjyDmqTcNfu3pRfGAxvbcv/6/7S3viOgD3qLm/7vrDYPQlax4zuacfSFM+2XxYUUrogaWso8gAUXFtNxBP9tsCd7wdjMRqZROrJ4K9m/gNJFLDYyI/2/4HHsHm6hLCd/26jC1IHYgtruzEJxm3ZjLEhA5P/epNdMtXeIjICQooyVU3y2y/oaJfLfvPdIo8tZ4DsUjJ6qFq5+RP2huaVr7xTX3V01rZ7OqY8qNsCNp0wVFS3N0DUFaa7th3o1wAxxWNzjV+re0HSz6k3UcI7d3LcKAVKRLeLCJKC6qmOvkKwEHGiXB+b8Nl4cTp41S7riB0kLBIlFuCH6ECeAcc0P8Wuz5NGiCyxC2hh0Gzz/mhbHRjBRQWIAKSEVSZLFRdKC9ogSE7u9ZjNS9axdLkEdBBtLDUrTDwUkkCM8Iac5mw6RaOsU1Py7ztaMhO53MQQ6m5+19h8J9BDH8h7kLFjI6tLFjpj/mrXYXJ23DtcH3G+Gb5hOuu01f4e0ZjAbbzgWTqNbvSdgIdu9AbiZ+8GyruCu4+dwZEGaafyAeiy1zunB8J/9aJTBjuzaxogN4pmd2sAhWQmgvi7MPUzqv7FUsmtsU3w915e8uGVdM/WFe55BG2ePHFl7BhSp0c5dCtdyz75lZ8JgKq6cFRTWZbzFnSIMOJu6uBUnzDBi X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8d65c76-b00d-4f54-353f-08dbd0f2a135 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 22:27:51.1204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AA2YbLLQv4FwuwezwivnpX1Hl7M34lta86SY/+4Au/KRK4VYkBikaVI0PZdqg6lhjUAtsol6+PaXOiyB9zKDxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7708 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_152759_161670_CFBC4CAC X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org svc_i3c_master_irq_handler() wrong check register SVC_I3C_MINTMASKED. It should be SVC_I3C_MSTATUS. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - Add Reviewed-by: Miquel Raynal drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index dd06b7c9333f1..b113460f059c3 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -476,7 +476,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) { struct svc_i3c_master *master = (struct svc_i3c_master *)dev_id; - u32 active = readl(master->regs + SVC_I3C_MINTMASKED); + u32 active = readl(master->regs + SVC_I3C_MSTATUS); if (!SVC_I3C_MSTATUS_SLVSTART(active)) return IRQ_NONE;