From patchwork Wed Jul 24 07:12:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shyam Sundar S K X-Patchwork-Id: 13740633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B66C0C3DA70 for ; Wed, 24 Jul 2024 07:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uFZB32x35ceBL5oULqPU8AV51dUYH52YvrftAZFitiE=; b=pyY+/5rvrs2pD6 Xrnxz00xEbjpS3IV9knzRr2pb+xQ2qKYr55iAu9vvJdEC//RZf9WYmqXv6aOBjDs/MjNOx2lRki4i boMctpWAq2nOmjejaYSpQrggmX9x2hvcqcefBJyC+HBtjtXXlZuFFRW+T0mJTYeL2bU0gj/9JGQ62 gKqdCM9xgZEwyFDQA5m8+yjIfDAt65cc2wuseNjfq9BwIfvyXJ7BO5SzjQyq7QFxeKMB/tb6EY/zS 8ZO5XDT8hQje9ASoa88G0FoCQRzayjB/pdI1kjBRRSxtYcVEwydZ/j/hYp7H5hHfkVzUKWnQfzDCb jYjrW9viIX7EjIe/o4sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWWBu-0000000Eave-1ZOP; Wed, 24 Jul 2024 07:13:38 +0000 Received: from mail-bn8nam04on20627.outbound.protection.outlook.com ([2a01:111:f403:2408::627] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWWBs-0000000EatY-0BMm for linux-i3c@lists.infradead.org; Wed, 24 Jul 2024 07:13:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tUF1v/8hhYvwYzQ7k5KHRL7DWBLcJpch3ObGtXfns6j/ZosG71pUKaP0J9y6bqhaXw0qPP1zTQYIBRsUfSgsPEABhOUykIi02l95VHyj3joJq/EFomHYJiSYXyWbkFxTKx3XxM6+4bftQXOOpsxVe4vJalE/6cSQS8nWlsjU7QV+oprhdQD4EjnFSEabvyawLJPVXGwdGaVtE0JWirkrUkb5p2ftIqpDmMyvho9HksC1Szy5uYiEy8CtYN0Ts7UV8vduhu2gNhRhT5YzKprKda8PCZDc00TFZXFZouwXG4hm+3+mt1Xj+ahSnEDItr+G9peGiLGCE373VodksmNcDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2BX+ubpi5nc8ZdodDNt+PTNMYOgWjtHE5x6tQF/zgCs=; b=szBeYdJWh8H6v6Cddzw3tozw3v3rl3SBaxbprj4bUz5otUhgofyma6M6w143lKsshsW0GCf1yZUUTIAXMz2+eWNM+sRXd1vKCghhq013NECXzGhH9Q6Zg7g65+aj8JUeevhDBBWWPjEqu0hqHVLl57FR1Ndi3SDH3a7qSmep7mcYsWazQZ1qtKRPNqtdZ7QOMxt194m3hVWcgLXuJh1qw1qPEnhxQhg8u1A4EsYBRjilOelOpeta2NfmOj0tJLt0Wh3VjkHuPzHq3QzgpeAHsByKYs7jMmWC0uZursBYiGak2Y9MhuMbPHneBEaVr0ft3j13/i/OMK8nSja7QgP1Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bootlin.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2BX+ubpi5nc8ZdodDNt+PTNMYOgWjtHE5x6tQF/zgCs=; b=M2M2lhncFoWp70koVovoZ0rR4AEqi04N/Ql30UYkMnxZymytXfD/TcdBZdsUf73c7/XPxFbra/rA0Z/7egBEZ937gYfuD1GLsRi7IVk4FJwhxMiQjEz/CkpzDVC4OwQBZHQSfHozMA5vSEXJbaG1v3nNgvrGYSC0AoTZa/ryJeA= Received: from SJ0PR13CA0120.namprd13.prod.outlook.com (2603:10b6:a03:2c5::35) by CH3PR12MB8512.namprd12.prod.outlook.com (2603:10b6:610:158::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.35; Wed, 24 Jul 2024 07:13:30 +0000 Received: from SJ5PEPF000001D2.namprd05.prod.outlook.com (2603:10b6:a03:2c5:cafe::6f) by SJ0PR13CA0120.outlook.office365.com (2603:10b6:a03:2c5::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20 via Frontend Transport; Wed, 24 Jul 2024 07:13:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001D2.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7784.11 via Frontend Transport; Wed, 24 Jul 2024 07:13:29 +0000 Received: from jatayu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 24 Jul 2024 02:13:26 -0500 From: Shyam Sundar S K To: Alexandre Belloni , Jarkko Nikula CC: Guruvendra Punugupati , Krishnamoorthi M , , , Shyam Sundar S K Subject: [PATCH v2 3/5] i3c: mipi-i3c-hci: Relocate helper macros to HCI header file Date: Wed, 24 Jul 2024 12:42:43 +0530 Message-ID: <20240724071245.3833404-4-Shyam-sundar.S-k@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240724071245.3833404-1-Shyam-sundar.S-k@amd.com> References: <20240724071245.3833404-1-Shyam-sundar.S-k@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D2:EE_|CH3PR12MB8512:EE_ X-MS-Office365-Filtering-Correlation-Id: 90ebb878-3235-4f9c-b86c-08dcabb01e7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: 8dmIFSTFe0LybAk2+Dv7TibLz0/Vzd9zIUJIZW+6zBOQedyTdK5pE3VcA/XCQXEJsvc3c9eGHuN+PpsdBzMFTSzvRgE1TrGwvGKqWbdUH0btE6u8q2YCoADNTWDy4S7R8X4SvROLrMv5c8+rAs1ZKuJrl13y/7e9AoUyaFO5G3bFP/f7PcWaVZvOxc+tFYEphKbLsdJX9vD2z9vae29LRnDbObjOKn4qT7Jm2BPHyoSwwMEBikg0OUln/KHUZHfnef8rCYSH6nF00adCPOu9sLSC37dnjbIVJeHjlvFXEJasT2A/PrRIz2+/Fz/jTdU2jUgqGDI/jOsbjNi7BVPLjmM/gIAvxC8BKTY42oEvMYXqE8gUalMZIlnjQ9T6LjJMzyMFvZsh1I7EFB3JKkRdXuLSw1vjhJC8btS/roYdPWgGt+j5HElaSCMCgLptUAQltXONIawZzM/mUb7kl/fF2i7jXI8Oe0nWzu6Auzv396+9iAhkz9DD908emt638G1JMvAAalRaVFnv2wR8YmAIGD35owvT3Fg521UmDmfozMK5shC//iOcZoWBwsN/YUIwpmQfzHr+NPES41G5qqEpDz7+MDZR/rVYDuXV/DjeWgHpM/G/tQrjmGCxZ7+yOAx0pyggc9T00B1iWKgi4rUzq+UroYPp43SGKwG79+aS/kWkrALojlLICEYe1JrJa58VQTYm8pE2P8Kwcd3kXQ2bb0rAkIm5Cw8SQ9FJaaAk04vzN4WhshCUc6aD99/1TrMImYL6/0GlDevcxQQKe7YmYp3LlSLcCAaeZXv9loo2cRo6AWCmjPFxSgZn1w8tLx3g7YfEDDZgh//5abxg4/FA9509Edqsmz25NCCXf+t/mkN6cFJ7ebFitGoee5FLejOn4/YgU5mFuGWu84MrNqCKL5j/mPl1SSsQ/omD7qha2+fA8ymOtUoJRf+0s6nwW3y0rAWkuKloJECsOgWkRvu/9qR3gCmPVUClp9gDIFzGd6UUZwJss+g+EkcgioWyLdI+J5QWJSv0tj+N3ubYrScDguaiOk42uJ+Oy1l9XkTVsKkGe/qSFPDYjsuUgm8xSCHIZ2GgNdrXvPNRusV1wiADekTyGQykzjVTXXjUtcV0jr8hzhqKAuklnTP+MC11CdhJsthXjuDCAk1HzcNHyPVZ5hDOkwJ+zK8qwiPFTEjEMBj401CfYKMe9sp2rqa9RYZ5k9Zj4EdOUmCfo7Yj2e/R4cmZgSISuH/e5C98RZZK6Urx/kWq6yiuzxqW4O4ow36LDSElCAFZ1nZUL4s/odB71PvzFPxCw4Y79PrEOOrgZI7rVU8tI4ddjzTU81OgfOKcja7R8R65u4GTrr56wMzYt2eWifZmT7m1tluFKrgU33eB1BqcwanKS0QdamUe3G1iucz9NZweS2xYjx21HDfhE2IfT2aZSyQGIJffdz5QlYWrCKbDxVNIQEnGZBKbTnv0 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 07:13:29.2485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90ebb878-3235-4f9c-b86c-08dcabb01e7f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8512 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_001336_107874_0CB72456 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The reg_* helper macros are currently limited to core.c. Moving them to hci.h will allow their functionality to be utilized in other files outside of core.c. Co-developed-by: Guruvendra Punugupati Signed-off-by: Guruvendra Punugupati Signed-off-by: Shyam Sundar S K --- drivers/i3c/master/mipi-i3c-hci/core.c | 6 ------ drivers/i3c/master/mipi-i3c-hci/hci.h | 5 +++++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c index 8bb422ab1d01..ca9d4e2c80e6 100644 --- a/drivers/i3c/master/mipi-i3c-hci/core.c +++ b/drivers/i3c/master/mipi-i3c-hci/core.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -27,11 +26,6 @@ * Host Controller Capabilities and Operation Registers */ -#define reg_read(r) readl(hci->base_regs + (r)) -#define reg_write(r, v) writel(v, hci->base_regs + (r)) -#define reg_set(r, v) reg_write(r, reg_read(r) | (v)) -#define reg_clear(r, v) reg_write(r, reg_read(r) & ~(v)) - #define HCI_VERSION 0x00 /* HCI Version (in BCD) */ #define HCI_VERSION_V1 0x100 /* MIPI HCI Version number V1.0 */ diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h index 046b65d43e63..8e5af4e55de1 100644 --- a/drivers/i3c/master/mipi-i3c-hci/hci.h +++ b/drivers/i3c/master/mipi-i3c-hci/hci.h @@ -10,6 +10,7 @@ #ifndef HCI_H #define HCI_H +#include /* Handy logging macro to save on line length */ #define DBG(x, ...) pr_devel("%s: " x "\n", __func__, ##__VA_ARGS__) @@ -26,6 +27,10 @@ #define W2_BIT_(x) BIT((x) - 64) #define W3_BIT_(x) BIT((x) - 96) +#define reg_read(r) readl(hci->base_regs + (r)) +#define reg_write(r, v) writel(v, hci->base_regs + (r)) +#define reg_set(r, v) reg_write(r, reg_read(r) | (v)) +#define reg_clear(r, v) reg_write(r, reg_read(r) & ~(v)) struct hci_cmd_ops;