diff mbox series

[-next] i3c: master: cdns: fix module autoloading

Message ID 20240826123957.379212-1-liaochen4@huawei.com (mailing list archive)
State Accepted
Headers show
Series [-next] i3c: master: cdns: fix module autoloading | expand

Commit Message

Liao Chen Aug. 26, 2024, 12:39 p.m. UTC
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/i3c/master/i3c-master-cdns.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mukesh Kumar Savaliya Aug. 29, 2024, 6:39 a.m. UTC | #1
On 8/26/2024 6:09 PM, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>   drivers/i3c/master/i3c-master-cdns.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> index c1627f3552ce..ee555255f1a2 100644
> --- a/drivers/i3c/master/i3c-master-cdns.c
> +++ b/drivers/i3c/master/i3c-master-cdns.c
> @@ -1562,6 +1562,7 @@ static const struct of_device_id cdns_i3c_master_of_ids[] = {
>   	{ .compatible = "cdns,i3c-master", .data = &cdns_i3c_devdata },
>   	{ /* sentinel */ },
>   };
> +MODULE_DEVICE_TABLE(of, cdns_i3c_master_of_ids);
>   
why not to use i3c as type instead of "of" ? Just curious, if it makes 
sense.
>   static int cdns_i3c_master_probe(struct platform_device *pdev)
>   {
Alexandre Belloni Sept. 5, 2024, 4:46 p.m. UTC | #2
On Mon, 26 Aug 2024 12:39:57 +0000, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
> 
> 

Applied, thanks!

[1/1] i3c: master: cdns: fix module autoloading
      https://git.kernel.org/abelloni/c/133f67bea5e0

Best regards,
diff mbox series

Patch

diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
index c1627f3552ce..ee555255f1a2 100644
--- a/drivers/i3c/master/i3c-master-cdns.c
+++ b/drivers/i3c/master/i3c-master-cdns.c
@@ -1562,6 +1562,7 @@  static const struct of_device_id cdns_i3c_master_of_ids[] = {
 	{ .compatible = "cdns,i3c-master", .data = &cdns_i3c_devdata },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, cdns_i3c_master_of_ids);
 
 static int cdns_i3c_master_probe(struct platform_device *pdev)
 {