| Message ID | 20240829091713.736217-2-Shyam-sundar.S-k@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Introduce initial AMD I3C HCI driver support | expand |
On Thu, Aug 29, 2024 at 02:47:08PM +0530, Shyam Sundar S K wrote: > The current driver code lacks the necessary plumbing for ACPI IDs, > preventing the mipi-i3c-hci driver from being loaded on x86 > platforms that advertise I3C ACPI support. > > Add the AMDI5017 ACPI ID to the list of supported IDs. ... > static struct platform_driver i3c_hci_driver = { > .probe = i3c_hci_probe, > .remove_new = i3c_hci_remove, > .driver = { > .name = "mipi-i3c-hci", > .of_match_table = of_match_ptr(i3c_hci_of_match), A side note (not sure if it anyhow might be related to your kernel configurations and builds): There is an ongoing activity to kill of_match_ptr() for good (as it's more harmful than useful). It _might_ be that in ACPI only kernel configurations dangling i3c_hci_of_match appears which compiler will warn about. > + .acpi_match_table = i3c_hci_acpi_match, > }, > };
On 8/29/24 12:17 PM, Shyam Sundar S K wrote: > The current driver code lacks the necessary plumbing for ACPI IDs, > preventing the mipi-i3c-hci driver from being loaded on x86 > platforms that advertise I3C ACPI support. > > Add the AMDI5017 ACPI ID to the list of supported IDs. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > --- > drivers/i3c/master/mipi-i3c-hci/core.c | 7 +++++++ > 1 file changed, 7 insertions(+) > Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c index 4e7d6a43ee9b..07de1cecfa30 100644 --- a/drivers/i3c/master/mipi-i3c-hci/core.c +++ b/drivers/i3c/master/mipi-i3c-hci/core.c @@ -834,12 +834,19 @@ static const __maybe_unused struct of_device_id i3c_hci_of_match[] = { }; MODULE_DEVICE_TABLE(of, i3c_hci_of_match); +static const struct acpi_device_id i3c_hci_acpi_match[] = { + { "AMDI5017" }, + {} +}; +MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match); + static struct platform_driver i3c_hci_driver = { .probe = i3c_hci_probe, .remove_new = i3c_hci_remove, .driver = { .name = "mipi-i3c-hci", .of_match_table = of_match_ptr(i3c_hci_of_match), + .acpi_match_table = i3c_hci_acpi_match, }, }; module_platform_driver(i3c_hci_driver);