| Message ID | 33ba7e13816fcece0a2f7ec917c18807359c16c7.1555354268.git.vitor.soares@synopsys.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add ST lsm6dso i3c suppport | expand |
On Mon, 15 Apr 2019 21:19:40 +0200 Vitor Soares <vitor.soares@synopsys.com> wrote: > This helper return the i3c_device_id structure in order the client > have access to the driver data. > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> > --- > drivers/i3c/device.c | 8 ++++++++ > include/linux/i3c/device.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > index 472be99..8ab8e4c 100644 > --- a/drivers/i3c/device.c > +++ b/drivers/i3c/device.c > @@ -235,6 +235,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev) > } > EXPORT_SYMBOL_GPL(dev_to_i3cdev); > > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev) > +{ > + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver); > + > + return i3cdrv->id_table; > +} > +EXPORT_SYMBOL_GPL(i3c_get_device_id); I think what you want is i3c_device_match_id(). Just move the function to drivers/i3c/device.c, export it and define its prototype in include/i3c/device.h. > + > /** > * i3c_driver_register_with_owner() - register an I3C device driver > * > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h > index 7ee7e30..ee48886 100644 > --- a/include/linux/i3c/device.h > +++ b/include/linux/i3c/device.h > @@ -211,6 +211,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv) > > struct device *i3cdev_to_dev(struct i3c_device *i3cdev); > struct i3c_device *dev_to_i3cdev(struct device *dev); > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev); > > static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev, > void *data)
Hi Boris, From: Boris Brezillon <boris.brezillon@collabora.com> Date: Tue, Apr 16, 2019 at 07:18:25 > On Mon, 15 Apr 2019 21:19:40 +0200 > Vitor Soares <vitor.soares@synopsys.com> wrote: > > > This helper return the i3c_device_id structure in order the client > > have access to the driver data. > > > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> > > --- > > drivers/i3c/device.c | 8 ++++++++ > > include/linux/i3c/device.h | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > > index 472be99..8ab8e4c 100644 > > --- a/drivers/i3c/device.c > > +++ b/drivers/i3c/device.c > > @@ -235,6 +235,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(dev_to_i3cdev); > > > > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev) > > +{ > > + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver); > > + > > + return i3cdrv->id_table; > > +} > > +EXPORT_SYMBOL_GPL(i3c_get_device_id); > > I think what you want is i3c_device_match_id(). I want the i3c_device_id struct of an i3c_device. What is the name that you suggest? >Just move the function > to drivers/i3c/device.c, export it and define its prototype in > include/i3c/device.h. You are right, this should go for the device side. > > > + > > /** > > * i3c_driver_register_with_owner() - register an I3C device driver > > * > > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h > > index 7ee7e30..ee48886 100644 > > --- a/include/linux/i3c/device.h > > +++ b/include/linux/i3c/device.h > > @@ -211,6 +211,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv) > > > > struct device *i3cdev_to_dev(struct i3c_device *i3cdev); > > struct i3c_device *dev_to_i3cdev(struct device *dev); > > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev); > > > > static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev, > > void *data) Best regards, Vitor Soares
diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c index 472be99..8ab8e4c 100644 --- a/drivers/i3c/device.c +++ b/drivers/i3c/device.c @@ -235,6 +235,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev) } EXPORT_SYMBOL_GPL(dev_to_i3cdev); +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev) +{ + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver); + + return i3cdrv->id_table; +} +EXPORT_SYMBOL_GPL(i3c_get_device_id); + /** * i3c_driver_register_with_owner() - register an I3C device driver * diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h index 7ee7e30..ee48886 100644 --- a/include/linux/i3c/device.h +++ b/include/linux/i3c/device.h @@ -211,6 +211,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv) struct device *i3cdev_to_dev(struct i3c_device *i3cdev); struct i3c_device *dev_to_i3cdev(struct device *dev); +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev); static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev, void *data)
This helper return the i3c_device_id structure in order the client have access to the driver data. Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> --- drivers/i3c/device.c | 8 ++++++++ include/linux/i3c/device.h | 1 + 2 files changed, 9 insertions(+)