| Message ID | 72bc802eb51555b8cf33595a87e06940e367777c.1554721267.git.vitor.soares@synopsys.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 907621e94d49b85cd76f13110eceb940a182c69e |
| Headers | show |
| Series | [v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask | expand |
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.0.7, v4.19.34, v4.14.111, v4.9.168, v4.4.178, v3.18.138.
v5.0.7: Build OK!
v4.19.34: Failed to apply! Possible dependencies:
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
603f2bee2c54 ("i3c: master: Add driver for Cadence IP")
v4.14.111: Failed to apply! Possible dependencies:
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
603f2bee2c54 ("i3c: master: Add driver for Cadence IP")
v4.9.168: Failed to apply! Possible dependencies:
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
603f2bee2c54 ("i3c: master: Add driver for Cadence IP")
v4.4.178: Failed to apply! Possible dependencies:
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
603f2bee2c54 ("i3c: master: Add driver for Cadence IP")
v3.18.138: Failed to apply! Possible dependencies:
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
603f2bee2c54 ("i3c: master: Add driver for Cadence IP")
How should we proceed with this patch?
--
Thanks,
Sasha
diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index 5927922..10c26ff 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -300,7 +300,7 @@ to_dw_i3c_master(struct i3c_master_controller *master) static void dw_i3c_master_disable(struct dw_i3c_master *master) { - writel(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_ENABLE, + writel(readl(master->regs + DEVICE_CTRL) & ~DEV_CTRL_ENABLE, master->regs + DEVICE_CTRL); }
The controller was being disabled incorrectly. The correct way is to clear the DEV_CTRL_ENABLE bit. Fix this by by clearing this bit. Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: <stable@vger.kernel.org> --- Changes v1 to v2: Fix commit Message Add Cc: <stable@vger.kernel.org> drivers/i3c/master/dw-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)