From patchwork Sun Jul 16 21:26:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Collamati X-Patchwork-Id: 13314896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52789EB64DD for ; Sun, 16 Jul 2023 21:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbjGPV0t (ORCPT ); Sun, 16 Jul 2023 17:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjGPV0s (ORCPT ); Sun, 16 Jul 2023 17:26:48 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72A721B5; Sun, 16 Jul 2023 14:26:47 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-993d1f899d7so569658466b.2; Sun, 16 Jul 2023 14:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689542806; x=1692134806; h=content-transfer-encoding:cc:to:content-language:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=r9fUriBNhyXlFqH896tCKceodeOZncM96JEwNdZlGmY=; b=nnIYBAC8QvA7YAUa4Vzzqe5yckDs8Z498G+x/Kq3QIoULdgv0aoANmELok8XkG84Bf WSuw46lDKWrE2RdDOuuZAAJbgNLSkKtFIMVxifvZOzVPtxyxZckD+qnNtf/Lqjlh1Rjv F2eBNx8tqsL/juliwMDHuOrTtPA+Z23xBMGBIHANbHzzjplW6itXOin70Qotxg9YZRoj peNLcGuhkEvsNYudvkFcDYHYMkn39canCPVSFkLZ7vBqGyE7FAtYkPuBhosJCk+TiDvl BXCtwA9MnaMLcnTeSYVmz+BcCtyqUePF7cZCKiuhUu1wtXBOvdLs0be6usDS5+RQtxG+ mC4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689542806; x=1692134806; h=content-transfer-encoding:cc:to:content-language:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=r9fUriBNhyXlFqH896tCKceodeOZncM96JEwNdZlGmY=; b=fFdMo9dZv0//DzQLFpkZ0UQPxHyjPGlONeyOKCNWkWc1IctUYeEx71TCnIL3e5g/ER qG3Zs/2CVJ0b88RPxxwrAO+hvJD/+EFQEK9lqgu33gALNqInbk3xOPxBDrCza3hF+R04 SRUmdFFemlv/dz6tzWZJwd1jFS5oJHes9SydAOwbBHuy2fVzdashh+LKvcJRqpPNX8ZP ZQMmpBY9ZEcHDChzjV9djgcaBmQHshSL9A+4Rt74QS52Yc3jii2F+BeimmabYFKp9PWd 73Tm1EEZ32UqziVKW7nHLpsvsg5ndwOD2LiSBTk4t/q9IlsRQ4zSWadKNm14EJ0QgiQe qHXw== X-Gm-Message-State: ABy/qLbZFPQEU1uvYqzKWhu9F35eN89jMoeYUG4LlWqRc99oJrnp7rWF iAFbQj+TAKwMCjVZ8LL65ys= X-Google-Smtp-Source: APBJJlFB+YxCHXbGHtsl4KGzq9AcRZqCuCujF7+0ct5y7H2DgRNPXht5p00ijnzk8gso+SpqYa/jAw== X-Received: by 2002:a17:906:7397:b0:994:18c4:3303 with SMTP id f23-20020a170906739700b0099418c43303mr10188827ejl.18.1689542805589; Sun, 16 Jul 2023 14:26:45 -0700 (PDT) Received: from [192.168.4.4] (host-95-237-109-246.retail.telecomitalia.it. [95.237.109.246]) by smtp.gmail.com with ESMTPSA id la16-20020a170906ad9000b0098d2261d189sm8498147ejb.19.2023.07.16.14.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 14:26:45 -0700 (PDT) Message-ID: <0414e2e4-a17d-3435-e9e7-35b110233a6d@gmail.com> Date: Sun, 16 Jul 2023 23:26:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrea Collamati Subject: =?utf-8?q?=5BPATCH_v2_0/2=5D_add_mcp4728_I2C_DAC_driver=E2=80=8B?= Content-Language: en-US To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Jonathan Cameron , Rob Herring , Conor Dooley , William Breathitt Gray , Angelo Dureghello , Fabio Estevam , Lukas Bulwahn , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "andrea.collamati@gmail.com" Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Dear Krzysztof I release a V2 version. I hope I have understood all your requests. See below. > 2. Please use scripts/get_maintainers.pl to get a list of necessary > people and lists to CC (and consider --no-git-fallback argument). It > might happen, that command when run on an older kernel, gives you > outdated entries. Therefore please be sure you base your patches on > recent Linux kernel. > I was using branch master git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git but I saw it was too old. I switched to branch testing. > 6. mcp or MCP? What is this? Proper title is missing... also no > description. > I don't know whether using small o capital letters. Usually manufacturers use capital letter to identify the component but kernel drivers use lowercase in code. > > Shouldn't this binding be just merged with existing mcp4725? Are you > sure it's not similar device, IOW, are you sure you do not have vref supply? > Unfortunately they are not that similar. MCP4728 has two vref choices: - Use Vdd (power supply) as Vref - User Internal 2.048 V Vref source. Andrea Collamati (2): dt-bindings: iio: dac: add mcp4728.yaml iio: add mcp4728 I2C DAC driver .../bindings/iio/dac/microchip,mcp4728.yaml | 42 +++++++++ drivers/iio/dac/mcp4728.c | 93 +++++++++---------- 2 files changed, 86 insertions(+), 49 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml