mbox series

[V3,0/4] thermal: qcom: Add support for PMIC5 Gen2 ADC_TM

Message ID 1637647025-20409-1-git-send-email-quic_jprakash@quicinc.com (mailing list archive)
Headers show
Series thermal: qcom: Add support for PMIC5 Gen2 ADC_TM | expand

Message

Jishnu Prakash Nov. 23, 2021, 5:57 a.m. UTC 
Made following changes in this post:
Addressed comments given by Jonathan for qcom-spmi-adc-tm5.yaml.
Addressed comments given by Dmitry and Jonathan for qcom-spmi-adc-tm5.c.
Split patch for qcom-spmi-adc-tm5.c into two parts, one to refactor
code to support multiple device generations and the second to add
actual Gen2 ADC_TM changes.

Jishnu Prakash (4):
  dt-bindings: thermal: qcom: add PMIC5 Gen2 ADC_TM bindings
  iio: adc: qcom-vadc-common: add reverse scaling for PMIC5 Gen2 ADC_TM
  thermal: qcom: Add support for multiple generations of devices
  thermal: qcom: add support for PMIC5 Gen2 ADCTM

 .../bindings/thermal/qcom-spmi-adc-tm5.yaml        | 110 ++++-
 drivers/iio/adc/qcom-vadc-common.c                 |  11 +
 drivers/thermal/qcom/qcom-spmi-adc-tm5.c           | 451 +++++++++++++++++++--
 include/linux/iio/adc/qcom-vadc-common.h           |   2 +
 4 files changed, 541 insertions(+), 33 deletions(-)

Comments

Jonathan Cameron Nov. 26, 2021, 6:29 p.m. UTC | #1 
On Tue, 23 Nov 2021 11:27:00 +0530
Jishnu Prakash <quic_jprakash@quicinc.com> wrote:

> Made following changes in this post:
> Addressed comments given by Jonathan for qcom-spmi-adc-tm5.yaml.
> Addressed comments given by Dmitry and Jonathan for qcom-spmi-adc-tm5.c.
> Split patch for qcom-spmi-adc-tm5.c into two parts, one to refactor
> code to support multiple device generations and the second to add
> actual Gen2 ADC_TM changes.

Series is missing a change log.  Either in cover letter, or in
individual patches after the --

Jonathan

> 
> Jishnu Prakash (4):
>   dt-bindings: thermal: qcom: add PMIC5 Gen2 ADC_TM bindings
>   iio: adc: qcom-vadc-common: add reverse scaling for PMIC5 Gen2 ADC_TM
>   thermal: qcom: Add support for multiple generations of devices
>   thermal: qcom: add support for PMIC5 Gen2 ADCTM
> 
>  .../bindings/thermal/qcom-spmi-adc-tm5.yaml        | 110 ++++-
>  drivers/iio/adc/qcom-vadc-common.c                 |  11 +
>  drivers/thermal/qcom/qcom-spmi-adc-tm5.c           | 451 +++++++++++++++++++--
>  include/linux/iio/adc/qcom-vadc-common.h           |   2 +
>  4 files changed, 541 insertions(+), 33 deletions(-)
>
Jishnu Prakash Jan. 23, 2022, 2:43 p.m. UTC | #2 
Hi Jonathan,

On 11/26/2021 11:59 PM, Jonathan Cameron wrote:
> On Tue, 23 Nov 2021 11:27:00 +0530
> Jishnu Prakash <quic_jprakash@quicinc.com> wrote:
>
>> Made following changes in this post:
>> Addressed comments given by Jonathan for qcom-spmi-adc-tm5.yaml.
>> Addressed comments given by Dmitry and Jonathan for qcom-spmi-adc-tm5.c.
>> Split patch for qcom-spmi-adc-tm5.c into two parts, one to refactor
>> code to support multiple device generations and the second to add
>> actual Gen2 ADC_TM changes.
> Series is missing a change log.  Either in cover letter, or in
> individual patches after the --
>
> Jonathan


I'll add the change log in the cover letter in the next post.


>
>> Jishnu Prakash (4):
>>    dt-bindings: thermal: qcom: add PMIC5 Gen2 ADC_TM bindings
>>    iio: adc: qcom-vadc-common: add reverse scaling for PMIC5 Gen2 ADC_TM
>>    thermal: qcom: Add support for multiple generations of devices
>>    thermal: qcom: add support for PMIC5 Gen2 ADCTM
>>
>>   .../bindings/thermal/qcom-spmi-adc-tm5.yaml        | 110 ++++-
>>   drivers/iio/adc/qcom-vadc-common.c                 |  11 +
>>   drivers/thermal/qcom/qcom-spmi-adc-tm5.c           | 451 +++++++++++++++++++--
>>   include/linux/iio/adc/qcom-vadc-common.h           |   2 +
>>   4 files changed, 541 insertions(+), 33 deletions(-)
>>
Thanks,

Jishnu