From patchwork Wed Aug 15 20:38:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Frey X-Patchwork-Id: 10566815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EC4B6921 for ; Wed, 15 Aug 2018 20:35:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC2C22ACA9 for ; Wed, 15 Aug 2018 20:35:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A04262AE95; Wed, 15 Aug 2018 20:35:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50C6A2ACA9 for ; Wed, 15 Aug 2018 20:35:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbeHOX3O (ORCPT ); Wed, 15 Aug 2018 19:29:14 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40563 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbeHOX3O (ORCPT ); Wed, 15 Aug 2018 19:29:14 -0400 Received: by mail-pg1-f195.google.com with SMTP id x5-v6so989484pgp.7; Wed, 15 Aug 2018 13:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=c9/uN40948tG4KowU8CqV8UETUs5pIjKE0yTj/E5r0k=; b=f77NN0WIvGP4ssjciHS03z9PI/86y9Fi9l0VI9SxC3BH9ElvQfnPTER97oNvFSYmAR vHmFUHUmHTd0+UTMLdVrZc6izza4fYeBAzpMk71vsVA0JFgN3uDkYVKgrnLWocK7xaY2 FzPfUIJlfQrQXEfh/T9l93z8uXr+J4nunEoNK8CflCvUT5adBsCug8Nw1wDsjYCefj85 F6vB3jL4yveQMYfZWLQy4sLVv81YPwJrrBKF8uwcd+SYlAsmlzMwFDsqjJZrKfFWAUEL kcTzAHy9Pdjf7MWm4daisdUK8hvjHVs9vYil0vaZXpla9+ZstwJcuhMO4QwojF9vfE9J ekiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c9/uN40948tG4KowU8CqV8UETUs5pIjKE0yTj/E5r0k=; b=HgDDDC7gNHMeiIAUNAf9gSNdPenYLypgYEJ/qtH9887y7dY5Mo13E/ALlW1Qg70gnM /MAho54UDAXOnyOJUex0d7Sf056CMjk1EuxkrbbU1IeBkmXrZBtgHrXQiMfYd/T7ohId DuSdXF/q0cBsE/l7T0UvQbl81+L04um9zibneJ4hRBdU4DL/M2vGdbsixhyOKdxcEXNd 2fX4mSTw/mLAvsQxuA0lh4INHH9KnzjzjL7hSyBO6lwIiNAI4JdGlXaB4iiBIQiw6dKg 6cbuG9ic/EfY6ytnNJY/UAYnwmLqfBcLBcOKLob6TJvDHzZq9iBIIiGUNGMnrALgjUXQ 085g== X-Gm-Message-State: AOUpUlFfzzdNfN7LcMNPq9d86pdlTV1kGUgkyMeMEvrarvF3dLi3t/Iz EgZTh9aRQozvmbSYwXtq4mHdfo2E X-Google-Smtp-Source: AA+uWPzdYv3ktmLTdlbEgaPb79RxJG54D+AzfbrqfxUbGLxs23m0KeG0hyGaTwT6l19Wvtaj2JzDgg== X-Received: by 2002:a63:4857:: with SMTP id x23-v6mr26998458pgk.30.1534365330393; Wed, 15 Aug 2018 13:35:30 -0700 (PDT) Received: from dfrey-debian-linux.sierrawireless.local ([185.153.179.9]) by smtp.gmail.com with ESMTPSA id d9-v6sm35784055pfb.86.2018.08.15.13.35.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 13:35:29 -0700 (PDT) From: David Frey To: linux-iio@vger.kernel.org Cc: jic23@vger.kernel.org, himanshujha199640@gmail.com, David Frey Subject: [PATCH v2 0/7] bme680 cleanup Date: Wed, 15 Aug 2018 13:38:28 -0700 Message-Id: <20180815203835.21079-1-dpfrey@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Note that I don't currently have bme680 hardware available, so I am hoping that Himanshu is willing to validate the changes. v2: This version addresses Himanshu's feedback - split v1 patch 1 into 6 commits - substantially changed "simplify oversampling handling" after review identified a bug in the previous patch version and I spent some more time thinking about the problem v1: I have performed some minor cleanup on the bme680 driver. I don't think there's anything controversial in my changes. Let me know what you think David Frey (7): iio: chemical: bme680: use clamp macro iio: chemical: bme680: cleanup bme680_read_calib formatting iio: chemical: bme680: indent #defines consistently iio: chemical: bme680: change MSK->MASK in #defines iio: chemical: bme680: use GENMASK macro iio: chemical: bme680: use FIELD_GET macro iio: chemical: bme680: simplify oversampling handling drivers/iio/chemical/bme680.h | 17 +++-- drivers/iio/chemical/bme680_core.c | 144 +++++++++++++------------------------ 2 files changed, 59 insertions(+), 102 deletions(-)